-
Notifications
You must be signed in to change notification settings - Fork 229
Open
Labels
Description
Describe the bug
When setting a colour on a remote and setting the saturation from ~90%-100% the RGB output maxes out to
{"state":"ON","brightness":255,"color":{"r":255,"g":255,"b":255},"color_mode":"rgb"}
whereas the (MiBoxer) bulb shows the slight huge of the colour. This is subtle but vitally important as the remote never truly makes white at the highest saturation setting and thus the 'colour' as it appears in Home Assistant doesn't match reality. This is for remote output detected as fut089
.
The same result from multiple remotes.
I can reproduce the percieved full brightness, full saturation, colour from Home Assistant/milight-hub showing that there is an RGB equivalent of what the remote produces (i.e issue is in milight-hub). It appears that milight-hub is amplifying the values a little too zealously.
Steps to reproduce
- Configure Milight-hub to use Home Assistant mode and publish to MQTT
- Watch the
milight
MQTT topic - Change a remote colour to say full red and full brightness
- Increase the saturation towards 100%
- Note that the RGB values hit
{"r":255,"g":255,"b":255}
around 80% of the saturation scale with the base colour still visible. - Increasing saturation further does not change the brightness or RGB
Expected behaviour
- I expect that the value from the remote to never reach
{"r":255,"g":255,"b":255}
- I expect the value from the remote if input from Milight-hub or Home Assistant manually to produce exactly the same colour
- I expect that at full saturation the base colour is ever so slightly visible.
Setup information
Firmware version
1.13.1-beta2
Output of http://milight-hub.local/about
{"firmware":"milight-hub","version":"1.13.1-beta2","ip_address":"XXXX","reset_reason":"External System","variant":"nodemcuv2","free_heap":14256,"arduino_version":"3.1.2","free_stack":1104,"flash_used":18323,"flash_total":957314,"flash_pct_free":98,"mqtt":{"configured":true,"connected":true,"status":"Connected"},"queue_stats":{"length":0,"dropped_packets":0}}
Output of http://milight-hub.local/settings
{"admin_username":"","admin_password":"","ce_pin":16,"csn_pin":15,"reset_pin":0,"led_pin":-2,"radio_interface_type":"nRF24","packet_repeats":10,"http_repeat_factor":5,"auto_restart_period":0,"mqtt_server":"YYYY","mqtt_username":" ","mqtt_password":"","mqtt_topic_pattern":"milight/commands/:device_id/:device_type/:group_id","mqtt_update_topic_pattern":"","mqtt_state_topic_pattern":"milight/state/:device_id/:device_type/:group_id","mqtt_client_status_topic":"milight/client_status","simple_mqtt_client_status":true,"discovery_port":48899,"listen_repeats":9,"state_flush_interval":10000,"mqtt_state_rate_limit":500,"mqtt_debounce_delay":500,"mqtt_retain":true,"packet_repeat_throttle_sensitivity":0,"packet_repeat_throttle_threshold":200,"packet_repeat_minimum":3,"enable_automatic_mode_switching":false,"led_mode_wifi_config":"Fast toggle","led_mode_wifi_failed":"On","led_mode_operating":"Slow blip","led_mode_packet":"Flicker","led_mode_packet_count":3,"hostname":"milight-hub","rf24_power_level":"MAX","rf24_listen_channel":"HIGH","wifi_static_ip":"","wifi_static_ip_gateway":"","wifi_static_ip_netmask":"","packet_repeats_per_loop":10,"home_assistant_discovery_prefix":"homeassistant/","wifi_mode":"g","default_transition_period":500,"rf24_channels":["LOW","MID","HIGH"],"device_ids":[26265,26953,26985,38550],"gateway_configs":[],"group_state_fields":["state","brightness","computed_color","mode","color_temp","color_mode"],"ignored_listen_protocols":[]}