Skip to content

Commit 2a9c7fc

Browse files
authored
ci: improve workflows (#3380)
* ci: improve workflows * debug: check different minor versions * ci: use same MySQL version in "ci-linux" * debug: focus Node.js static parsers to coverage workflows * debug: focus all MySQL 9 versions in "mysql" workflow * chore: remove debug * ci: add MySQL 9.0 to coverage workflow
1 parent 603c246 commit 2a9c7fc

File tree

12 files changed

+31
-28
lines changed

12 files changed

+31
-28
lines changed

.github/workflows/benchmark.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ jobs:
1818
strategy:
1919
fail-fast: false
2020
matrix:
21-
node-version: [20.x]
21+
node-version: [22]
2222
mysql-version: ["mysql:8.0.18"]
2323
use-compression: [0]
2424
use-tls: [0]

.github/workflows/canary.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ jobs:
5050
if: steps.check_commit.outputs.publish == 'true'
5151
uses: actions/setup-node@v4
5252
with:
53-
node-version: '22.x'
53+
node-version: 22
5454
registry-url: 'https://registry.npmjs.org'
5555

5656
- name: Cache dependencies

.github/workflows/ci-coverage.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@ jobs:
1919
strategy:
2020
fail-fast: false
2121
matrix:
22-
node-version: [20.x]
23-
mysql-version: ['mysql:5.7', 'mysql:8.0.33']
22+
node-version: [22]
23+
mysql-version: ['mysql:5.7', 'mysql:8.0', 'mysql:9.0']
2424
use-compression: [0, 1]
2525
use-tls: [0, 1]
2626
static-parser: [0, 1]

.github/workflows/ci-linux.yml

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -18,19 +18,18 @@ jobs:
1818
strategy:
1919
fail-fast: false
2020
matrix:
21-
node-version: [18.x, 20.x, 22.x, 23.x]
22-
mysql-version: ['mysql:8.0.33']
21+
node-version: [18, 20, 22, 23]
22+
mysql-version: ['mysql:8.3']
2323
use-compression: [0, 1]
2424
use-tls: [0, 1]
25-
static-parser: [0, 1]
2625
mysql_connection_url_key: ['']
26+
# static-parser: [0, 1] # Already tested in "ci-coverage"
2727
# TODO - add mariadb to the matrix. currently few tests are broken due to mariadb incompatibilities
2828

2929
env:
3030
MYSQL_CONNECTION_URL: ${{ secrets[matrix.mysql_connection_url_key] }}
31-
STATIC_PARSER: ${{ matrix.static-parser }}
3231

33-
name: Node.js ${{ matrix.node-version }} - DB ${{ matrix.mysql-version }}${{ matrix.mysql_connection_url_key }} - SSL=${{matrix.use-tls}} Compression=${{matrix.use-compression}} Static Parser=${{matrix.static-parser}}
32+
name: Node.js ${{ matrix.node-version }} - DB ${{ matrix.mysql-version }}${{ matrix.mysql_connection_url_key }} - SSL=${{matrix.use-tls}} Compression=${{matrix.use-compression}}
3433

3534
steps:
3635
- uses: actions/checkout@v4
@@ -68,7 +67,7 @@ jobs:
6867
fail-fast: false
6968
matrix:
7069
bun-version: [latest, canary]
71-
mysql-version: ['mysql:8.0.33']
70+
mysql-version: ['mysql:8.3']
7271
use-compression: [0, 1]
7372
use-tls: [0, 1]
7473
static-parser: [0, 1]
@@ -123,7 +122,7 @@ jobs:
123122
fail-fast: false
124123
matrix:
125124
deno-version: [v1.x]
126-
mysql-version: ['mysql:8.0.33']
125+
mysql-version: ['mysql:8.3']
127126
use-compression: [0, 1]
128127
static-parser: [0, 1]
129128
# TODO: investigate error when using SSL (1)
@@ -181,7 +180,7 @@ jobs:
181180
fail-fast: false
182181
matrix:
183182
deno-version: [v2.x, canary]
184-
mysql-version: ['mysql:8.0.33']
183+
mysql-version: ['mysql:8.3']
185184
use-compression: [0, 1]
186185
static-parser: [0, 1]
187186
# TODO: investigate error when using SSL (1)
@@ -209,7 +208,7 @@ jobs:
209208
- name: Set up Node.js
210209
uses: actions/setup-node@v4
211210
with:
212-
node-version: 20
211+
node-version: 22
213212
- name: Cache dependencies
214213
uses: actions/cache@v4
215214
with:

.github/workflows/ci-mysql.yml

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -17,15 +17,18 @@ jobs:
1717
strategy:
1818
fail-fast: false
1919
matrix:
20-
node-version: [20.x] # LTS
20+
node-version: [22]
2121
mysql-version:
2222
[
23-
'mysql:5.7',
24-
'mysql:8.0.18',
25-
'mysql:8.0.22',
26-
'mysql:8.0.33',
27-
'mysql:9.0.1',
28-
'mysql:latest',
23+
# 'mysql:5.7', # Already tested in "ci-coverage"
24+
# 'mysql:8.0', # Already tested in "ci-coverage"
25+
'mysql:8.1',
26+
'mysql:8.2',
27+
# 'mysql:8.3', # Already tested in "ci-linux"
28+
# 'mysql:8.4', # TODO: Tests never end
29+
# 'mysql:9.0', # Already tested in "ci-coverage"
30+
'mysql:9.1',
31+
'mysql:9.2',
2932
]
3033
use-compression: [0, 1]
3134
use-tls: [0, 1]
@@ -36,6 +39,7 @@ jobs:
3639
mysql-version: 'datagrip/mysql:5.1'
3740
use-compression: 0
3841
use-tls: 0
42+
3943
env:
4044
MYSQL_CONNECTION_URL: ${{ secrets[matrix.mysql_connection_url_key] }}
4145

@@ -68,4 +72,4 @@ jobs:
6872
run: node tools/wait-up.js
6973

7074
- name: Run tests
71-
run: FILTER=${{matrix.filter}} MYSQL_USE_TLS=${{ matrix.use-tls }} MYSQL_USE_COMPRESSION=${{ matrix.use-compression }} npm run test
75+
run: FILTER=${{matrix.filter}} npm run test

.github/workflows/ci-osx.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ jobs:
1818
strategy:
1919
fail-fast: false
2020
matrix:
21-
node-version: [20.x] # LTS
21+
node-version: [22]
2222
use-compression: [0, 1]
2323
use-tls: [0, 1]
2424

.github/workflows/ci-tsc-build.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ jobs:
1313
strategy:
1414
fail-fast: false
1515
matrix:
16-
node-version: [20.x]
16+
node-version: [22]
1717

1818
name: Node.js ${{ matrix.node-version }}
1919
steps:

.github/workflows/ci-website.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ jobs:
1515
- name: Actions - Setup NodeJS
1616
uses: actions/setup-node@v4
1717
with:
18-
node-version: '20.x'
18+
node-version: 22
1919

2020
- name: Cache Dependencies
2121
uses: actions/cache@v4

.github/workflows/ci-windows.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ jobs:
1818
strategy:
1919
fail-fast: false
2020
matrix:
21-
node-version: [20.x] # LTS
21+
node-version: [22]
2222
mysql-version: ['8.0']
2323
use-compression: [0, 1]
2424
use-tls: [0, 1]

.github/workflows/gh-pages.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ jobs:
1717
- name: Actions - Setup NodeJS
1818
uses: actions/setup-node@v4
1919
with:
20-
node-version: '18.x'
20+
node-version: 22
2121

2222
- name: Cache Dependencies
2323
uses: actions/cache@v4

0 commit comments

Comments
 (0)