Merge pull request #1642 from Andrew-Opplaud/master

renamed done to onResult

Author: sidorares

lib/commands/quit.js

@@ -7,7 +7,7 @@ const Packet = require('../packets/packet.js');
 class Quit extends Command {
   constructor(callback) {
     super();
-    this.done = callback;
+    this.onResult = callback;
   }
 
   start(packet, connection) {
@@ -18,8 +18,8 @@ class Quit extends Command {
       0,
       5
     );
-    if (this.done) {
-      this.done();
+    if (this.onResult) {
+      this.onResult();
     }
     connection.writePacket(quit);
     return null;

test/unit/commands/test-quit.js

@@ -0,0 +1,9 @@
+'use strict';
+
+const assert = require('assert');
+const Quit = require('../../../lib/commands/quit');
+
+const testCallback = err => console.info( err.message );
+const testQuit = new Quit( testCallback );
+
+assert.strictEqual( testQuit.onResult, testCallback );