Skip to content

Commit 90d21b6

Browse files
committed
refactor: resolve eslint no-use-before-define
1 parent 570643a commit 90d21b6

File tree

7 files changed

+349
-381
lines changed

7 files changed

+349
-381
lines changed

promise.d.ts

Lines changed: 40 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -12,19 +12,25 @@ import {
1212
import { EventEmitter } from 'events';
1313
export * from './index';
1414

15-
export interface Connection extends EventEmitter {
16-
config: ConnectionOptions;
17-
threadId: number;
18-
19-
connect(): Promise<void>;
20-
ping(): Promise<void>;
21-
22-
beginTransaction(): Promise<void>;
23-
commit(): Promise<void>;
24-
rollback(): Promise<void>;
25-
26-
changeUser(options: ConnectionOptions): Promise<void>;
15+
export interface PreparedStatementInfo {
16+
close(): Promise<void>;
17+
execute(
18+
parameters: any[]
19+
): Promise<
20+
[
21+
(
22+
| RowDataPacket[][]
23+
| RowDataPacket[]
24+
| OkPacket
25+
| OkPacket[]
26+
| ResultSetHeader
27+
),
28+
FieldPacket[]
29+
]
30+
>;
31+
}
2732

33+
export interface Connection extends EventEmitter {
2834
query<
2935
T extends
3036
| RowDataPacket[][]
@@ -111,7 +117,24 @@ export interface Connection extends EventEmitter {
111117
values: any | any[] | { [param: string]: any }
112118
): Promise<[T, FieldPacket[]]>;
113119

120+
config: ConnectionOptions;
121+
122+
threadId: number;
123+
124+
connect(): Promise<void>;
125+
126+
ping(): Promise<void>;
127+
128+
beginTransaction(): Promise<void>;
129+
130+
commit(): Promise<void>;
131+
132+
rollback(): Promise<void>;
133+
134+
changeUser(options: ConnectionOptions): Promise<void>;
135+
114136
prepare(options: string | QueryOptions): Promise<PreparedStatementInfo>;
137+
115138
unprepare(sql: string | QueryOptions): void;
116139

117140
end(options?: any): Promise<void>;
@@ -224,15 +247,19 @@ export interface Pool extends EventEmitter, Connection {
224247

225248
getConnection(): Promise<PoolConnection>;
226249
releaseConnection(connection: PoolConnection): void;
250+
227251
on(event: 'connection', listener: (connection: PoolConnection) => any): this;
228252
on(event: 'acquire', listener: (connection: PoolConnection) => any): this;
229253
on(event: 'release', listener: (connection: PoolConnection) => any): this;
230254
on(event: 'enqueue', listener: () => any): this;
255+
231256
end(): Promise<void>;
232257

233258
escape(value: any): string;
259+
234260
escapeId(value: string): string;
235261
escapeId(values: string[]): string;
262+
236263
format(sql: string, values?: any | any[] | { [param: string]: any }): string;
237264

238265
pool: CorePool;
@@ -242,23 +269,6 @@ export function createConnection(connectionUri: string): Promise<Connection>;
242269
export function createConnection(
243270
config: ConnectionOptions
244271
): Promise<Connection>;
272+
245273
export function createPool(connectionUri: string): Pool;
246274
export function createPool(config: PoolOptions): Pool;
247-
248-
export interface PreparedStatementInfo {
249-
close(): Promise<void>;
250-
execute(
251-
parameters: any[]
252-
): Promise<
253-
[
254-
(
255-
| RowDataPacket[][]
256-
| RowDataPacket[]
257-
| OkPacket
258-
| OkPacket[]
259-
| ResultSetHeader
260-
),
261-
FieldPacket[]
262-
]
263-
>;
264-
}

typings/mysql/index.d.ts

Lines changed: 45 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -1,47 +1,20 @@
11
import * as crypto from 'crypto';
2-
3-
import BaseConnection = require('./lib/Connection');
2+
import * as BasePool from './lib/Pool';
3+
import * as BaseConnection from './lib/Connection';
4+
import {
5+
PoolCluster as BasePoolCluster,
6+
PoolClusterOptions,
7+
} from './lib/PoolCluster';
48
import { ConnectionOptions, SslOptions } from './lib/Connection';
59
import BasePoolConnection = require('./lib/PoolConnection');
6-
import BasePool = require('./lib/Pool');
710
import { PoolOptions } from './lib/Pool';
8-
import BasePoolCluster = require('./lib/PoolCluster');
9-
import { PoolClusterOptions } from './lib/PoolCluster';
1011
import BaseQuery = require('./lib/protocol/sequences/Query');
1112
import BasePrepare = require('./lib/protocol/sequences/Prepare');
1213
import { QueryOptions, QueryError } from './lib/protocol/sequences/Query';
1314
import { PrepareStatementInfo } from './lib/protocol/sequences/Prepare';
1415
import Server = require('./lib/Server');
1516
import { Connection as PromiseConnection } from '../../promise';
1617

17-
export function createConnection(connectionUri: string): Connection;
18-
export function createConnection(
19-
config: BaseConnection.ConnectionOptions
20-
): Connection;
21-
export function createPool(config: BasePool.PoolOptions): BasePool;
22-
export function createPoolCluster(
23-
config?: BasePoolCluster.PoolClusterOptions
24-
): PoolCluster;
25-
export function escape(value: any): string;
26-
export function escapeId(value: any): string;
27-
export function format(sql: string): string;
28-
export function format(
29-
sql: string,
30-
values: any[],
31-
stringifyObjects?: boolean,
32-
timeZone?: string
33-
): string;
34-
export function format(
35-
sql: string,
36-
values: any,
37-
stringifyObjects?: boolean,
38-
timeZone?: string
39-
): string;
40-
export function raw(sql: string): {
41-
toSqlString: () => string;
42-
};
43-
export function createServer(handler: (conn: BaseConnection) => any): Server;
44-
4518
export {
4619
ConnectionOptions,
4720
SslOptions,
@@ -51,14 +24,15 @@ export {
5124
QueryError,
5225
PrepareStatementInfo,
5326
};
27+
5428
export * from './lib/protocol/packets/index';
5529

5630
// Expose class interfaces
57-
export interface Connection extends BaseConnection {
31+
export interface Connection extends BaseConnection.Connection {
5832
promise(promiseImpl?: PromiseConstructor): PromiseConnection;
5933
}
34+
export interface Pool extends BasePool.Pool {}
6035
export interface PoolConnection extends BasePoolConnection {}
61-
export interface Pool extends BasePool {}
6236
export interface PoolCluster extends BasePoolCluster {}
6337
export interface Query extends BaseQuery {}
6438
export interface Prepare extends BasePrepare {}
@@ -96,3 +70,39 @@ export const authPlugins: {
9670
joinServerPublicKey?: (data: Buffer) => void;
9771
}>;
9872
};
73+
74+
export function createConnection(connectionUri: string): Connection;
75+
export function createConnection(
76+
config: BaseConnection.ConnectionOptions
77+
): Connection;
78+
79+
export function createPool(config: BasePool.PoolOptions): BasePool.Pool;
80+
81+
export function createPoolCluster(config?: PoolClusterOptions): PoolCluster;
82+
83+
export function escape(value: any): string;
84+
85+
export function escapeId(value: any): string;
86+
87+
export function format(sql: string): string;
88+
export function format(
89+
sql: string,
90+
values: any[],
91+
stringifyObjects?: boolean,
92+
timeZone?: string
93+
): string;
94+
95+
export function format(
96+
sql: string,
97+
values: any,
98+
stringifyObjects?: boolean,
99+
timeZone?: string
100+
): string;
101+
102+
export function raw(sql: string): {
103+
toSqlString: () => string;
104+
};
105+
106+
export function createServer(
107+
handler: (conn: BaseConnection.Connection) => any
108+
): Server;

0 commit comments

Comments
 (0)