test(timeout): use a mock server instead of hard-coded host

Author: yuxizhe

test/integration/config/test-connect-timeout.js

@@ -1,20 +1,33 @@
 'use strict';
-
-const common = require('../../common');
-const connection = common.createConnection({
-  host: 'www.google.com'
-});
+const portfinder = require('portfinder');
 const assert = require('assert');
+const mysql = require('../../../index.js');
+
+console.log('test connect timeout');
+
+portfinder.getPort((err, port) => {
+  const server = mysql.createServer();
+  server.on('connection', () => {
+    // Let connection time out
+  });
+
+  server.listen(port);
 
-let errorCount = 0;
-let error = null;
+  const connection = mysql.createConnection({ 
+    host: 'localhost',
+    port: port,
+    connectTimeout: 1000,
+  });
 
-connection.on('error', err => {
-  errorCount++;
-  error = err;
+  connection.on('error', err => {
+    assert.equal(err.code, 'ETIMEDOUT');
+    connection.destroy();
+    server._server.close();
+    console.log('ok');
+  });
 });
 
-process.on('exit', () => {
-  assert.equal(errorCount, 1);
-  assert.equal(error.code, 'ETIMEDOUT');
+process.on('uncaughtException', err => {
+  assert.equal(err.message, 'Connection lost: The server closed the connection.');
+  assert.equal(err.code, 'PROTOCOL_CONNECTION_LOST');
 });

test/integration/connection/test-connect-timeout.js

@@ -1,8 +1,13 @@
 'use strict';
 
+const portfinder = require('portfinder');
+const assert = require('assert');
 const common = require('../../common');
+const mysql = require('../../../index.js');
+
 const connection = common.createConnection({ debug: false });
-const assert = require('assert');
+
+console.log('test query timeout');
 
 connection.query({ sql: 'SELECT sleep(3) as a', timeout: 500 }, (err, res) => {
   assert.equal(res, null);
@@ -35,16 +40,36 @@ connection.execute('SELECT sleep(1) as a', (err, res) => {
   connection.end();
 });
 
-const connectionTimeout = common.createConnection({ 
-  host: '10.255.255.1',
-  debug: false,
-  connectTimeout: 100, 
+/**
+ * if connect timeout
+ * we should return connect timeout error instead of query timeout error
+ */
+portfinder.getPort((err, port) => {
+  const server = mysql.createServer();
+  server.on('connection', () => {
+    // Let connection time out
+  });
+  server.listen(port);
+
+  const connectionTimeout = mysql.createConnection({ 
+    host: 'localhost',
+    port: port,
+    connectTimeout: 1000,
+  });
+
+  // return connect timeout error first
+  connectionTimeout.query({ sql: 'SELECT sleep(3) as a', timeout: 50 }, (err, res) => {
+    console.log('ok');
+    assert.equal(res, null);
+    assert.ok(err);
+    assert.equal(err.code, 'ETIMEDOUT');
+    assert.equal(err.message, 'connect ETIMEDOUT');
+    connectionTimeout.destroy();
+    server._server.close();
+  });
 });
 
-// return connect timeout error first
-connectionTimeout.query({ sql: 'SELECT sleep(3) as a', timeout: 50 }, (err, res) => {
-  assert.equal(res, null);
-  assert.ok(err);
-  assert.equal(err.code, 'ETIMEDOUT');
-  assert.equal(err.message, 'connect ETIMEDOUT');
+process.on('uncaughtException', err => {
+  assert.equal(err.message, 'Connection lost: The server closed the connection.');
+  assert.equal(err.code, 'PROTOCOL_CONNECTION_LOST');
 });