Skip to content

Commit b6cac7b

Browse files
mateuscbsidorares
authored andcommitted
Modifed parseLengthCodedIntString to return null instead of empty string for null columns.
1 parent ee26b4e commit b6cac7b

File tree

2 files changed

+5
-13
lines changed

2 files changed

+5
-13
lines changed

lib/packets/packet.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -669,7 +669,7 @@ Packet.prototype.parseLengthCodedInt = function(supportBigNumbers) {
669669
};
670670

671671
Packet.prototype.parseLengthCodedIntString = function() {
672-
return this.readString(this.readLengthCodedNumber(), 'binary');
672+
return this.readLengthCodedString('binary');
673673
};
674674

675675
Packet.prototype.parseLengthCodedFloat = function() {

test/integration/connection/test-binary-longlong.js

Lines changed: 4 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ var values = [
1818
['-11', '11'],
1919
['965432100123456789', '1965432100123456789'],
2020
['-965432100123456789', '2965432100123456789'],
21-
[null, null],
21+
[null, null]
2222
];
2323

2424
conn.connect(function(err) {
@@ -51,15 +51,7 @@ conn.connect(function(err) {
5151
{ id: 5, ls: null, lu: null }
5252
];
5353

54-
var bigNums_query_bnStringsTrueTrue = [
55-
{ id: 1, ls: 10, lu: 10 },
56-
{ id: 2, ls: -11, lu: 11 },
57-
{ id: 3, ls: '965432100123456789', lu: '1965432100123456789' },
58-
{ id: 4, ls: '-965432100123456789', lu: '2965432100123456789' },
59-
{ id: 5, ls: '', lu: '' }
60-
];
61-
62-
var bigNums_execute_bnStringsTrueTrue = [
54+
var bigNums_bnStringsTrueTrue = [
6355
{ id: 1, ls: 10, lu: 10 },
6456
{ id: 2, ls: -11, lu: 11 },
6557
{ id: 3, ls: '965432100123456789', lu: '1965432100123456789' },
@@ -117,9 +109,9 @@ conn.connect(function(err) {
117109

118110
testQuery(false, false, bigNums_bnStringsFalse);
119111
testQuery(true, false, bigNums_bnStringsTrueFalse);
120-
testQuery(true, true, bigNums_query_bnStringsTrueTrue);
112+
testQuery(true, true, bigNums_bnStringsTrueTrue);
121113

122114
testExecute(false, false, bigNums_bnStringsFalse);
123115
testExecute(true, false, bigNums_bnStringsTrueFalse);
124-
testExecute(true, true, bigNums_execute_bnStringsTrueTrue);
116+
testExecute(true, true, bigNums_bnStringsTrueTrue);
125117
});

0 commit comments

Comments
 (0)