needed to create non latin table

Author: sushantdhiman

lib/commands/client_handshake.js

@@ -17,7 +17,7 @@ ClientHandshake.prototype.start = function () {
 };
 
 ClientHandshake.prototype.sendSSLRequest = function (connection) {
-  var sslRequest = new Packets.SSLRequest(this.clientFlags);
+  var sslRequest = new Packets.SSLRequest(this.clientFlags, connection.config.charsetNumber);
   connection.writePacket(sslRequest.toPacket());
 };
 

lib/connection_config.js

@@ -59,7 +59,7 @@ function ConnectionConfig (options) {
   this.maxPacketSize = 0;
   this.charsetNumber = (options.charset)
     ? ConnectionConfig.getCharsetNumber(options.charset)
-    : options.charsetNumber || Charsets.UTF8_GENERAL_CI;
+    : options.charsetNumber || Charsets.UTF8MB4_UNICODE_CI;
 
   this.compress = options.compress || false;
 

lib/packets/ssl_request.js

@@ -2,9 +2,10 @@ var ClientConstants = require('../constants/client');
 var Packet = require('../packets/packet');
 var Charsets = require('../constants/charsets');
 
-function SSLRequest (flags)
+function SSLRequest (flags, charset)
 {
   this.clientFlags = flags | ClientConstants.SSL;
+  this.charset = charset;
 }
 
 SSLRequest.prototype.toPacket = function ()
@@ -17,7 +18,7 @@ SSLRequest.prototype.toPacket = function ()
 
   packet.writeInt32(this.clientFlags);
   packet.writeInt32(0); // max packet size. todo: move to config
-  packet.writeInt8(Charsets.UTF8_GENERAL_CI);
+  packet.writeInt8(this.charset);
   return packet;
 };
 

test/integration/connection/test-charset-encoding.js

@@ -5,14 +5,15 @@ var assert = require('assert');
 // test data stores
 var testData = [
   'ютф восемь',
+  'Experimental',
   'परीक्षण',
   'test тест テスト փորձաsրկում পরীক্ষা kiểm tra',
   'ტესტი પરીક્ષણ  מבחן פּרובירן اختبار'
 ];
 
 var resultData = null;
 
-// tests
+// test inserting of non latin data if we are able to parse it
 
 var testEncoding = function (err) {
   assert.ifError(err);
@@ -35,13 +36,15 @@ var testEncoding = function (err) {
 
 // init test sequence
 (function () {
-  connection.query(
-    'CREATE TABLE IF NOT EXISTS `test-charset-encoding` ' +
-    '( `field` VARCHAR(1000) CHARACTER SET latin1 COLLATE latin1_danish_ci)',
-    function (err) {
-      assert.ifError(err);
-      connection.query('DELETE from `test-charset-encoding`', testEncoding);
-    });
+  connection.query('DROP TABLE IF EXISTS `test-charset-encoding`', function (err) {
+    connection.query(
+      'CREATE TABLE IF NOT EXISTS `test-charset-encoding` ' +
+      '( `field` VARCHAR(1000) CHARACTER SET utf8mb4 COLLATE utf8mb4_unicode_ci)',
+      function (err) {
+        assert.ifError(err);
+        connection.query('DELETE from `test-charset-encoding`', testEncoding);
+      });
+  });
 })();
 
 process.on('exit', function () {