Skip to content

Commit ece3707

Browse files
author
Andrey Sidorov
committed
use utf8 for UTF8MB4 charsets
1 parent e797d91 commit ece3707

File tree

2 files changed

+9
-6
lines changed

2 files changed

+9
-6
lines changed

lib/constants/charset_encodings.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ module.exports = [
77
'hebrew', null, 'tis620', 'euckr', 'latin7', 'latin2', 'koi8u', 'cp1251',
88
'gb2312', 'greek', 'cp1250', 'latin2', 'gbk', 'cp1257', 'latin5', 'latin1',
99
'armscii8', 'cesu8', 'cp1250', 'ucs2', 'cp866', 'keybcs2', 'macintosh', 'macroman',
10-
'cp852', 'latin7', 'latin7', 'macintosh', 'cp1250', 'cesu8', 'cesu8', 'latin1',
10+
'cp852', 'latin7', 'latin7', 'macintosh', 'cp1250', 'utf8', 'utf8', 'latin1',
1111
'latin1', 'latin1', 'cp1251', 'cp1251', 'cp1251', 'macroman', 'utf16', 'utf16',
1212
'utf16le', 'cp1256', 'cp1257', 'cp1257', 'utf32', 'utf32', 'utf16le', 'binary',
1313
'armscii8', 'ascii', 'cp1250', 'cp1256', 'cp866', 'dec8', 'greek', 'hebrew',
@@ -30,8 +30,8 @@ module.exports = [
3030
'cesu8', 'cesu8', 'cesu8', 'cesu8', 'cesu8', 'cesu8', 'cesu8', 'cesu8',
3131
'cesu8', 'cesu8', 'cesu8', 'cesu8', 'cesu8', 'cesu8', 'cesu8', 'cesu8',
3232
null, null, null, null, null, null, null, 'cesu8',
33-
'cesu8', 'cesu8', 'cesu8', 'cesu8', 'cesu8', 'cesu8', 'cesu8', 'cesu8',
34-
'cesu8', 'cesu8', 'cesu8', 'cesu8', 'cesu8', 'cesu8', 'cesu8', 'cesu8',
35-
'cesu8', 'cesu8', 'cesu8', 'cesu8', 'cesu8', 'cesu8', 'cesu8', 'cesu8',
33+
'utf8', 'utf8', 'utf8', 'utf8', 'utf8', 'utf8', 'utf8', 'utf8',
34+
'utf8', 'utf8', 'utf8', 'utf8', 'utf8', 'utf8', 'utf8', 'utf8',
35+
'utf8', 'utf8', 'utf8', 'utf8', 'utf8', 'utf8', 'utf8', 'utf8',
3636
'gb18030', 'gb18030', 'gb18030'
3737
];

tools/generate-charset-mapping.js

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ var charsets = []
1616

1717
var mysql2iconv = {
1818
utf8: 'cesu8',
19-
utf8mb4: 'cesu8',
19+
utf8mb4: 'utf8',
2020
// need to check that this is correct mapping
2121
macce: 'macintosh', // Mac Central European
2222
eucjpms: 'eucjp' // UJIS for Windows Japanese
@@ -34,7 +34,10 @@ conn.query('show collation', function(err, res) {
3434
charsets[r.Id] = iconvCharset;
3535
});
3636
//console.log(JSON.stringify(missing, 4, null));
37-
console.log(JSON.stringify(charsets, 4, null));
37+
//console.log(JSON.stringify(charsets, 4, null));
38+
for (var i=0; i < charsets.length; i+=8) {
39+
console.log(" '" + charsets.slice(i, i+8).join("', '") + "',");
40+
}
3841
});
3942

4043
conn.end();

0 commit comments

Comments
 (0)