Skip to content

Fix precision bug in parseFloat affecting select(DOUBLE) in prepared statements #1527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix precision bug in parseFloat affecting select(DOUBLE) in prepared statements #1527

wants to merge 3 commits into from

Conversation

wesgarland
Copy link

@wesgarland wesgarland commented Mar 1, 2022 •
edited by sidorares
Loading

This corrects Issue #1525 by falling back to the JS engine's own implementation of parseFloat.

@emma-cw emma-cw mentioned this pull request Sep 4, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wesgarland @wellwelwel