refactor: replace general Exceptions by specific ones

Author: rtaupe

at.siemens.ct.jminizinc.diag.ui/src/main/java/at/siemens/ct/jmz/ui/TextComponentLogger.java

@@ -1,5 +1,5 @@
 /**
- * Copyright Siemens AG, 2016
+ * Copyright Siemens AG, 2016-2017
  * 
  * This Source Code Form is subject to the terms of the Mozilla Public License, v. 2.0.
  * If a copy of the MPL was not distributed with this file, You can obtain one at http://mozilla.org/MPL/2.0/.
@@ -15,8 +15,8 @@
 import java.util.SortedMap;
 import java.util.TreeMap;
 
-import at.siemens.ct.jmz.diag.DiagnosisMetadata;
 import at.siemens.ct.jmz.diag.DiagnoseProgressCallback;
+import at.siemens.ct.jmz.diag.DiagnosisMetadata;
 import at.siemens.ct.jmz.elements.constraints.Constraint;
 
 /**
@@ -148,8 +148,8 @@ public void displayFile(String fileName) {
 	}
 
 	@Override
-	public void displayPartOfDiagnosis(List<Constraint> diagnose, List<Constraint> inputConflictSet, String message,
-			String indent) throws Exception {
+  public void displayPartOfDiagnosis(List<Constraint> diagnose, List<Constraint> inputConflictSet, String message,
+      String indent) {
 		// TODO Auto-generated method stub
 		StringBuilder stringBuilder = new StringBuilder();
 		displayInputSet(inputConflictSet, message);
@@ -203,25 +203,25 @@ public void diagnosisFound(List<Constraint> diagnosis, List<Constraint> inputCon
 
 	}
 
-	private String trimLevel(String message) throws Exception {
+  private String trimLevel(String message) {
 		int paranthesisIndex = 0;
 		if (message != null && !message.isEmpty()) {
 			paranthesisIndex = message.indexOf(")");
 		}
 		if (paranthesisIndex < 0) {
-			throw new Exception(String.format("Message %s do not contains \\')\\' ", message));
+      throw new IllegalArgumentException(String.format("Message %s do not contains \\')\\' ", message));
 		}
 
 		return message.substring(paranthesisIndex + 1, message.length());
 	}
 
-	private String getLevel(String message) throws Exception {
+  private String getLevel(String message) {
 		int paranthesisIndex = 0;
 		if (message != null && !message.isEmpty()) {
 			paranthesisIndex = message.indexOf(")");
 		}
 		if (paranthesisIndex < 0) {
-			throw new Exception(String.format("Message %s do not contains \\')\\' ", message));
+      throw new IllegalArgumentException(String.format("Message %s do not contains \\')\\' ", message));
 		}
 
 		return message.substring(0, paranthesisIndex + 1).trim();

at.siemens.ct.jminizinc.diag.ui/src/main/java/at/siemens/ct/jmz/ui/VariableDialog.java

@@ -22,6 +22,7 @@
 import java.awt.event.WindowAdapter;
 import java.awt.event.WindowEvent;
 import java.io.File;
+import java.io.IOException;
 import java.util.ArrayList;
 import java.util.Collections;
 import java.util.List;
@@ -64,7 +65,7 @@ public class VariableDialog {
 	private final String FAST_DIAG_ALL = "FastDiag - all minimal diagnoses";
 	private final String FAST_DIAG = "FastDiag - first minimal diagnosis";
 
-	public VariableDialog(File mznFile) throws Exception {
+  public VariableDialog(File mznFile) throws IOException {
 		VariableDialog.mznFile = mznFile;
 		mznCp = new MiniZincCP(mznFile);
 		decisionVariables = mznCp.getElementsFromFile();
@@ -92,7 +93,7 @@ public static void main(String[] args) {
 			if (args.length > 0) {
 				mznpath = args[0];
 			} else {
-				FileChooserDialog fcd = new FileChooserDialog();
+        FileChooserDialog fcd = new FileChooserDialog();
 				mznpath = fcd.getFile();
 			}
 
@@ -224,7 +225,7 @@ private void displayDecisionVariables() {
 		controlPanel.add(scrollPane);
 	}
 
-	private List<Constraint> getAllValuesFromTheInterface() throws Exception {
+  private List<Constraint> getAllValuesFromTheInterface() {
 
 		ArrayList<Constraint> userConstraints = new ArrayList<Constraint>();
 

at.siemens.ct.jminizinc.diag.ui/src/test/java/at/siemens/ct/jmz/mznparser/TestMznParser.java

@@ -1,5 +1,5 @@
 /**
- * Copyright Siemens AG, 2016
+ * Copyright Siemens AG, 2016-2017
  * 
  * This Source Code Form is subject to the terms of the Mozilla Public License, v. 2.0.
  * If a copy of the MPL was not distributed with this file, You can obtain one at http://mozilla.org/MPL/2.0/.
@@ -10,6 +10,7 @@
 import static org.junit.Assert.assertTrue;
 
 import java.io.File;
+import java.io.IOException;
 import java.util.regex.Matcher;
 import java.util.regex.Pattern;
 
@@ -24,14 +25,14 @@
 import at.siemens.ct.jmz.expressions.set.RangeExpression;
 
 /**
- * @author Copyright Siemens AG, 2016
+ * @author Copyright Siemens AG, 2016-2017
  */
 public class TestMznParser {
 
 	MiniZincCP constraintProblem;
 
 	@Test
-	public void testMznParser() throws Exception {
+  public void testMznParser() throws IOException {
 		File miniZincFile = new File("src/test/java/testConflictDetection4.mzn");
 		constraintProblem = new MiniZincCP(miniZincFile);
 		int noOfVar = constraintProblem.getElementsFromFile().size();