Skip to content

Commit 1f6473e

Browse files
chintankavathiaspike-rabbit
authored andcommitted
chore: remove provideZonelessChangeDetection
Since zone.js has been removed from the project, provideZonelessChangeDetection is no longer needed. This removes all usages of provideZonelessChangeDetection from the codebase including: - src/app/app.config.ts - All spec files in projects/element-ng - All spec files in projects/charts-ng - All spec files in projects/dashboards-ng - All spec files in projects/element-translate-ng - All spec files in projects/maps-ng
1 parent 642c73d commit 1f6473e

File tree

195 files changed

+303
-1277
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

195 files changed

+303
-1277
lines changed

projects/charts-ng/cartesian/si-chart-cartesian.component.spec.ts

Lines changed: 1 addition & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,7 @@
22
* Copyright (c) Siemens 2016 - 2025
33
* SPDX-License-Identifier: MIT
44
*/
5-
import {
6-
ChangeDetectionStrategy,
7-
Component,
8-
provideZonelessChangeDetection,
9-
SimpleChange,
10-
viewChild
11-
} from '@angular/core';
5+
import { ChangeDetectionStrategy, Component, SimpleChange, viewChild } from '@angular/core';
126
import { TestBed } from '@angular/core/testing';
137
import { ChartXAxis, ChartYAxis, EChartOption } from '@siemens/charts-ng/common';
148

@@ -42,13 +36,6 @@ class TestHostComponent {
4236
subTitle?: string;
4337
}
4438
describe('SiChartBarLineComponent', () => {
45-
beforeEach(() => {
46-
TestBed.configureTestingModule({
47-
imports: [TestHostComponent],
48-
providers: [provideZonelessChangeDetection()]
49-
}).compileComponents();
50-
});
51-
5239
const getOption = (component: SiChartCartesianComponent): any =>
5340
component.chart.getOption() as any;
5441

projects/charts-ng/circle/si-chart-circle.component.spec.ts

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
* Copyright (c) Siemens 2016 - 2025
33
* SPDX-License-Identifier: MIT
44
*/
5-
import { Component, provideZonelessChangeDetection, SimpleChange, viewChild } from '@angular/core';
5+
import { Component, SimpleChange, viewChild } from '@angular/core';
66
import { TestBed } from '@angular/core/testing';
77

88
import { SiChartCircleComponent } from './si-chart-circle.component';
@@ -28,13 +28,6 @@ class TestHostComponent {
2828
subTitle?: string;
2929
}
3030
describe('SiChartCircleComponent', () => {
31-
beforeEach(() => {
32-
TestBed.configureTestingModule({
33-
imports: [TestHostComponent],
34-
providers: [provideZonelessChangeDetection()]
35-
}).compileComponents();
36-
});
37-
3831
const getOption = (component: SiChartCircleComponent): any => component.chart.getOption() as any;
3932

4033
const createChartWithTestData = async (showLegend = false): Promise<any> => {

projects/charts-ng/common/si-chart-base.component.spec.ts

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,7 @@
22
* Copyright (c) Siemens 2016 - 2025
33
* SPDX-License-Identifier: MIT
44
*/
5-
import {
6-
ChangeDetectionStrategy,
7-
Component,
8-
provideZonelessChangeDetection,
9-
viewChild
10-
} from '@angular/core';
5+
import { ChangeDetectionStrategy, Component, viewChild } from '@angular/core';
116
import { ComponentFixture, TestBed } from '@angular/core/testing';
127
import { echarts, EChartOption } from '@siemens/charts-ng/common';
138

@@ -26,13 +21,6 @@ describe('SiChartBase', () => {
2621
let component: TestHostComponent;
2722
let fixture: ComponentFixture<TestHostComponent>;
2823

29-
beforeEach(async () => {
30-
await TestBed.configureTestingModule({
31-
imports: [TestHostComponent],
32-
providers: [provideZonelessChangeDetection()]
33-
}).compileComponents();
34-
});
35-
3624
beforeEach(() => {
3725
fixture = TestBed.createComponent(TestHostComponent);
3826
component = fixture.componentInstance;

projects/charts-ng/custom-legend/si-custom-legend.component.spec.ts

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
* Copyright (c) Siemens 2016 - 2025
33
* SPDX-License-Identifier: MIT
44
*/
5-
import { ChangeDetectionStrategy, Component, provideZonelessChangeDetection } from '@angular/core';
5+
import { ChangeDetectionStrategy, Component } from '@angular/core';
66
import { ComponentFixture, TestBed } from '@angular/core/testing';
77

88
import { SiCustomLegendComponent } from './si-custom-legend.component';
@@ -30,13 +30,6 @@ describe('SiCustomLegendComponent', () => {
3030
let fixture: ComponentFixture<TestHostComponent>;
3131
let element: HTMLElement;
3232

33-
beforeEach(async () => {
34-
await TestBed.configureTestingModule({
35-
imports: [TestHostComponent],
36-
providers: [provideZonelessChangeDetection()]
37-
}).compileComponents();
38-
});
39-
4033
beforeEach(() => {
4134
fixture = TestBed.createComponent(TestHostComponent);
4235
component = fixture.componentInstance;

projects/charts-ng/gauge/si-chart-gauge.component.spec.ts

Lines changed: 1 addition & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,7 @@
22
* Copyright (c) Siemens 2016 - 2025
33
* SPDX-License-Identifier: MIT
44
*/
5-
import {
6-
ChangeDetectionStrategy,
7-
Component,
8-
provideZonelessChangeDetection,
9-
SimpleChange,
10-
viewChild
11-
} from '@angular/core';
5+
import { ChangeDetectionStrategy, Component, SimpleChange, viewChild } from '@angular/core';
126
import { TestBed } from '@angular/core/testing';
137

148
import { SiChartGaugeComponent } from './si-chart-gauge.component';
@@ -35,13 +29,6 @@ class TestHostComponent {
3529
}
3630

3731
describe('SiChartGaugeComponent', () => {
38-
beforeEach(() => {
39-
TestBed.configureTestingModule({
40-
imports: [TestHostComponent],
41-
providers: [provideZonelessChangeDetection()]
42-
}).compileComponents();
43-
});
44-
4532
const getOption = (component: SiChartGaugeComponent): any => component.chart.getOption() as any;
4633

4734
const createChartWithTestData = (): any => {

projects/charts-ng/loading-spinner/si-chart-loading-spinner.component.spec.ts

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
* Copyright (c) Siemens 2016 - 2025
33
* SPDX-License-Identifier: MIT
44
*/
5-
import { provideZonelessChangeDetection } from '@angular/core';
65
import { ComponentFixture, TestBed } from '@angular/core/testing';
76

87
import { SiChartLoadingSpinnerComponent as TestComponent } from './si-chart-loading-spinner.component';
@@ -11,13 +10,6 @@ describe('SiLoadingSpinnerComponent', () => {
1110
let fixture: ComponentFixture<TestComponent>;
1211
let component: TestComponent;
1312

14-
beforeEach(() =>
15-
TestBed.configureTestingModule({
16-
imports: [TestComponent],
17-
providers: [provideZonelessChangeDetection()]
18-
})
19-
);
20-
2113
beforeEach(() => {
2214
fixture = TestBed.createComponent(TestComponent);
2315
component = fixture.componentInstance;

projects/charts-ng/progress-bar/si-chart-progress-bar.component.spec.ts

Lines changed: 1 addition & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,7 @@
22
* Copyright (c) Siemens 2016 - 2025
33
* SPDX-License-Identifier: MIT
44
*/
5-
import {
6-
ChangeDetectionStrategy,
7-
Component,
8-
provideZonelessChangeDetection,
9-
SimpleChange,
10-
viewChild
11-
} from '@angular/core';
5+
import { ChangeDetectionStrategy, Component, SimpleChange, viewChild } from '@angular/core';
126
import { TestBed } from '@angular/core/testing';
137

148
import { SiChartProgressBarComponent } from './si-chart-progress-bar.component';
@@ -35,13 +29,6 @@ class TestHostComponent {
3529
labelPosition?: string;
3630
}
3731
describe('SiChartProgressBarComponent', () => {
38-
beforeEach(() => {
39-
TestBed.configureTestingModule({
40-
imports: [TestHostComponent],
41-
providers: [provideZonelessChangeDetection()]
42-
}).compileComponents();
43-
});
44-
4532
const getOption = (component: TestHostComponent): any =>
4633
component.chartProgressBarComponent().chart.getOption() as any;
4734

projects/charts-ng/progress/si-chart-progress.component.spec.ts

Lines changed: 1 addition & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,7 @@
22
* Copyright (c) Siemens 2016 - 2025
33
* SPDX-License-Identifier: MIT
44
*/
5-
import {
6-
ChangeDetectionStrategy,
7-
Component,
8-
provideZonelessChangeDetection,
9-
SimpleChange,
10-
viewChild
11-
} from '@angular/core';
5+
import { ChangeDetectionStrategy, Component, SimpleChange, viewChild } from '@angular/core';
126
import { TestBed } from '@angular/core/testing';
137

148
import { SiChartProgressComponent } from './si-chart-progress.component';
@@ -33,13 +27,6 @@ class TestHostComponent {
3327
subTitle?: string;
3428
}
3529
describe('SiChartProgressComponent', () => {
36-
beforeEach(() => {
37-
TestBed.configureTestingModule({
38-
imports: [TestHostComponent],
39-
providers: [provideZonelessChangeDetection()]
40-
}).compileComponents();
41-
});
42-
4330
const getOption = (component: TestHostComponent): any =>
4431
component.chartProgressComponent().chart.getOption() as any;
4532

projects/charts-ng/sankey/si-chart-sankey.component.spec.ts

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
* Copyright (c) Siemens 2016 - 2025
33
* SPDX-License-Identifier: MIT
44
*/
5-
import { Component, provideZonelessChangeDetection, SimpleChange, viewChild } from '@angular/core';
5+
import { Component, SimpleChange, viewChild } from '@angular/core';
66
import { TestBed } from '@angular/core/testing';
77
import { SankeySeriesOption } from '@siemens/charts-ng/common';
88

@@ -26,13 +26,6 @@ class TestHostComponent {
2626
subTitle?: string;
2727
}
2828
describe('SiChartSankeyComponent', () => {
29-
beforeEach(() => {
30-
TestBed.configureTestingModule({
31-
imports: [TestHostComponent],
32-
providers: [provideZonelessChangeDetection()]
33-
}).compileComponents();
34-
});
35-
3629
const getOption = (component: SiChartSankeyComponent): any => component.chart.getOption() as any;
3730

3831
const createChartWithTestData = async (): Promise<any> => {

projects/charts-ng/sunburst/si-chart-sunburst.component.spec.ts

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
* Copyright (c) Siemens 2016 - 2025
33
* SPDX-License-Identifier: MIT
44
*/
5-
import { Component, provideZonelessChangeDetection, SimpleChange, viewChild } from '@angular/core';
5+
import { Component, SimpleChange, viewChild } from '@angular/core';
66
import { TestBed } from '@angular/core/testing';
77
import { SunburstSeriesOption } from '@siemens/charts-ng/common';
88

@@ -27,13 +27,6 @@ class TestHostComponent {
2727
}
2828

2929
describe('SiChartSunburstComponent', () => {
30-
beforeEach(async () => {
31-
await TestBed.configureTestingModule({
32-
imports: [TestHostComponent],
33-
providers: [provideZonelessChangeDetection()]
34-
}).compileComponents();
35-
});
36-
3730
const getOption = (component: SiChartSunburstComponent): any =>
3831
component.chart.getOption() as any;
3932

0 commit comments

Comments
 (0)