refactor(filtered-search): drop unnecessary value assignment

BREAKING CHANGE: Empty `value` fields of criterion options
are no longer replaced with the value from the `label`.

Always provide a correct `value`.

Author: akashsonune

projects/element-ng/filtered-search/si-filtered-search.component.spec.ts

@@ -1997,37 +1997,6 @@ describe('SiFilteredSearchComponent', () => {
       });
     });
 
-    // TODO: this is non-sense. Our interface does not allow empty value for options.
-    // TODO: remove with v47
-    it('should emit criterion with value = label from config', async () => {
-      component.doSearchOnInputChange = true;
-      component.criteria.set([
-        { name: 'company', label: 'Company', options: ['Foo', 'Bar'] },
-        { name: 'Location', label: 'Location', options: ['Munich', 'Zug'] },
-        {
-          name: 'country',
-          label: 'Country',
-          options: [{ value: 'DE', label: 'Germany' }, { label: 'Switzerland' } as any]
-        }
-      ]);
-      component.searchCriteria.set({
-        criteria: [{ name: 'country', value: 'Switzerland' }],
-        value: 'Max'
-      });
-      spyOn(component, 'doSearch');
-
-      const filteredSearch = await loader.getHarness(SiFilteredSearchHarness);
-      const freeTextSearch = await filteredSearch.freeTextSearch();
-      await freeTextSearch.focus();
-      await freeTextSearch.sendKeys(':');
-      await tick();
-
-      expect(component.doSearch).toHaveBeenCalledWith({
-        criteria: jasmine.arrayContaining([{ name: 'country', value: 'Switzerland' }]),
-        value: ''
-      });
-    });
-
     it('should work when only value is defined', async () => {
       component.doSearchOnInputChange = true;
       component.criteria.set([

projects/element-ng/filtered-search/values/typeahead/si-filtered-search-typeahead.component.ts

@@ -133,8 +133,7 @@ export class SiFilteredSearchTypeaheadComponent
     // We should consider dropping this, but there is currently a unit test checking this behavior.
     const optionValue = this.optionValue();
     if (optionValue) {
-      // TODO: The last ?? optionValue.label is non-sense, but we have a unit test checking this behavior.
-      this.criterionValue().value = optionValue.value ?? optionValue.label;
+      this.criterionValue().value = optionValue.value;
     }
   }