firmware-update-pacakge: Enhance min_version calculation

Improves the logic for calculating the `min_version` in the firmware
update package generation script.

The new implementation correctly handles various version formats,
including those with multi-digit numbers and zero-padding (e.g.,
`V01.06.12`, `1.6.6`). It replaces any numeric part of the version
string greater than 1 with a 1, while preserving the original padding
and any non-numeric prefixes.

This change makes the version handling more robust and adaptable to
different versioning schemes.

Additionally, the script has been updated to follow shellcheck best
practices, including quoting variables and adding safety checks for
directory changes.

Signed-off-by: Li Hua Qian <huaqian.li@siemens.com>

Author: huaqianli

meta-example/recipes-devtools/firmware-update-package/files/iot2050-generate-fwu-tarball.sh

@@ -1,6 +1,6 @@
 #!/bin/sh
 #
-# Copyright (c) Siemens AG, 2023
+# Copyright (c) Siemens AG, 2023-2026
 #
 # Authors:
 #   Li Hua Qian <huaqian.li@siemens.com>
@@ -9,39 +9,82 @@
 # COPYING.MIT file in the top-level directory.
 #
 
+#
+# Updates the version fields in the provided JSON file.
+#
+# This function takes a JSON file and a version string as input. It updates
+# the "version" and "description" fields to the new version. It also calculates
+# a "min_version" by taking the base version string (before any git hash),
+# and replacing any numeric part greater than 1 with a 1, while preserving
+# any character prefix and zero-padding.
+#
+# For example:
+#   "V01.06.12" -> "V01.01.01"
+#   "2.0.0"     -> "1.0.0"
+#
+# $1: Path to the JSON file to update.
+# $2: The full version string (e.g., "V01.06.12-0-g608da96").
+#
 update_json()
 {
-    version_letter="$(echo $2 | head -c 1)"
-    sed -i '/"version": ".*"/s/"V.*"/"'$2'"/g' $1
-    sed -i '/"description": ".*"/s/V.*["$]/'$2\"'/g' $1
-    sed -i '/"min_version": ".*"/s/"V/"'$version_letter'/g' $1
+    sed -i '/"version": ".*"/s/"[^"]*"/"'"$2"'"/g' "$1"
+    sed -i '/"description": ".*"/s/V.*"/'"$2"'"/g' "$1"
+
+    version_tag=$(echo "$2" | cut -d '-' -f 1)
+
+    new_version=""
+    current_num=""
+    for i in $(seq 1 $((${#version_tag}+1))); do
+        char=$(echo "$version_tag" | cut -c "$i")
+
+        if echo "$char" | grep -q '[0-9]'; then
+            current_num="$current_num$char"
+        else
+            if [ -n "$current_num" ]; then
+                len=${#current_num}
+                num_val=$(echo "$current_num" | sed 's/^0*//')
+                if [ -z "$num_val" ]; then num_val=0; fi
+
+                if [ "$num_val" -gt 1 ]; then
+                    new_version="$new_version$(printf "%0${len}d" 1)"
+                else
+                    new_version="$new_version$current_num"
+                fi
+                current_num=""
+            fi
+            new_version="$new_version$char"
+        fi
+    done
+    min_version=$new_version
+
+    sed -i "/\"min_version\": \".*\"/s/\"[^\"]*\"/\"$min_version\"/g" "$1"
 }
 
 generate_fwu_tarball()
 {
     echo "Generating the firmware tarball..."
 
-    if [ ! -e $2/iot2050-pg1-image-boot.bin ] || \
-       [ ! -e $2/iot2050-pg2-image-boot.bin ]; then
+    if [ ! -e "$2/iot2050-pg1-image-boot.bin" ] || \
+       [ ! -e "$2/iot2050-pg2-image-boot.bin" ]; then
         echo "Error: iot2050-pg1/2-image-boot.bin doesn't exist!"
         exit 2
     fi
 
-    if [ ! -e $2/u-boot-initial-env ]; then
+    if [ ! -e "$2/u-boot-initial-env" ]; then
         echo "Error: u-boot-initial-env doesn't exist!"
         exit 2
     fi
 
-    mkdir -p $2/.tarball
+    mkdir -p "$2/.tarball"
 
-    cp $1/update.conf.json.tmpl $2/.tarball/update.conf.json
-    update_json $2/.tarball/update.conf.json $3
-    cp $2/iot2050-pg*-image-boot.bin $2/.tarball
-    cp $2/u-boot-initial-env $2/.tarball
+    cp "$1/update.conf.json.tmpl" "$2/.tarball/update.conf.json"
+    update_json "$2/.tarball/update.conf.json" "$3"
+    cp "$2"/iot2050-pg*-image-boot.bin "$2/.tarball"
+    cp "$2/u-boot-initial-env" "$2/.tarball"
 
-    cd $2/.tarball
-    tar -cJvf $2/IOT2050-FW-Update-PKG-$3.tar.xz *
-    cd - && rm -rf $2/.tarball
+    cd "$2/.tarball" || exit
+    tar -cJvf "$2/IOT2050-FW-Update-PKG-$3.tar.xz" ./*
+    cd - && rm -rf "$2/.tarball"
 }
 
-generate_fwu_tarball $*
+generate_fwu_tarball "$@"