add test for repo.add_collaborator(user, perm)

Author: kuepe-sl

AUTHORS.rst

@@ -216,3 +216,5 @@ Contributors
 - Philipp Heil (@zkdev)
 
 - Petter Kvalvaag (@pettermk)
+
+- Peter Küffner (@kuepe-sl)

src/github3/repos/repo.py

@@ -126,8 +126,10 @@ def add_collaborator(self, username, permission=None):
         :type username:
             str or :class:`~github3.users.User`
         :param str permission:
-            (optional), permission to grant the collaborator, valid on organization repositories only
-            Can be 'pull', 'triage', 'push', 'maintain', 'admin' or an organization-defined custom role name.
+            (optional), permission to grant the collaborator, valid on
+            organization repositories only.
+            Can be 'pull', 'triage', 'push', 'maintain', 'admin' or an
+            organization-defined custom role name.
         :returns:
             True if successful, False otherwise
         :rtype:

tests/unit/test_repos_repo.py

@@ -81,6 +81,16 @@ def test_add_collaborator(self):
             url_for("collaborators/sigmavirus24")
         )
 
+    def test_add_collaborator_with_permission(self):
+        """Verify the request to add a collaborator to a repository with
+        `admin` permission."""
+        self.instance.add_collaborator("sigmavirus24", "admin")
+
+        self.session.put.assert_called_once_with(
+            url_for("collaborators/sigmavirus24"),
+            data='{"permission": "admin"}'
+        )
+
     def test_add_null_collaborator(self):
         """Verify no request is made when adding `None` as a collaborator."""
         self.instance.add_collaborator(None)