Shorten notification tag

golf1052 · golf1052 · commit a4af91e2c39c · 2017-08-29T23:58:40.000-07:00
diff --git a/Signal-Windows/Signal/IncomingMessages.cs b/Signal-Windows/Signal/IncomingMessages.cs
@@ -437,11 +437,9 @@ private void HandleSignalMessage(SignalServiceEnvelope envelope, SignalServiceCo
 
         private void SendMessageNotification(SignalMessage message)
         {
-            string notificationId = new QueryString()
-            {
-                { "threadId", message.ThreadId },
-                { "recievedTimestamp", message.ReceivedTimestamp.ToString() }
-            }.ToString();
+            // notification tags can only be 16 chars (64 after creators update)
+            // https://docs.microsoft.com/en-us/uwp/api/Windows.UI.Notifications.ToastNotification#Windows_UI_Notifications_ToastNotification_Tag
+            string notificationId = message.ThreadId;
             ToastBindingGeneric toastBinding = new ToastBindingGeneric()
             {
                 AppLogoOverride = new ToastGenericAppLogo()

Original file line number	Diff line number	Diff line change
`@@ -437,11 +437,9 @@ private void HandleSignalMessage(SignalServiceEnvelope envelope, SignalServiceCo`
`437`	`437`
`438`	`438`	`private void SendMessageNotification(SignalMessage message)`
`439`	`439`	`{`
`440`		`- string notificationId = new QueryString()`
`441`		`- {`
`442`		`- { "threadId", message.ThreadId },`
`443`		`- { "recievedTimestamp", message.ReceivedTimestamp.ToString() }`
`444`		`- }.ToString();`
	`440`	`+ // notification tags can only be 16 chars (64 after creators update)`
	`441`	`+ // https://docs.microsoft.com/en-us/uwp/api/Windows.UI.Notifications.ToastNotification#Windows_UI_Notifications_ToastNotification_Tag`
	`442`	`+ string notificationId = message.ThreadId;`
`445`	`443`	`ToastBindingGeneric toastBinding = new ToastBindingGeneric()`
`446`	`444`	`{`
`447`	`445`	`AppLogoOverride = new ToastGenericAppLogo()`