Fix missing all chat folder on startup without new manifest

Author: jamiebuilds-signal

ts/background.ts

@@ -1014,6 +1014,17 @@ export async function startApp(): Promise<void> {
       ) {
         await window.storage.put('needProfileMovedModal', true);
       }
+
+      if (window.isBeforeVersion(lastVersion, 'v7.75.0-beta.1')) {
+        const hasAllChatsChatFolder = await DataReader.hasAllChatsChatFolder();
+        if (!hasAllChatsChatFolder) {
+          log.info('Creating "all chats" chat folder');
+          await DataWriter.createAllChatsChatFolder();
+          StorageService.storageServiceUploadJobAfterEnabled({
+            reason: 'createAllChatsChatFolder',
+          });
+        }
+      }
     }
 
     setAppLoadingScreenMessage(

ts/services/storage.ts

@@ -88,11 +88,7 @@ import { isDone as isRegistrationDone } from '../util/registration.js';
 import { callLinkRefreshJobQueue } from '../jobs/callLinkRefreshJobQueue.js';
 import { isMockEnvironment } from '../environment.js';
 import { validateConversation } from '../util/validateConversation.js';
-import {
-  ChatFolderType,
-  toCurrentChatFolders,
-  type ChatFolder,
-} from '../types/ChatFolder.js';
+import { hasAllChatsChatFolder, type ChatFolder } from '../types/ChatFolder.js';
 
 const { debounce, isNumber, chunk } = lodash;
 
@@ -1663,20 +1659,9 @@ async function processManifest(
       });
     });
 
-    const chatFoldersHasAllChatsFolder = chatFolders.some(chatFolder => {
-      return (
-        chatFolder.folderType === ChatFolderType.ALL &&
-        chatFolder.deletedAtTimestampMs === 0
-      );
-    });
-
-    if (!chatFoldersHasAllChatsFolder) {
+    if (!hasAllChatsChatFolder(chatFolders)) {
       log.info(`process(${version}): creating all chats chat folder`);
-      await DataWriter.createAllChatsChatFolder();
-      const currentChatFolders = await DataReader.getCurrentChatFolders();
-      window.reduxActions.chatFolders.replaceAllChatFolderRecords(
-        toCurrentChatFolders(currentChatFolders)
-      );
+      window.reduxActions.chatFolders.createAllChatsChatFolder();
     }
   }
 
@@ -2235,6 +2220,7 @@ async function upload({
 }
 
 let storageServiceEnabled = false;
+let storageServiceNeedsUploadAfterEnabled = false;
 
 export function enableStorageService(): void {
   if (storageServiceEnabled) {
@@ -2243,6 +2229,12 @@ export function enableStorageService(): void {
 
   storageServiceEnabled = true;
   log.info('enableStorageService');
+
+  if (storageServiceNeedsUploadAfterEnabled) {
+    storageServiceUploadJob({
+      reason: 'storageServiceNeedsUploadAfterEnabled',
+    });
+  }
 }
 
 export function disableStorageService(reason: string): void {
@@ -2351,6 +2343,18 @@ export async function reprocessUnknownFields(): Promise<void> {
   );
 }
 
+export function storageServiceUploadJobAfterEnabled({
+  reason,
+}: {
+  reason: string;
+}): void {
+  if (storageServiceEnabled) {
+    return storageServiceUploadJob({ reason });
+  }
+  log.info(`storageServiceNeedsUploadAfterEnabled: ${reason}`);
+  storageServiceNeedsUploadAfterEnabled = true;
+}
+
 export const storageServiceUploadJob = debounce(
   ({ reason }: { reason: string }) => {
     if (!storageServiceEnabled) {

ts/sql/Interface.ts

@@ -923,6 +923,7 @@ type ReadableInterface = {
   getAllChatFolders: () => ReadonlyArray<ChatFolder>;
   getCurrentChatFolders: () => ReadonlyArray<ChatFolder>;
   getChatFolder: (id: ChatFolderId) => ChatFolder | null;
+  hasAllChatsChatFolder: () => boolean;
   getOldestDeletedChatFolder: () => ChatFolder | null;
 
   getMessagesNeedingUpgrade: (

ts/sql/Server.ts

@@ -240,6 +240,7 @@ import {
   getCurrentChatFolders,
   getChatFolder,
   createChatFolder,
+  hasAllChatsChatFolder,
   createAllChatsChatFolder,
   updateChatFolder,
   markChatFolderDeleted,
@@ -459,6 +460,7 @@ export const DataReader: ServerReadableInterface = {
   getAllChatFolders,
   getCurrentChatFolders,
   getChatFolder,
+  hasAllChatsChatFolder,
   getOldestDeletedChatFolder,
 
   callLinkExists,

ts/sql/server/chatFolders.ts

@@ -146,6 +146,19 @@ export function createChatFolder(db: WritableDB, chatFolder: ChatFolder): void {
   })();
 }
 
+export function hasAllChatsChatFolder(db: ReadableDB): boolean {
+  const [query, params] = sql`
+    SELECT EXISTS (
+      SELECT 1 FROM chatFolders
+      WHERE folderType IS ${ChatFolderType.ALL}
+      AND deletedAtTimestampMs IS 0
+      LIMIT 1
+    )
+  `;
+  const result = db.prepare(query, { pluck: true }).get<number>(params);
+  return result === 1;
+}
+
 export function createAllChatsChatFolder(db: WritableDB): ChatFolder {
   return db.transaction(() => {
     const allChatsChatFolder: ChatFolder = {

ts/state/ducks/chatFolders.ts

@@ -17,7 +17,7 @@ import {
   type CurrentChatFolders,
 } from '../../types/ChatFolder.js';
 import { getCurrentChatFolders } from '../selectors/chatFolders.js';
-import { DataWriter } from '../../sql/Client.js';
+import { DataReader, DataWriter } from '../../sql/Client.js';
 import { storageServiceUploadJob } from '../../services/storage.js';
 import { parseStrict } from '../../util/schemas.js';
 import { chatFolderCleanupService } from '../../services/expiring/chatFolderCleanupService.js';
@@ -142,6 +142,20 @@ function createChatFolder(
   };
 }
 
+function createAllChatsChatFolder(): ThunkAction<
+  void,
+  RootStateType,
+  unknown,
+  ChatFolderRecordReplaceAll
+> {
+  return async dispatch => {
+    await DataWriter.createAllChatsChatFolder();
+    storageServiceUploadJob({ reason: 'createAllChatsChatFolder' });
+    const chatFolders = await DataReader.getCurrentChatFolders();
+    dispatch(replaceAllChatFolderRecords(toCurrentChatFolders(chatFolders)));
+  };
+}
+
 function updateChatFolder(
   chatFolderId: ChatFolderId,
   chatFolderParams: ChatFolderParams
@@ -210,6 +224,7 @@ export const actions = {
   replaceChatFolderRecord,
   removeChatFolderRecord,
   createChatFolder,
+  createAllChatsChatFolder,
   updateChatFolder,
   deleteChatFolder,
   updateChatFoldersPositions,