Remove last use of Buffer in ringrtc API

Co-authored-by: Jim Gustafson <[email protected]>

Author: mutexlox-signal

ACKNOWLEDGMENTS.md

@@ -14517,7 +14517,7 @@ For more information on this, and how to apply and follow the GNU AGPL, see
 
 ```
 
-## libsignal-account-keys 0.1.0, libsignal-core 0.1.0, mrp 2.58.1, protobuf 2.58.1, ringrtc 2.58.1, regex-aot 0.1.0, partial-default-derive 0.1.0
+## libsignal-account-keys 0.1.0, libsignal-core 0.1.0, mrp 2.59.0, protobuf 2.59.0, ringrtc 2.59.0, regex-aot 0.1.0, partial-default-derive 0.1.0
 
 ```
 GNU AFFERO GENERAL PUBLIC LICENSE

package.json

@@ -133,7 +133,7 @@
     "@signalapp/libsignal-client": "0.81.1",
     "@signalapp/minimask": "1.0.1",
     "@signalapp/quill-cjs": "2.1.2",
-    "@signalapp/ringrtc": "2.58.1",
+    "@signalapp/ringrtc": "2.59.0",
     "@signalapp/sqlcipher": "2.4.4",
     "@signalapp/windows-ucv": "1.0.1",
     "@tanstack/react-virtual": "3.11.2",

pnpm-lock.yaml

@@ -307,7 +307,7 @@ export class GumVideoCapturer {
     const reader = new MediaStreamTrackProcessor({
       track,
     }).readable.getReader();
-    const buffer = Buffer.alloc(MAX_VIDEO_CAPTURE_BUFFER_SIZE);
+    const buffer = new Uint8Array(MAX_VIDEO_CAPTURE_BUFFER_SIZE);
     this.spawnedSenderRunning = true;
     // eslint-disable-next-line @typescript-eslint/no-floating-promises
     (async () => {
@@ -397,13 +397,13 @@ export const MAX_VIDEO_CAPTURE_BUFFER_SIZE = MAX_VIDEO_CAPTURE_AREA * 4;
 
 export class CanvasVideoRenderer {
   private canvas?: RefObject<HTMLCanvasElement>;
-  private buffer: Buffer;
+  private buffer: Uint8Array;
   private imageData?: ImageData;
   private source?: VideoFrameSource;
   private rafId?: any;
 
   constructor() {
-    this.buffer = Buffer.alloc(MAX_VIDEO_CAPTURE_BUFFER_SIZE);
+    this.buffer = new Uint8Array(MAX_VIDEO_CAPTURE_BUFFER_SIZE);
   }
 
   setCanvas(canvas: RefObject<HTMLCanvasElement> | undefined): void {

ts/calling/VideoSupport.ts

@@ -12,12 +12,12 @@ import { FRAME_BUFFER_SIZE } from './constants.js';
  * of allocating one per participant. Be careful when using this buffer elsewhere, as it
  * is not cleaned up and may hold stale data.
  */
-export function useGetCallingFrameBuffer(): () => Buffer {
-  const ref = useRef<Buffer | null>(null);
+export function useGetCallingFrameBuffer(): () => Uint8Array {
+  const ref = useRef<Uint8Array | null>(null);
 
   return useCallback(() => {
     if (!ref.current) {
-      ref.current = Buffer.alloc(FRAME_BUFFER_SIZE);
+      ref.current = new Uint8Array(FRAME_BUFFER_SIZE);
     }
     return ref.current;
   }, []);

ts/calling/useGetCallingFrameBuffer.ts

@@ -43,7 +43,7 @@ export default {
 } satisfies Meta<PropsType>;
 
 const defaultProps = {
-  getFrameBuffer: memoize(() => Buffer.alloc(FRAME_BUFFER_SIZE)),
+  getFrameBuffer: memoize(() => new Uint8Array(FRAME_BUFFER_SIZE)),
   getCallingImageDataCache: memoize(() => new Map()),
   getGroupCallVideoFrameSource: fakeGetGroupCallVideoFrameSource,
   imageDataCache: React.createRef<CallingImageDataCache>(),

ts/components/GroupCallOverflowArea.stories.tsx

@@ -17,7 +17,7 @@ const OVERFLOW_SCROLL_BUTTON_RATIO = 0.75;
 export const OVERFLOW_PARTICIPANT_WIDTH = 107;
 
 export type PropsType = {
-  getFrameBuffer: () => Buffer;
+  getFrameBuffer: () => Uint8Array;
   getGroupCallVideoFrameSource: (demuxId: number) => VideoFrameSource;
   i18n: LocalizerType;
   imageDataCache: React.RefObject<CallingImageDataCache>;

ts/components/GroupCallOverflowArea.tsx

@@ -32,7 +32,7 @@ type OverridePropsType = {
     }
 );
 
-const getFrameBuffer = memoize(() => Buffer.alloc(FRAME_BUFFER_SIZE));
+const getFrameBuffer = memoize(() => new Uint8Array(FRAME_BUFFER_SIZE));
 
 const createProps = (
   overrideProps: OverridePropsType,

ts/components/GroupCallRemoteParticipant.stories.tsx

@@ -42,7 +42,7 @@ const DELAY_TO_SHOW_MISSING_MEDIA_KEYS = 5000;
 const CONTAINER_TRANSITION_TIME = 200;
 
 type BasePropsType = {
-  getFrameBuffer: () => Buffer;
+  getFrameBuffer: () => Uint8Array;
   getGroupCallVideoFrameSource: (demuxId: number) => VideoFrameSource;
   i18n: LocalizerType;
   imageDataCache: React.RefObject<CallingImageDataCache>;

ts/components/GroupCallRemoteParticipant.tsx

@@ -32,7 +32,7 @@ class FakeGroupCallVideoFrameSource implements VideoFrameSource {
   }
 
   receiveVideoFrame(
-    destinationBuffer: Buffer,
+    destinationBuffer: Uint8Array,
     _maxWidth: number,
     _maxHeight: number
   ): [number, number] | undefined {