Skip to content

Enable text selection starting from emoji #7489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
david12341235 wants to merge 2 commits into
base: main
Choose a base branch
from
+12 −1
Open

Enable text selection starting from emoji #7489

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a51e17
Add optional userSelect property to FunEmoji and enable in MessageTex…
david12341235 Sep 15, 2025
6337742
Added "user-select: inherit" to .FunInlineEmoji based on PR feedback
david12341235 Sep 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion stylesheets/components/fun/FunEmoji.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,12 @@ $inline-emoji-container-name: inline-emoji;
margin-bottom: round(-0.4em + 1px, 1px);
vertical-align: baseline;
content-visibility: auto;
user-select: none;
// We want to inherit here since most usage of <Emojify> should not be
// selectable, but in cases like messages, conversation titles/descriptions,
// etc we want emoji to be selectable within the surrounding text.
// If the root `.FunInlineEmoji` element isn't selectable, then selection
// can't start on the emoji itself.
user-select: inherit;
}

.FunEmojiSelectionText {
Expand Down
3 changes: 3 additions & 0 deletions ts/components/conversation/Emojify.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ export type Props = {
isInvisible?: boolean;
/** Allows you to customize now non-newlines are rendered. Simplest is just a <span>. */
renderNonEmoji?: RenderTextCallbackType;
selectable?: boolean;
};

const defaultRenderNonEmoji: RenderTextCallbackType = ({ text }) => text;
Expand All @@ -31,6 +32,7 @@ export function Emojify({
fontSizeOverride,
text,
renderNonEmoji = defaultRenderNonEmoji,
selectable = false,
}: Props): JSX.Element {
const emojiLocalizer = useFunEmojiLocalizer();
return (
Expand Down Expand Up @@ -59,6 +61,7 @@ export function Emojify({
aria-label={emojiLocalizer.getLocaleShortName(variantKey)}
emoji={variant}
size={fontSizeOverride}
selectable={selectable}
/>
);
}
Expand Down
1 change: 1 addition & 0 deletions ts/components/conversation/MessageTextRenderer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,6 +431,7 @@ function renderText({
)}
fontSizeOverride={jumboEmojiSize}
text={text}
selectable
/>
);
}
Expand Down
2 changes: 2 additions & 0 deletions ts/components/fun/FunEmoji.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,7 @@ export type FunInlineEmojiProps = FunImageAriaProps &
Readonly<{
size?: number | null;
emoji: EmojiVariantData;
selectable?: boolean;
}>;

export function FunInlineEmoji(props: FunInlineEmojiProps): JSX.Element {
Expand Down Expand Up @@ -183,6 +184,7 @@ export function FunInlineEmoji(props: FunInlineEmojiProps): JSX.Element {
'--fun-emoji-sheet-x': props.emoji.sheetX,
'--fun-emoji-sheet-y': props.emoji.sheetY,
'--fun-emoji-jumbo-image': jumboImage,
...(props.selectable && { userSelect: 'text' }),
} as CSSProperties
}
/>
Expand Down