From 28dd439196c02344a438e7655b2486f6b6a792d5 Mon Sep 17 00:00:00 2001 From: SonyaKapoor Date: Wed, 22 Oct 2025 21:35:48 -0500 Subject: [PATCH 1/5] first draft --- CONTRIBUTING.md | 33 +++++++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index e2798bff7b..bf9e7275d2 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -115,6 +115,39 @@ $ ./node_modules/.bin/electron-builder install-app-deps Node.js v20.11.1 ``` +##### verifying via reCAPTCHA doesn't work if both Signal and Signal Beta clients installed when setting up as standalone + +###### Steps to reproduce +1. Get told to verify by captcha +2. Complete captcha in Google Chrome +3. Xdg-open dialog prompt to open the link in another program (wasn't given a choice of which program to open in) + +###### Steps to solve the issue +1. Enter phone number and click "Send SMS", (opens the captcha link in your browser) +2. Verify using the captcha +3. Once it is verified in the browser, you will get the "xdg-open" or "Open Signal" dialog prompt +4. Ignore the prompt +5. Right click on the "Open Signal" hyperlink below the verification box and copy the link address. I got something with the format of `signalcaptcha://signal-hcaptcha.Foo-bAr_baz.challenge.fOo-bAR_baZ.fOO-BaR_baz...` +6. In a terminal window type `pnpm start` space and then paste the link address from the previous step, ie. +`yarn start signalcaptcha://signal-hcaptcha.Foo-bAr_baz.challenge.fOo-bAR_baZ.fOO-BaR_baz...` +7. This command will open the `signalcaptcha://...` url with the currently running development version of the app +8. execute the command, it will say something like +```making app single instance +quitting; we are the second instance +Done in 0.67s. +``` +9. You can now go back to the original terminal session where you first ran yarn start, you should see something like +``` +{"level":30,"time":"2024-01-28T08:07:14.558Z","msg":"challengeMain.onRequest(standalone registration): received challenge request, waiting for response"} +{"level":30,"time":"2024-01-28T08:07:40.974Z","msg":"handleSignalRoute: Matched signal route: captcha"} +{"level":30,"time":"2024-01-28T08:07:40.974Z","msg":"challengeMain.handleCaptcha: sending captcha response to 1 handlers"} +{"level":30,"time":"2024-01-28T08:07:40.975Z","msg":"challengeMain.onRequest(standalone registration): got response after 26415ms"} +``` + +This means that the development app has now accepted the Captcha challenge +You should now get an SMS to the phone number you entered earlier with the verification code. Enter the code and click "Register" and you will now be registered as a standalone device as desired. + + ### webpack Some parts of the app (such as the Sticker Creator) have moved to webpack. From 6f700c41a4fef812137018c39b8f5f48572feb84 Mon Sep 17 00:00:00 2001 From: SonyaKapoor Date: Wed, 22 Oct 2025 22:00:58 -0500 Subject: [PATCH 2/5] fixing linting error --- CONTRIBUTING.md | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index bf9e7275d2..7942dd0afe 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -118,25 +118,30 @@ $ ./node_modules/.bin/electron-builder install-app-deps ##### verifying via reCAPTCHA doesn't work if both Signal and Signal Beta clients installed when setting up as standalone ###### Steps to reproduce + 1. Get told to verify by captcha 2. Complete captcha in Google Chrome 3. Xdg-open dialog prompt to open the link in another program (wasn't given a choice of which program to open in) ###### Steps to solve the issue + 1. Enter phone number and click "Send SMS", (opens the captcha link in your browser) 2. Verify using the captcha 3. Once it is verified in the browser, you will get the "xdg-open" or "Open Signal" dialog prompt 4. Ignore the prompt 5. Right click on the "Open Signal" hyperlink below the verification box and copy the link address. I got something with the format of `signalcaptcha://signal-hcaptcha.Foo-bAr_baz.challenge.fOo-bAR_baZ.fOO-BaR_baz...` 6. In a terminal window type `pnpm start` space and then paste the link address from the previous step, ie. -`yarn start signalcaptcha://signal-hcaptcha.Foo-bAr_baz.challenge.fOo-bAR_baZ.fOO-BaR_baz...` + `yarn start signalcaptcha://signal-hcaptcha.Foo-bAr_baz.challenge.fOo-bAR_baZ.fOO-BaR_baz...` 7. This command will open the `signalcaptcha://...` url with the currently running development version of the app 8. execute the command, it will say something like + ```making app single instance quitting; we are the second instance Done in 0.67s. ``` + 9. You can now go back to the original terminal session where you first ran yarn start, you should see something like + ``` {"level":30,"time":"2024-01-28T08:07:14.558Z","msg":"challengeMain.onRequest(standalone registration): received challenge request, waiting for response"} {"level":30,"time":"2024-01-28T08:07:40.974Z","msg":"handleSignalRoute: Matched signal route: captcha"} @@ -147,7 +152,6 @@ Done in 0.67s. This means that the development app has now accepted the Captcha challenge You should now get an SMS to the phone number you entered earlier with the verification code. Enter the code and click "Register" and you will now be registered as a standalone device as desired. - ### webpack Some parts of the app (such as the Sticker Creator) have moved to webpack. From 8ebf490d6ab20403b5503a912665d92341798771 Mon Sep 17 00:00:00 2001 From: SonyaKapoor Date: Sat, 25 Oct 2025 20:10:24 -0500 Subject: [PATCH 3/5] copy updates --- CONTRIBUTING.md | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 7942dd0afe..5810d5ba42 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -76,9 +76,9 @@ pnpm run dev:transpile # recompiles when you change .ts files pnpm run dev:styles # recompiles when you change .scss files ``` -#### Known issues +## Known issues -##### `yarn install` prints error 'Could not detect abi for version 30.0.6 and runtime electron' +### 1. `yarn install` prints error 'Could not detect abi for version 30.0.6 and runtime electron' `yarn install` may print an error like the following, but it can be ignored because the overall operation succeeds. @@ -115,25 +115,25 @@ $ ./node_modules/.bin/electron-builder install-app-deps Node.js v20.11.1 ``` -##### verifying via reCAPTCHA doesn't work if both Signal and Signal Beta clients installed when setting up as standalone +### 2. Verifying via reCAPTCHA doesn't work if both Signal and Signal Beta clients installed when setting up as standalone -###### Steps to reproduce +#### Steps to reproduce 1. Get told to verify by captcha 2. Complete captcha in Google Chrome -3. Xdg-open dialog prompt to open the link in another program (wasn't given a choice of which program to open in) +3. Dialog prompt will tell you to click to open in Signal app, but captcha doesn't complete properly -###### Steps to solve the issue +#### Steps to solve the issue 1. Enter phone number and click "Send SMS", (opens the captcha link in your browser) 2. Verify using the captcha 3. Once it is verified in the browser, you will get the "xdg-open" or "Open Signal" dialog prompt 4. Ignore the prompt -5. Right click on the "Open Signal" hyperlink below the verification box and copy the link address. I got something with the format of `signalcaptcha://signal-hcaptcha.Foo-bAr_baz.challenge.fOo-bAR_baZ.fOO-BaR_baz...` +5. Right click on the "Open Signal" hyperlink below the verification box and copy the link address. You should see something with the format with the format of `signalcaptcha://signal-hcaptcha.Foo-bAr_baz.challenge.fOo-bAR_baZ.fOO-BaR_baz...` 6. In a terminal window type `pnpm start` space and then paste the link address from the previous step, ie. `yarn start signalcaptcha://signal-hcaptcha.Foo-bAr_baz.challenge.fOo-bAR_baZ.fOO-BaR_baz...` 7. This command will open the `signalcaptcha://...` url with the currently running development version of the app -8. execute the command, it will say something like +8. Execute the command, it will say something like ```making app single instance quitting; we are the second instance From 5a44e4c6429ca8f2bd7fcb2cadd1c4e65229a6c2 Mon Sep 17 00:00:00 2001 From: Sonya Kapoor Date: Fri, 31 Oct 2025 13:21:49 -0500 Subject: [PATCH 4/5] Update CONTRIBUTING.md Co-authored-by: Scott Nonnenberg --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 5810d5ba42..5a1772cdab 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -149,7 +149,7 @@ Done in 0.67s. {"level":30,"time":"2024-01-28T08:07:40.975Z","msg":"challengeMain.onRequest(standalone registration): got response after 26415ms"} ``` -This means that the development app has now accepted the Captcha challenge +This means that the development app has now accepted the Captcha challenge. You should now get an SMS to the phone number you entered earlier with the verification code. Enter the code and click "Register" and you will now be registered as a standalone device as desired. ### webpack From 30359613c72774d2097c95f96fd3a5b31ea966cd Mon Sep 17 00:00:00 2001 From: Sonya Kapoor Date: Fri, 31 Oct 2025 13:23:16 -0500 Subject: [PATCH 5/5] Update yarn to pnpm --- CONTRIBUTING.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 5a1772cdab..a01a684f0a 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -78,9 +78,9 @@ pnpm run dev:styles # recompiles when you change .scss files ## Known issues -### 1. `yarn install` prints error 'Could not detect abi for version 30.0.6 and runtime electron' +### 1. `pnpm install` prints error 'Could not detect abi for version 30.0.6 and runtime electron' -`yarn install` may print an error like the following, but it can be ignored because the overall operation succeeds. +`pnpm install` may print an error like the following, but it can be ignored because the overall operation succeeds. ``` $ ./node_modules/.bin/electron-builder install-app-deps @@ -131,7 +131,7 @@ $ ./node_modules/.bin/electron-builder install-app-deps 4. Ignore the prompt 5. Right click on the "Open Signal" hyperlink below the verification box and copy the link address. You should see something with the format with the format of `signalcaptcha://signal-hcaptcha.Foo-bAr_baz.challenge.fOo-bAR_baZ.fOO-BaR_baz...` 6. In a terminal window type `pnpm start` space and then paste the link address from the previous step, ie. - `yarn start signalcaptcha://signal-hcaptcha.Foo-bAr_baz.challenge.fOo-bAR_baZ.fOO-BaR_baz...` + `pnpm start signalcaptcha://signal-hcaptcha.Foo-bAr_baz.challenge.fOo-bAR_baZ.fOO-BaR_baz...` 7. This command will open the `signalcaptcha://...` url with the currently running development version of the app 8. Execute the command, it will say something like @@ -140,7 +140,7 @@ quitting; we are the second instance Done in 0.67s. ``` -9. You can now go back to the original terminal session where you first ran yarn start, you should see something like +9. You can now go back to the original terminal session where you first ran pnpm start, you should see something like ``` {"level":30,"time":"2024-01-28T08:07:14.558Z","msg":"challengeMain.onRequest(standalone registration): received challenge request, waiting for response"}