Localize outgoing restore prompts

Author: pete-signal

Signal/DeviceTransfer/OutgoingDeviceRestorePresenter.swift

@@ -56,9 +56,14 @@ class OutgoingDeviceRestorePresenter: OutgoingDeviceRestoreInitialPresenter {
     private func presentSheet() {
         let sheet = HeroSheetViewController(
             hero: .image(UIImage(named: "other-device")!),
-            // TODO: [Backups] - Localize
-            title: LocalizationNotNeeded("Continue on your other device"),
-            body: LocalizationNotNeeded("Continue transferring your account on your other device."),
+            title: OWSLocalizedString(
+                "OUTGOING_DEVICE_RESTORE_CONTINUE_ON_OTHER_DEVICE_TITLE",
+                comment: "Title of prompt notifying that action is necessary on the other device."
+            ),
+            body: OWSLocalizedString(
+                "OUTGOING_DEVICE_RESTORE_CONTINUE_ON_OTHER_DEVICE_BODY",
+                comment: "Body of prompt notifying that action is necessary on the other device."
+            ),
             primary: .hero(.animation(named: "circular_indeterminate", height: 60))
         )
         sheet.modalPresentationStyle = .formSheet
@@ -82,10 +87,15 @@ class OutgoingDeviceRestorePresenter: OutgoingDeviceRestoreInitialPresenter {
     private func displayTransferComplete(presentingViewController: UIViewController) async {
         let sheet = HeroSheetViewController(
             hero: .image(UIImage(resource: .checkCircle)),
-            // TODO: [Backups] - Localize
-            title: LocalizationNotNeeded("Transfer complete"),
-            body: LocalizationNotNeeded("Your Signal account and messages have been transferred to your other device. Signal is now inactive on this device."),
-            primaryButton: .dismissing(title: "Okay")
+            title: OWSLocalizedString(
+                "OUTGOING_DEVICE_TRANSFER_COMPLETE_TITLE",
+                comment: "Title of prompt notifying device transfer completed."
+            ),
+            body: OWSLocalizedString(
+                "OUTGOING_DEVICE_TRANSFER_COMPLETE_BODY",
+                comment: "Body of prompt notifying device transfer completed."
+            ),
+            primaryButton: .dismissing(title: CommonStrings.okayButton)
         )
         sheet.modalPresentationStyle = .formSheet
         await presentingViewController.awaitablePresent(sheet, animated: true)
@@ -94,16 +104,27 @@ class OutgoingDeviceRestorePresenter: OutgoingDeviceRestoreInitialPresenter {
     @MainActor
     private func displayRestoreMessage(isBackup: Bool, presentingViewController: UIViewController) async {
 
-        // TODO: [Backups] - Localize
         let (title, body) = if isBackup {
             (
-                LocalizationNotNeeded("Restore complete"),
-                LocalizationNotNeeded("Your Signal account and messages have started transferring to your other device. Signal is now inactive on this device.")
+                OWSLocalizedString(
+                    "OUTGOING_DEVICE_RESTORE_COMPLETE_TITLE",
+                    comment: "Title of prompt notifying device restore started on the new device."
+                ),
+                OWSLocalizedString(
+                    "OUTGOING_DEVICE_RESTORE_COMPLETE_BODY",
+                    comment: "Body of prompt notifying device restore started on the new device."
+                )
             )
         } else {
             (
-                LocalizationNotNeeded("Registration complete"),
-                LocalizationNotNeeded("Your Signal account has been activated on your other device. Signal is now inactive on this device.")
+                OWSLocalizedString(
+                    "OUTGOING_DEVICE_REGISTRATION_COMPLETE_TITLE",
+                    comment: "Title of prompt notifying registration without restore completed on the new device."
+                ),
+                OWSLocalizedString(
+                    "OUTGOING_DEVICE_REGISTRATION_COMPLETE_BODY",
+                    comment: "Body of prompt notifying registration without restore completed on the new device."
+                )
             )
         }
 

Signal/Registration/UserInterface/RegistrationTransferStatusViewController.swift

@@ -47,7 +47,6 @@ class RegistrationTransferStatusViewController: HostingController<TransferStatus
                 primaryButton: .init(
                     title: CommonStrings.okayButton
                 ) { _ in
-                    // TODO: [Backups] - This should be handled through the presenter
                     Task {
                         SSKEnvironment.shared.notificationPresenterRef.notifyUserToRelaunchAfterTransfer {
                             Logger.info("Deliberately terminating app post-transfer.")

Signal/translations/en.lproj/Localizable.strings

@@ -5581,6 +5581,24 @@
 /* Label warning the user that they should update Signal to continue using payments. */
 "OUTDATED_PAYMENT_CLIENT_REMINDER_TEXT" = "Update Signal to continue using payments. Your balance may not be up-to-date.";
 
+/* Body of prompt notifying registration without restore completed on the new device. */
+"OUTGOING_DEVICE_REGISTRATION_COMPLETE_BODY" = "Your Signal account has been activated on your other device. Signal is now inactive on this device.";
+
+/* Title of prompt notifying registration without restore completed on the new device. */
+"OUTGOING_DEVICE_REGISTRATION_COMPLETE_TITLE" = "Registration complete";
+
+/* Body of prompt notifying device restore started on the new device. */
+"OUTGOING_DEVICE_RESTORE_COMPLETE_BODY" = "Your Signal account and messages have started transferring to your other device. Signal is now inactive on this device.";
+
+/* Title of prompt notifying device restore started on the new device. */
+"OUTGOING_DEVICE_RESTORE_COMPLETE_TITLE" = "Restore complete";
+
+/* Body of prompt notifying that action is necessary on the other device. */
+"OUTGOING_DEVICE_RESTORE_CONTINUE_ON_OTHER_DEVICE_BODY" = "Continue transferring your account on your other device.";
+
+/* Title of prompt notifying that action is necessary on the other device. */
+"OUTGOING_DEVICE_RESTORE_CONTINUE_ON_OTHER_DEVICE_TITLE" = "Continue on your other device";
+
 /* Body text describing the outgoing transfer. */
 "OUTGOING_DEVICE_RESTORE_INITIAL_VIEW_BODY" = "Your account will be transferred to a new device. This device will be able to see your groups and contacts, access your chats, and send messages in your name.";
 
@@ -5593,6 +5611,12 @@
 /* Title text describing the outgoing transfer. */
 "OUTGOING_DEVICE_RESTORE_INITIAL_VIEW_TITLE" = "Transfer Account";
 
+/* Body of prompt notifying device transfer completed. */
+"OUTGOING_DEVICE_TRANSFER_COMPLETE_BODY" = "Your Signal account and messages have been transferred to your other device. Signal is now inactive on this device.";
+
+/* Title of prompt notifying device transfer completed. */
+"OUTGOING_DEVICE_TRANSFER_COMPLETE_TITLE" = "Transfer complete";
+
 /* info message text in conversation view */
 "OUTGOING_MISSED_VIDEO_CALL" = "Unanswered video call";