Put AvatarHistoryManager.cleanupOrphanedImages off main thread

sashaweiss-signal · web-flow · commit 8753035db653 · 2025-05-14T17:49:39.000-05:00
diff --git a/Signal/AppLaunch/AppEnvironment.swift b/Signal/AppLaunch/AppEnvironment.swift
@@ -179,7 +179,7 @@ public class AppEnvironment: NSObject {
             }
 
             Task {
-                self.avatarHistoryManager.cleanupOrphanedImages()
+                await self.avatarHistoryManager.cleanupOrphanedImages()
             }
 
             Task {
diff --git a/Signal/Avatars/AvatarHistoryManager.swift b/Signal/Avatars/AvatarHistoryManager.swift
@@ -42,9 +42,7 @@ class AvatarHistoryManager {
         )
     }
 
-    func cleanupOrphanedImages() {
-        owsAssertDebug(!Thread.isMainThread)
-
+    func cleanupOrphanedImages() async {
         guard OWSFileSystem.fileOrFolderExists(url: imageHistoryDirectory) else { return }
 
         let allRecords: [[AvatarRecord]] = db.read { tx in

Original file line number	Diff line number	Diff line change
`@@ -179,7 +179,7 @@ public class AppEnvironment: NSObject {`
`179`	`179`	`}`
`180`	`180`
`181`	`181`	`Task {`
`182`		`- self.avatarHistoryManager.cleanupOrphanedImages()`
	`182`	`+ await self.avatarHistoryManager.cleanupOrphanedImages()`
`183`	`183`	`}`
`184`	`184`
`185`	`185`	`Task {`
Original file line number	Diff line number	Diff line change
`@@ -42,9 +42,7 @@ class AvatarHistoryManager {`
`42`	`42`	`)`
`43`	`43`	`}`
`44`	`44`
`45`		`- func cleanupOrphanedImages() {`
`46`		`- owsAssertDebug(!Thread.isMainThread)`
`47`		`-`
	`45`	`+ func cleanupOrphanedImages() async {`
`48`	`46`	`guard OWSFileSystem.fileOrFolderExists(url: imageHistoryDirectory) else { return }`
`49`	`47`
`50`	`48`	`let allRecords: [[AvatarRecord]] = db.read { tx in`