Skip to content

Commit bbf12c4

Browse files
authored
Update megaphone backup criteria
1 parent 3fe6f9d commit bbf12c4

File tree

2 files changed

+2
-10
lines changed

2 files changed

+2
-10
lines changed

SignalServiceKit/Megaphones/ExperienceUpgradeManifest.swift

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -458,7 +458,7 @@ extension ExperienceUpgradeManifest {
458458
case .backupKeyReminder:
459459
return 8 * .hour
460460
case .enableBackupsReminder:
461-
return 8 * .hour
461+
return 7 * .day
462462
case .unrecognized:
463463
return .infinity
464464
}
@@ -688,8 +688,7 @@ extension ExperienceUpgradeManifest {
688688
break
689689
}
690690

691-
// if user has sent/received 1000 messages
692-
return InteractionFinder.outgoingAndIncomingMessageCount(transaction: transaction, limit: 1000) >= 1000
691+
return InteractionFinder.outgoingAndIncomingMessageCount(transaction: transaction, limit: 1) >= 1
693692
}
694693

695694
// MARK: Remote megaphone preconditions

SignalServiceKit/tests/MessageBackup/BackupEnablementReminderMegaphoneTests.swift

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -47,13 +47,6 @@ class BackupEnablementReminderMegaphoneTests: XCTestCase {
4747
backupSettingsStore.setBackupPlan(.disabled, tx: tx)
4848
}
4949

50-
let outgoingMessage = TSOutgoingMessage(in: contactThread!, messageBody: "good heavens")
51-
db.write { transaction in
52-
let db = transaction.database
53-
try! contactThread!.asRecord().insert(db)
54-
try! outgoingMessage.asRecord().insert(db)
55-
}
56-
5750
db.read { transaction in
5851
XCTAssertFalse(ExperienceUpgradeManifest.checkPreconditionsForBackupEnablementReminder(transaction: transaction), "Don't show reminder if user doesn't have enough messages")
5952
}

0 commit comments

Comments
 (0)