Add dedicated "low power mode" paused case for Backup upload/download

sashaweiss-signal · web-flow · commit f08f0868c2f6 · 2025-09-03T11:38:40.000-07:00
diff --git a/Signal/Backups/BackupSettingsAttachmentDownloadTracker.swift b/Signal/Backups/BackupSettingsAttachmentDownloadTracker.swift
@@ -11,6 +11,7 @@ final class BackupSettingsAttachmentDownloadTracker {
             case suspended
             case running
             case pausedLowBattery
+            case pausedLowPowerMode
             case pausedNeedsWifi
             case pausedNeedsInternet
             case outOfDiskSpace(bytesRequired: UInt64)
@@ -205,6 +206,8 @@ private class Tracker {
                 return .pausedNeedsInternet
             case .lowBattery:
                 return .pausedLowBattery
+            case .lowPowerMode:
+                return .pausedLowPowerMode
             case .lowDiskSpace:
                 return .outOfDiskSpace(bytesRequired: max(
                     lastReportedDownloadProgress.remainingUnitCount,
diff --git a/Signal/Backups/BackupSettingsAttachmentUploadTracker.swift b/Signal/Backups/BackupSettingsAttachmentUploadTracker.swift
@@ -11,6 +11,7 @@ final class BackupSettingsAttachmentUploadTracker {
         enum State {
             case running
             case pausedLowBattery
+            case pausedLowPowerMode
             case pausedNeedsWifi
             case pausedNeedsInternet
         }
@@ -186,7 +187,7 @@ private class Tracker {
 
                 _state.uploadProgressObserver = nil
 
-            case .noWifiReachability, .lowBattery, .noReachability:
+            case .noWifiReachability, .lowBattery, .lowPowerMode, .noReachability:
                 break
             }
 
@@ -221,6 +222,8 @@ private class Tracker {
                 return .pausedNeedsWifi
             case .lowBattery:
                 return .pausedLowBattery
+            case .lowPowerMode:
+                return .pausedLowPowerMode
             case .empty, .notRegisteredAndReady, .appBackgrounded:
                 return nil
             }
diff --git a/Signal/Backups/BackupSettingsViewController.swift b/Signal/Backups/BackupSettingsViewController.swift
@@ -522,7 +522,7 @@ class BackupSettingsViewController:
         switch currentDownloadQueueStatus {
         case .empty, .suspended, .notRegisteredAndReady, .appBackgrounded:
             break
-        case .running, .noWifiReachability, .noReachability, .lowBattery, .lowDiskSpace:
+        case .running, .noWifiReachability, .noReachability, .lowBattery, .lowPowerMode, .lowDiskSpace:
             OWSActionSheets.showActionSheet(
                 title: OWSLocalizedString(
                     "BACKUP_SETTINGS_DISABLING_DOWNLOADS_STARTED_ACTION_SHEET_TITLE",
@@ -1261,7 +1261,7 @@ struct BackupSettingsView: View {
             switch latestDownloadUpdate?.state {
             case nil, .suspended:
                 return .disabling
-            case .running, .pausedLowBattery, .pausedNeedsWifi, .pausedNeedsInternet, .outOfDiskSpace:
+            case .running, .pausedLowBattery, .pausedLowPowerMode, .pausedNeedsWifi, .pausedNeedsInternet, .outOfDiskSpace:
                 return .disablingDownloadsRunning(latestDownloadUpdate!)
             }
         }
@@ -1621,7 +1621,7 @@ private struct BackupAttachmentDownloadProgressView: View {
             let progressViewColor: Color? = switch latestDownloadUpdate.state {
             case .suspended:
                 nil
-            case .running, .pausedLowBattery, .pausedNeedsWifi, .pausedNeedsInternet:
+            case .running, .pausedLowBattery, .pausedLowPowerMode, .pausedNeedsWifi, .pausedNeedsInternet:
                 .Signal.accent
             case .outOfDiskSpace:
                 .yellow
@@ -1662,6 +1662,11 @@ private struct BackupAttachmentDownloadProgressView: View {
                     "BACKUP_SETTINGS_DOWNLOAD_PROGRESS_SUBTITLE_PAUSED_LOW_BATTERY",
                     comment: "Subtitle for a progress bar tracking downloads that are paused because of low battery."
                 )
+            case .pausedLowPowerMode:
+                OWSLocalizedString(
+                    "BACKUP_SETTINGS_DOWNLOAD_PROGRESS_SUBTITLE_PAUSED_LOW_POWER_MODE",
+                    comment: "Subtitle for a progress bar tracking downloads that are paused because of low power mode."
+                )
             case .pausedNeedsWifi:
                 OWSLocalizedString(
                     "BACKUP_SETTINGS_DOWNLOAD_PROGRESS_SUBTITLE_PAUSED_NEEDS_WIFI",
@@ -1742,7 +1747,7 @@ private struct BackupAttachmentDownloadProgressView: View {
                 }
             }
             .foregroundStyle(Color.Signal.label)
-        case .pausedLowBattery, .pausedNeedsInternet:
+        case .pausedLowBattery, .pausedLowPowerMode, .pausedNeedsInternet:
             EmptyView()
         }
     }
@@ -1787,6 +1792,11 @@ private struct BackupAttachmentUploadProgressView: View {
                 "BACKUP_SETTINGS_UPLOAD_PROGRESS_SUBTITLE_PAUSED_LOW_BATTERY",
                 comment: "Subtitle for a progress bar tracking uploads that are paused because of low battery."
             )
+        case .pausedLowPowerMode:
+            OWSLocalizedString(
+                "BACKUP_SETTINGS_UPLOAD_PROGRESS_SUBTITLE_PAUSED_LOW_POWER_MODE",
+                comment: "Subtitle for a progress bar tracking uploads that are paused because of low power mode."
+            )
         case .pausedNeedsWifi:
             OWSLocalizedString(
                 "BACKUP_SETTINGS_UPLOAD_PROGRESS_SUBTITLE_PAUSED_NEEDS_WIFI",
@@ -2291,7 +2301,7 @@ extension OWSSequentialProgress<BackupExportJobStep> {
     ))
 }
 
-#Preview("Manual Backup: Media Upload Paused (Battery)") {
+#Preview("Manual Backup: Media Upload Paused (Low Battery)") {
     BackupSettingsView(viewModel: .forPreview(
         backupPlan: .free,
         latestBackupExportProgressUpdate: .forPreview(.attachmentUpload, 0.80),
@@ -2300,6 +2310,15 @@ extension OWSSequentialProgress<BackupExportJobStep> {
     ))
 }
 
+#Preview("Manual Backup: Media Upload Paused (Low Power Mode)") {
+    BackupSettingsView(viewModel: .forPreview(
+        backupPlan: .free,
+        latestBackupExportProgressUpdate: .forPreview(.attachmentUpload, 0.80),
+        latestBackupAttachmentUploadUpdateState: .pausedLowPowerMode,
+        backupSubscriptionLoadingState: .loaded(.paidButFreeForTesters)
+    ))
+}
+
 #Preview("Manual Backup: Media Upload Paused (WiFi)") {
     BackupSettingsView(viewModel: .forPreview(
         backupPlan: .free,
@@ -2345,14 +2364,22 @@ extension OWSSequentialProgress<BackupExportJobStep> {
     ))
 }
 
-#Preview("Downloads: Paused (Battery)") {
+#Preview("Downloads: Paused (Low Battery)") {
     BackupSettingsView(viewModel: .forPreview(
         backupPlan: .free,
         latestBackupAttachmentDownloadUpdateState: .pausedLowBattery,
         backupSubscriptionLoadingState: .loaded(.free)
     ))
 }
 
+#Preview("Downloads: Paused (Low Power Mode)") {
+    BackupSettingsView(viewModel: .forPreview(
+        backupPlan: .free,
+        latestBackupAttachmentDownloadUpdateState: .pausedLowPowerMode,
+        backupSubscriptionLoadingState: .loaded(.free)
+    ))
+}
+
 #Preview("Downloads: Paused (WiFi)") {
     BackupSettingsView(viewModel: .forPreview(
         backupPlan: .free,
diff --git a/Signal/src/ViewControllers/HomeView/Chat List/ChatListViewController+BackupDownloadProgressView.swift b/Signal/src/ViewControllers/HomeView/Chat List/ChatListViewController+BackupDownloadProgressView.swift
@@ -187,6 +187,8 @@ public class CLVBackupDownloadProgressView {
             return nil
         case .lowBattery:
             return .paused(reason: .lowBattery)
+        case .lowPowerMode:
+            return .paused(reason: .lowPowerMode)
         case .lowDiskSpace:
             let minRequiredDiskSpace = backupAttachmentDownloadQueueStatusReporter
                 .minimumRequiredDiskSpaceToCompleteDownloads()
@@ -227,6 +229,7 @@ private class BackupAttachmentDownloadProgressView: UIView {
         public enum PauseReason {
             case notReachable
             case lowBattery
+            case lowPowerMode
         }
     }
 
@@ -248,11 +251,11 @@ private class BackupAttachmentDownloadProgressView: UIView {
         fatalError("init(frame:) has not been implemented")
     }
 
-    private let backupAttachmentDownloadManager: BackupAttachmentDownloadManager
-    private let backupAttachmentDownloadQueueStatusReporter: BackupAttachmentDownloadQueueStatusReporter
-    private let backupAttachmentDownloadStore: BackupAttachmentDownloadStore
-    private let backupSettingsStore: BackupSettingsStore
-    private let db: DB
+    private let backupAttachmentDownloadManager: BackupAttachmentDownloadManager!
+    private let backupAttachmentDownloadQueueStatusReporter: BackupAttachmentDownloadQueueStatusReporter!
+    private let backupAttachmentDownloadStore: BackupAttachmentDownloadStore!
+    private let backupSettingsStore: BackupSettingsStore!
+    private let db: DB!
 
     init(
         backupAttachmentDownloadManager: BackupAttachmentDownloadManager,
@@ -278,6 +281,20 @@ private class BackupAttachmentDownloadProgressView: UIView {
         initialRender()
     }
 
+    fileprivate init(forPreview: (), state: State) {
+        self.backupAttachmentDownloadManager = nil
+        self.backupAttachmentDownloadQueueStatusReporter = nil
+        self.backupAttachmentDownloadStore = nil
+        self.backupSettingsStore = nil
+        self.db = nil
+
+        self.state = state
+
+        super.init(frame: .zero)
+
+        initialRender()
+    }
+
     // MARK: - Rendering
 
     private lazy var backgroundView: UIView = {
@@ -707,6 +724,11 @@ private class BackupAttachmentDownloadProgressView: UIView {
                     "RESTORING_MEDIA_BANNER_PAUSED_BATTERY_SUBTITLE",
                     comment: "Subtitle shown on chat list banner for restoring media from a backup when paused because the device has low battery"
                 )
+            case .lowPowerMode:
+                OWSLocalizedString(
+                    "RESTORING_MEDIA_BANNER_PAUSED_LOW_POWER_MODE_SUBTITLE",
+                    comment: "Subtitle shown on chat list banner for restoring media from a backup when paused because the device is in low power mode"
+                )
             case .notReachable:
                 OWSLocalizedString(
                     "RESTORING_MEDIA_BANNER_PAUSED_NOT_REACHABLE_SUBTITLE",
@@ -993,3 +1015,36 @@ private class BackupAttachmentDownloadProgressView: UIView {
         }
     }
 }
+
+// MARK: -
+
+#if DEBUG
+
+private class BackupDownloadProgressPreviewViewController: UIViewController {
+    private let state: BackupAttachmentDownloadProgressView.State
+
+    init(state: BackupAttachmentDownloadProgressView.State) {
+        self.state = state
+        super.init(nibName: nil, bundle: nil)
+    }
+
+    required init?(coder: NSCoder) { fatalError() }
+
+    override func viewDidLoad() {
+        super.viewDidLoad()
+
+        let progressView = BackupAttachmentDownloadProgressView(
+            forPreview: (),
+            state: state
+        )
+        view.addSubview(progressView)
+        progressView.autoPinEdges(toSuperviewMarginsExcludingEdge: .bottom)
+    }
+}
+
+@available(iOS 17, *)
+#Preview {
+    return BackupDownloadProgressPreviewViewController(state: .paused(reason: .lowPowerMode))
+}
+
+#endif
diff --git a/Signal/translations/en.lproj/Localizable.strings b/Signal/translations/en.lproj/Localizable.strings
@@ -760,6 +760,9 @@
 /* Subtitle for a progress bar tracking downloads that are paused because of low battery. */
 "BACKUP_SETTINGS_DOWNLOAD_PROGRESS_SUBTITLE_PAUSED_LOW_BATTERY" = "Download paused: device has low battery";
 
+/* Subtitle for a progress bar tracking downloads that are paused because of low power mode. */
+"BACKUP_SETTINGS_DOWNLOAD_PROGRESS_SUBTITLE_PAUSED_LOW_POWER_MODE" = "Download paused: low power mode";
+
 /* Subtitle for a progress bar tracking downloads that are paused because they need more disk space available. Embeds {{ the amount of space needed as a file size, e.g. 100 MB }}. */
 "BACKUP_SETTINGS_DOWNLOAD_PROGRESS_SUBTITLE_PAUSED_NEEDS_DISK_SPACE" = "Not enough space to download your media. To continue free up %1$@ of space.";
 
@@ -850,6 +853,9 @@
 /* Subtitle for a progress bar tracking uploads that are paused because of low battery. */
 "BACKUP_SETTINGS_UPLOAD_PROGRESS_SUBTITLE_PAUSED_LOW_BATTERY" = "Media upload paused: device has low battery";
 
+/* Subtitle for a progress bar tracking uploads that are paused because of low power mode. */
+"BACKUP_SETTINGS_UPLOAD_PROGRESS_SUBTITLE_PAUSED_LOW_POWER_MODE" = "Media upload paused: low power mode";
+
 /* Subtitle for a progress bar tracking uploads that are paused because they need an internet connection */
 "BACKUP_SETTINGS_UPLOAD_PROGRESS_SUBTITLE_PAUSED_NEEDS_INTERNET" = "Media upload paused: no internet…";
 
@@ -7060,6 +7066,9 @@
 /* Subtitle shown on chat list banner for restoring media from a backup when paused because the device has low battery */
 "RESTORING_MEDIA_BANNER_PAUSED_BATTERY_SUBTITLE" = "Device has low battery";
 
+/* Subtitle shown on chat list banner for restoring media from a backup when paused because the device is in low power mode */
+"RESTORING_MEDIA_BANNER_PAUSED_LOW_POWER_MODE_SUBTITLE" = "Low power mode";
+
 /* Subtitle shown on chat list banner for restoring media from a backup when paused because the device has no internet connection */
 "RESTORING_MEDIA_BANNER_PAUSED_NOT_REACHABLE_SUBTITLE" = "No internet…";
 
diff --git a/SignalServiceKit/Backups/Attachments/BackupAttachmentDownloadManager.swift b/SignalServiceKit/Backups/Attachments/BackupAttachmentDownloadManager.swift
@@ -238,6 +238,10 @@ public class BackupAttachmentDownloadManagerImpl: BackupAttachmentDownloadManage
             logger.info("Skipping \(logString) backup attachment downloads while low battery")
             try await taskQueue.stop()
             return
+        case .lowPowerMode:
+            logger.info("Skipping \(logString) backup attachment downloads while low power mode")
+            try await taskQueue.stop()
+            return
         case .lowDiskSpace:
             logger.info("Skipping \(logString) backup attachment downloads while low on disk space")
             try await taskQueue.stop()
@@ -402,7 +406,7 @@ public class BackupAttachmentDownloadManagerImpl: BackupAttachmentDownloadManage
             case .lowDiskSpace:
                 try? await loader.stop()
                 return .retryableError(NeedsDiskSpaceError())
-            case .lowBattery:
+            case .lowBattery, .lowPowerMode:
                 try? await loader.stop()
                 return .retryableError(NeedsBatteryError())
             case .appBackgrounded:
@@ -548,7 +552,7 @@ public class BackupAttachmentDownloadManagerImpl: BackupAttachmentDownloadManage
                 case .empty:
                     // The queue will stop on its own, finish this task.
                     break
-                case .suspended, .lowDiskSpace, .lowBattery, .noWifiReachability, .noReachability, .appBackgrounded, .notRegisteredAndReady:
+                case .suspended, .lowDiskSpace, .lowBattery, .lowPowerMode, .noWifiReachability, .noReachability, .appBackgrounded, .notRegisteredAndReady:
                     // Stop the queue now proactively.
                     try? await loader.stop()
                 }
diff --git a/SignalServiceKit/Backups/Attachments/BackupAttachmentDownloadQueueStatusManager.swift b/SignalServiceKit/Backups/Attachments/BackupAttachmentDownloadQueueStatusManager.swift
@@ -26,8 +26,10 @@ public enum BackupAttachmentDownloadQueueStatus: Equatable, Sendable {
     case noWifiReachability
     /// Internet access is required for downloads, but not available.
     case noReachability
-    /// The device has low battery or is in low power mode.
+    /// The device has low battery.
     case lowBattery
+    /// The device is in low power mode.
+    case lowPowerMode
     /// There is not enough disk space to finish downloading.
     /// Note that we require a minimum amount of space and will continue
     /// greedily downloading until this minimum is reached even if we know
@@ -402,7 +404,7 @@ public class BackupAttachmentDownloadQueueStatusManagerImpl: BackupAttachmentDow
             }
 
             if isLowPowerMode == true {
-                return .lowBattery
+                return .lowPowerMode
             }
 
             if !isMainAppAndActive && !isMainAppAndActiveOverride {
@@ -504,13 +506,13 @@ public class BackupAttachmentDownloadQueueStatusManagerImpl: BackupAttachmentDow
         let notificationsToObserve: [(Notification.Name, Selector)] = [
             (.registrationStateDidChange, #selector(registrationStateDidChange)),
             (.reachabilityChanged, #selector(reachabilityDidChange)),
-            (UIDevice.batteryLevelDidChangeNotification, #selector(batteryLevelDidChange)),
-            (Notification.Name.NSProcessInfoPowerStateDidChange, #selector(lowPowerModeDidChange)),
+            (.batteryLevelChanged, #selector(batteryLevelDidChange)),
+            (.batteryLowPowerModeChanged, #selector(lowPowerModeDidChange)),
             (.OWSApplicationWillEnterForeground, #selector(willEnterForeground)),
             (.backupAttachmentDownloadQueueSuspensionStatusDidChange, #selector(suspensionStatusDidChange)),
             (.shouldAllowBackupDownloadsOnCellularChanged, #selector(shouldAllowBackupDownloadsOnCellularDidChange)),
-            (Notification.Name.OWSApplicationDidEnterBackground, #selector(isMainAppAndActiveDidChange)),
-            (Notification.Name.OWSApplicationDidBecomeActive, #selector(isMainAppAndActiveDidChange)),
+            (.OWSApplicationDidEnterBackground, #selector(isMainAppAndActiveDidChange)),
+            (.OWSApplicationDidBecomeActive, #selector(isMainAppAndActiveDidChange)),
         ]
         for (name, selector) in notificationsToObserve {
             NotificationCenter.default.addObserver(
diff --git a/SignalServiceKit/Backups/Attachments/BackupAttachmentUploadQueueRunner.swift b/SignalServiceKit/Backups/Attachments/BackupAttachmentUploadQueueRunner.swift
@@ -281,6 +281,9 @@ class BackupAttachmentUploadQueueRunnerImpl: BackupAttachmentUploadQueueRunner {
         case .lowBattery:
             logger.warn("Skipping \(logString) Backup uploads: low battery.")
             try await taskQueue.stop()
+        case .lowPowerMode:
+            logger.warn("Skipping \(logString) Backup uploads: low power mode.")
+            try await taskQueue.stop()
         case .appBackgrounded:
             logger.warn("Skipping \(logString) Backup uploads: app backgrounded")
             try await taskQueue.stop()
@@ -394,7 +397,7 @@ class BackupAttachmentUploadQueueRunnerImpl: BackupAttachmentUploadQueueRunner {
             case .empty:
                 // The queue will stop on its own, finish this task.
                 break
-            case .lowBattery:
+            case .lowBattery, .lowPowerMode:
                 try? await loader.stop()
                 return .retryableError(NeedsBatteryError())
             case .noWifiReachability, .noReachability:
@@ -614,7 +617,7 @@ class BackupAttachmentUploadQueueRunnerImpl: BackupAttachmentUploadQueueRunner {
                             // issue.
                             return .retryableError(NetworkRetryError())
                         case .noWifiReachability, .notRegisteredAndReady,
-                                .lowBattery, .appBackgrounded, .empty:
+                                .lowBattery, .lowPowerMode, .appBackgrounded, .empty:
                             // These other states may be overriding reachability;
                             // just allow the queue itself to retry and once the
                             // other states are resolved reachability will kick in,
diff --git a/SignalServiceKit/Backups/Attachments/BackupAttachmentUploadQueueStatusManager.swift b/SignalServiceKit/Backups/Attachments/BackupAttachmentUploadQueueStatusManager.swift
diff --git a/SignalServiceKit/Backups/Settings/BackupDisablingManager.swift b/SignalServiceKit/Backups/Settings/BackupDisablingManager.swift
diff --git a/SignalServiceKit/Util/DeviceBatteryLevelManager.swift b/SignalServiceKit/Util/DeviceBatteryLevelManager.swift
