Mark autoLoadMoreIfNecessary with @discardableResult.

There are six places where the result is unused vs one place where the result is used.

Author: igor-signal

Signal/ConversationView/ConversationViewController+CVC.swift

@@ -239,7 +239,7 @@ extension ConversationViewController: CVLoadCoordinatorDelegate {
         DispatchQueue.main.async {
             self.reloadReactionsDetailSheetWithSneakyTransaction()
             if hasViewDidAppearEverCompleted {
-                _ = self.autoLoadMoreIfNecessary()
+                self.autoLoadMoreIfNecessary()
             }
         }
     }
@@ -791,6 +791,7 @@ extension ConversationViewController: CVViewStateDelegate {
 // MARK: - Load More
 
 extension ConversationViewController {
+    @discardableResult
     public func autoLoadMoreIfNecessary() -> Bool {
         AssertIsOnMainThread()
 
@@ -815,7 +816,7 @@ extension ConversationViewController {
         if showLoadOlderHeader, isCloseToTop {
             if loadCoordinator.didLoadOlderRecently {
                 DispatchQueue.main.asyncAfter(deadline: .now() + 1) { [weak self] in
-                    _ = self?.autoLoadMoreIfNecessary()
+                    self?.autoLoadMoreIfNecessary()
                 }
                 return false
             }
@@ -830,7 +831,7 @@ extension ConversationViewController {
         if showLoadNewerHeader, isCloseToBottom {
             if loadCoordinator.didLoadNewerRecently {
                 DispatchQueue.main.asyncAfter(deadline: .now() + 1) { [weak self] in
-                    _ = self?.autoLoadMoreIfNecessary()
+                    self?.autoLoadMoreIfNecessary()
                 }
                 return false
             }

Signal/ConversationView/ConversationViewController+Delegates.swift

@@ -458,7 +458,7 @@ extension ConversationViewController {
         scrollingAnimationCompletionTimer?.invalidate()
         scrollingAnimationCompletionTimer = nil
 
-        _ = autoLoadMoreIfNecessary()
+        autoLoadMoreIfNecessary()
     }
 
     func resetForSizeOrOrientationChange() {

Signal/ConversationView/ConversationViewController+UIScrollView.swift

@@ -184,7 +184,7 @@ extension ConversationViewController: UIScrollViewDelegate {
             return
         }
 
-        _ = autoLoadMoreIfNecessary()
+        autoLoadMoreIfNecessary()
 
         if !isUserScrolling, !isWaitingForDeceleration {
             saveLastVisibleSortIdAndOnScreenPercentage()

Signal/ConversationView/ConversationViewController.swift

@@ -385,7 +385,7 @@ public final class ConversationViewController: OWSViewController {
         self.markVisibleMessagesAsRead()
         self.startReadTimer()
         self.updateNavigationBarSubtitleLabel()
-        _ = self.autoLoadMoreIfNecessary()
+        self.autoLoadMoreIfNecessary()
 
         let serviceIds = thread.recipientAddressesWithSneakyTransaction.compactMap(\.serviceId)
 

Signal/src/ViewControllers/MediaGallery/MediaTileViewController.swift

@@ -385,7 +385,7 @@ class MediaTileViewController: UICollectionViewController, MediaGalleryDelegate,
     private var scrollFlagShouldBeVisible = false
 
     override func scrollViewDidScroll(_ scrollView: UIScrollView) {
-        self.autoLoadMoreIfNecessary()
+        autoLoadMoreIfNecessary()
         showOrHideScrollFlag()
         if scrollFlag.superview != nil {
             updateScrollFlag()