[File based config] UT improvements (#2594)

* Tests added

* Cleanup of test yaml strings

* Cleanup

Author: robsunday

profiler/src/main/java/com/splunk/opentelemetry/profiler/snapshot/StackTraceExporterActivator.java

@@ -29,7 +29,6 @@
 import io.opentelemetry.sdk.autoconfigure.spi.ConfigProperties;
 import io.opentelemetry.sdk.resources.Resource;
 
-// TODO: Improve tests for this class to cover declarative config
 @AutoService(AgentListener.class)
 public class StackTraceExporterActivator implements AgentListener {
   private static final java.util.logging.Logger logger =

profiler/src/test/java/com/splunk/opentelemetry/profiler/JfrActivatorTest.java

@@ -17,7 +17,6 @@
 package com.splunk.opentelemetry.profiler;
 
 import static com.splunk.opentelemetry.testing.declarativeconfig.DeclarativeConfigTestUtil.createAutoConfiguredSdk;
-import static com.splunk.opentelemetry.testing.declarativeconfig.DeclarativeConfigTestUtil.toYamlString;
 import static org.mockito.ArgumentMatchers.any;
 import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.mockStatic;
@@ -140,10 +139,23 @@ void shouldNotActivateJfrRecording_profilerDisabled(String yaml, @TempDir Path t
   private List<Arguments> generateNoProfilerYamlStrings() {
     return List.of(
         Arguments.of("file_format: \"1.0-rc.3\""),
-        Arguments.of(toYamlString("file_format: \"1.0-rc.3\"", "distribution:")),
-        Arguments.of(toYamlString("file_format: \"1.0-rc.3\"", "distribution:", "  splunk:")),
         Arguments.of(
-            toYamlString(
-                "file_format: \"1.0-rc.3\"", "distribution:", "  splunk:", "    something:")));
+            """
+              file_format: "1.0-rc.3"
+              distribution:
+              """),
+        Arguments.of(
+            """
+              file_format: "1.0-rc.3"
+              distribution:
+                splunk:
+              """),
+        Arguments.of(
+            """
+              file_format: "1.0-rc.3"
+              distribution:
+                splunk:
+                  something:
+              """));
   }
 }

profiler/src/test/java/com/splunk/opentelemetry/profiler/snapshot/SnapshotProfilingConfigurationCustomizerProviderTest.java

@@ -16,7 +16,6 @@
 
 package com.splunk.opentelemetry.profiler.snapshot;
 
-import static com.splunk.opentelemetry.testing.declarativeconfig.DeclarativeConfigTestUtil.toYamlString;
 import static org.assertj.core.api.Assertions.assertThat;
 import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.verify;
@@ -47,7 +46,11 @@ void resetSuppliers() {
   void shouldDoNothingIfProfilerIsNotEnabled(@TempDir Path tempDir) throws IOException {
     // given
     String yaml =
-        toYamlString("file_format: \"1.0-rc.3\"", "instrumentation/development:", "  java:");
+        """
+          file_format: "1.0-rc.3"
+          instrumentation/development:
+            java:
+          """;
 
     // when
     OpenTelemetryConfigurationModel model = getCustomizedModel(yaml);
@@ -61,12 +64,13 @@ void shouldDoNothingIfProfilerIsNotEnabled(@TempDir Path tempDir) throws IOExcep
   void shouldAddShutdownHookSpanProcessor() {
     // given
     String yaml =
-        toYamlString(
-            "file_format: \"1.0-rc.3\"",
-            "distribution:",
-            "  splunk:",
-            "    profiling:",
-            "      callgraphs:");
+        """
+          file_format: "1.0-rc.3"
+          distribution:
+            splunk:
+              profiling:
+                callgraphs:
+          """;
 
     // when
     OpenTelemetryConfigurationModel model = getCustomizedModel(yaml);
@@ -85,11 +89,13 @@ void shouldInitialize() {
     // given
     OpenTelemetryConfigurationModel model =
         DeclarativeConfigTestUtil.parse(
-            "file_format: \"1.0-rc.3\"",
-            "distribution:",
-            "  splunk:",
-            "    profiling:",
-            "      callgraphs:");
+            """
+              file_format: "1.0-rc.3"
+              distribution:
+                splunk:
+                  profiling:
+                    callgraphs:
+              """);
 
     TraceRegistry traceRegistryMock = mock(TraceRegistry.class);
     ContextStorageWrapper contextStorageWrapperMock = mock(ContextStorageWrapper.class);

profiler/src/test/java/com/splunk/opentelemetry/profiler/snapshot/StackTraceExporterActivatorTest.java

@@ -16,19 +16,28 @@
 
 package com.splunk.opentelemetry.profiler.snapshot;
 
+import static com.splunk.opentelemetry.testing.declarativeconfig.DeclarativeConfigTestUtil.createAutoConfiguredSdk;
 import static org.junit.jupiter.api.Assertions.assertInstanceOf;
 import static org.junit.jupiter.api.Assertions.assertNotSame;
 import static org.junit.jupiter.api.Assertions.assertSame;
 
+import io.opentelemetry.instrumentation.testing.internal.AutoCleanupExtension;
 import io.opentelemetry.sdk.autoconfigure.OpenTelemetrySdkExtension;
+import java.io.IOException;
+import java.nio.file.Path;
 import org.junit.jupiter.api.AfterEach;
 import org.junit.jupiter.api.Nested;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.extension.RegisterExtension;
+import org.junit.jupiter.api.io.TempDir;
 
 class StackTraceExporterActivatorTest {
   @AfterEach
   void tearDown() {
+    SpanTracker.SUPPLIER.reset();
+    StackTraceSampler.SUPPLIER.reset();
+    StagingArea.SUPPLIER.reset();
+    SnapshotProfilingDeclarativeConfiguration.SUPPLIER.reset();
     StackTraceExporter.SUPPLIER.reset();
   }
 
@@ -64,4 +73,48 @@ void doNotConfigureStackTraceExporterProvider() {
       assertSame(StackTraceExporter.NOOP, exporter);
     }
   }
+
+  @Nested
+  class DeclarativeConfig {
+    @RegisterExtension final AutoCleanupExtension autoCleanup = AutoCleanupExtension.create();
+
+    @Test
+    void configureStackTraceExporterProvider(@TempDir Path tempDir) throws IOException {
+      String yaml =
+          """
+            file_format: "1.0-rc.3"
+            distribution:
+              splunk:
+                profiling:
+                  exporter:
+                    otlp_log_http:
+                  callgraphs:
+            """;
+      var sdk = createAutoConfiguredSdk(yaml, tempDir, autoCleanup);
+
+      new StackTraceExporterActivator().afterAgent(sdk);
+
+      var exporter = StackTraceExporter.SUPPLIER.get();
+      assertNotSame(StackTraceExporter.NOOP, exporter);
+      assertInstanceOf(AsyncStackTraceExporter.class, exporter);
+    }
+
+    @Test
+    void doNotConfigureStackTraceExporterProviderWhenNoCallgraphs(@TempDir Path tempDir)
+        throws IOException {
+      String yaml =
+          """
+            file_format: "1.0-rc.3"
+            distribution:
+              splunk:
+                profiling:
+            """;
+      var sdk = createAutoConfiguredSdk(yaml, tempDir, autoCleanup);
+
+      new StackTraceExporterActivator().afterAgent(sdk);
+
+      var exporter = StackTraceExporter.SUPPLIER.get();
+      assertSame(StackTraceExporter.NOOP, exporter);
+    }
+  }
 }

testing/common/src/main/java/com/splunk/opentelemetry/testing/declarativeconfig/DeclarativeConfigTestUtil.java

@@ -37,20 +37,11 @@
 import java.nio.charset.StandardCharsets;
 import java.nio.file.Files;
 import java.nio.file.Path;
-import java.util.Arrays;
 import java.util.Collections;
 
 public class DeclarativeConfigTestUtil {
   private DeclarativeConfigTestUtil() {}
 
-  public static String toYamlString(String... lines) {
-    return String.join("\n", Arrays.asList(lines));
-  }
-
-  public static OpenTelemetryConfigurationModel parse(String... lines) {
-    return parse(toYamlString(lines));
-  }
-
   public static OpenTelemetryConfigurationModel parse(String yaml) {
     try (InputStream yamlStream = new ByteArrayInputStream(yaml.getBytes(StandardCharsets.UTF_8))) {
       return DeclarativeConfiguration.parse(yamlStream);