Skip to content

Commit 9d9c740

Browse files
authored
Remove official support for Python 3.8 (#634)
* Remove official support for Python 3.8 CI tests weren't working just for Python 3.8. Turns out Python 3.8 reached EOL last year so support should be removed anyway. https://devguide.python.org/versions/ * Run hatch fmt
1 parent e67548c commit 9d9c740

File tree

5 files changed

+8
-7
lines changed

5 files changed

+8
-7
lines changed

.github/workflows/ci-main.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ jobs:
2222
fail-fast: false
2323
matrix:
2424
os: [ubuntu-latest, windows-latest, macos-latest]
25-
python-version: ['3.8', '3.9', '3.10', '3.11', '3.12', '3.13']
25+
python-version: ['3.9', '3.10', '3.11', '3.12', '3.13']
2626

2727
steps:
2828
- uses: actions/checkout@v4

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ This distribution comes with the following defaults:
2525

2626
## Requirements
2727

28-
This Splunk Distribution of OpenTelemetry requires Python 3.8 or later. Supported
28+
This Splunk Distribution of OpenTelemetry requires Python 3.9 or later. Supported
2929
libraries are listed
3030
[here](https://github.com/open-telemetry/opentelemetry-python-contrib/tree/main/instrumentation).
3131

pyproject.toml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,14 +7,13 @@ name = "splunk-opentelemetry"
77
dynamic = ["version"]
88
description = ''
99
readme = "README.md"
10-
requires-python = ">=3.8"
10+
requires-python = ">=3.9"
1111
license = "Apache-2.0"
1212
keywords = []
1313
authors = []
1414
classifiers = [
1515
"Development Status :: 4 - Beta",
1616
"Programming Language :: Python",
17-
"Programming Language :: Python :: 3.8",
1817
"Programming Language :: Python :: 3.9",
1918
"Programming Language :: Python :: 3.10",
2019
"Programming Language :: Python :: 3.11",
@@ -69,7 +68,7 @@ cov = [
6968
]
7069

7170
[[tool.hatch.envs.all.matrix]]
72-
python = ["3.8", "3.9", "3.10", "3.11", "3.12"]
71+
python = ["3.9", "3.10", "3.11", "3.12"]
7372

7473
[tool.hatch.envs.types]
7574
dependencies = [

tests/ott_init_otel.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
from typing import Mapping, Optional, Sequence
1+
from collections.abc import Mapping, Sequence
2+
from typing import Optional
23

34
from oteltest.telemetry import count_spans
45
from ott_lib import project_path, trace_loop

tests/ott_propagator.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
from typing import Mapping, Optional, Sequence
1+
from collections.abc import Mapping, Sequence
2+
from typing import Optional
23

34
from ott_lib import UPSTREAM_PRERELEASE_VERSION, project_path
45

0 commit comments

Comments
 (0)