config: Clarify that new blocking codes are valid HTTP codes >=300 (300-599).

Author: brectanus-sigsci

CHANGELOG.md

@@ -2,7 +2,7 @@
 
 ## Unreleased
 
-* Deprecated the `AltResponseCodes` concept in favor of using all code 300 and higher as "blocking"
+* Deprecated the `AltResponseCodes` concept in favor of using all codes 300-599 as "blocking"
 
 ## 1.7.1 2020-04-06
 

config.go

@@ -96,7 +96,7 @@ func (c *ModuleConfig) SetOptions(options ...ModuleConfigOption) error {
 
 // IsBlockCode returns true if the code is a configured block code
 func (c *ModuleConfig) IsBlockCode(code int) bool {
-	return code >= 300
+	return code >= 300 && code <= 599
 }
 
 // IsAllowCode returns true if the code is an allow code
@@ -113,7 +113,7 @@ func (c *ModuleConfig) AllowUnknownContentLength() bool {
 //
 // Deprecated: The `AltResponseCodes` concept has
 // been deprecated in favor of treating all response
-// codes 300 and greater as blocking codes. Due to
+// codes 300-599 as blocking codes. Due to
 // this, this method will always return nil. It is left
 // here to avoid breakage, but will eventually be removed.
 func (c *ModuleConfig) AltResponseCodes() []int {
@@ -216,7 +216,7 @@ func AllowUnknownContentLength(allow bool) ModuleConfigOption {
 //
 // Deprecated: The `AltResponseCodes` concept has
 // been deprecated in favor of treating all response
-// codes 300 and greater as blocking codes. Due to
+// codes 300-599 as blocking codes. Due to
 // this, this method will always return nil. It is left
 // here to avoid breakage, but will eventually be removed.
 func AltResponseCodes(codes ...int) ModuleConfigOption {

config_test.go

@@ -72,6 +72,9 @@ func TestDefaultModuleConfig(t *testing.T) {
 			t.Errorf("Unexpected IsBlockCode(%d): %v", code, c.IsBlockCode(code))
 		}
 	}
+	if c.IsBlockCode(600) {
+		t.Errorf("Unexpected IsBlockCode(600): %v", c.IsBlockCode(600))
+	}
 	if c.IsBlockCode(200) {
 		t.Errorf("Unexpected IsBlockCode(200): %v", c.IsBlockCode(200))
 	}
@@ -154,6 +157,9 @@ func TestConfiguredModuleConfig(t *testing.T) {
 			t.Errorf("Unexpected IsBlockCode(%d): %v", code, c.IsBlockCode(code))
 		}
 	}
+	if c.IsBlockCode(600) {
+		t.Errorf("Unexpected IsBlockCode(600): %v", c.IsBlockCode(600))
+	}
 	if c.IsBlockCode(200) {
 		t.Errorf("Unexpected IsBlockCode(200): %v", c.IsBlockCode(200))
 	}
@@ -243,6 +249,9 @@ func TestFromModuleConfig(t *testing.T) {
 			t.Errorf("Unexpected IsBlockCode(%d): %v", code, c.IsBlockCode(code))
 		}
 	}
+	if c.IsBlockCode(600) {
+		t.Errorf("Unexpected IsBlockCode(600): %v", c.IsBlockCode(600))
+	}
 	if c.IsBlockCode(200) {
 		t.Errorf("Unexpected IsBlockCode(200): %v", c.IsBlockCode(200))
 	}