Wrong minimum fee for `sendMoneyEscrow` and `escrowSign`

[deleterium]

It is stated at getConstants that escrow creation and escrow sign have minimum fee of 0.01 Signa. But trying to creating transactions, the node returns error if the fee is lower than 1 Signa.

getConstants

...
    {
      "value": 21,
      "description": "Advanced Payment",
      "subtypes": [
        {
          "value": 0,
          "description": "Escrow Creation",
          "minimumFeeConstantNQT": 1000000,
          "minimumFeeAppendagesNQT": 1000000
        },
        {
          "value": 1,
          "description": "Escrow Sign",
          "minimumFeeConstantNQT": 1000000,
          "minimumFeeAppendagesNQT": 1000000
        },
...

Response of a transaction with a fee lower than 1 Signa

{
    errorCode: 4
    errorDescription: "Escrow transaction must have a fee at least 1 burst"
    requestProcessingTime: 1
}

Expected result is that getConstant returns minimum fee of 1 Signa or the node accepts transaction with fee of 0,01 Signa.

[damccull]

Ok, this is due to the code at these locations:

signum-node/src/brs/TransactionType.java

Lines 2962 to 2964 in 7dc78dd

	if (transaction.getFeeNqt() < Constants.ONE_SIGNA) {
	throw new SignumException.NotValidException("Escrow transaction must have a fee at least 1 burst");
	}

.

signum-node/src/brs/TransactionType.java

Lines 3045 to 3047 in 7dc78dd

	if (transaction.getAmountNqt() != 0 || transaction.getFeeNqt() != Constants.ONE_SIGNA) {
	throw new SignumException.NotValidException("Escrow signing must have amount 0 and fee of 1");
	}

Looks like it can be easily changed by choosing a new value here. I'm not sure if this has any other secondary effects, yet, but it looks to my like this is the only place it's enforced.

I'll send a PR for this later, though I'll need someone to test it out for me.