submitNonce api requestType should use the body for input instead of query string parameters

[damccull]

Currently, the submitNonce requestType is accepting mining nonce submissions via POST but with the data in the query string. This is not good practice, and it should be accepting the data via the body of the POST.

To fix, I propose adding the ability for the node to accept data from either the query string or the body, with the body taking precedence if both are included. Next, update the miner software to start sending the POST request with the data in the body. Finally, after the next fork, or a few versions later, note that the node is no longer compatible with miners older than the fixed version and remove the ability to accept data from the query string.

This will bring this API request in line with best practice and understanding of API behavior.

[ohager]

go ahead :)

[ohager]

Just a comment on that in general:

The Node API is merely an RCP pattern (and no REST API!); And - with exception of publish contracts* - all POST calls use URL query params, which as @damccull said, is not considered best practice (not in 2025 and also not in 2018). At least the API is mostly consistent which allowed us to apply OpenAPI Spec to generate the interactive Docs.

*) contracts payload may hit size limits for query params, that's why a body is more appropriate.

[damccull]

Well perhaps this should just be the start then. On the p2p side all post requests are using the body, not query params. I'll look into this when I get some time in a couple weeks, and if it goes well I will look into the possibility of transitioning the rest of the API calls to body based posts as well.