Skip to content

Commit a080bb5

Browse files
Increase HTTP timeouts on CI (#8031)
Since we re-enabled HTTP API tests on CI (#7943) there have been a few spurious failures: - https://github.com/sigp/lighthouse/actions/runs/17608432465/job/50024519938?pr=7783 That error is awkward, but running locally with a short timeout confirms it to be a timeout. Change the request timeout to 5s everywhere. We had kept it shorter to try to detect performance regressions, but I think this is better suited to being done with metrics & traces. On CI we really just want things to pass reliably without flakiness, so I think a longer timeout to handle slower test code (like mock-builder) and overworked CI boxes makes sense. Co-Authored-By: Michael Sproul <[email protected]>
1 parent 02d519e commit a080bb5

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

beacon_node/http_api/src/test_utils.rs

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -145,12 +145,11 @@ impl<E: EthSpec> InteractiveTester<E> {
145145
tokio::spawn(mock_builder_server);
146146
}
147147

148-
// Override the default timeout to 2s to timeouts on CI, as CI seems to require longer
149-
// to process. The 1s timeouts for other tasks have been working for a long time, so we'll
150-
// keep it as it is, as it may help identify a performance regression.
148+
// Use 5s timeouts on CI, as there are several sources of artifical slowness, including
149+
// mock-builder.
151150
let timeouts = Timeouts {
152-
default: Duration::from_secs(2),
153-
..Timeouts::set_all(Duration::from_secs(1))
151+
default: Duration::from_secs(5),
152+
..Timeouts::set_all(Duration::from_secs(5))
154153
};
155154
let client = BeaconNodeHttpClient::new(beacon_url.clone(), timeouts);
156155

beacon_node/http_api/tests/broadcast_validation_tests.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1383,7 +1383,8 @@ pub async fn blinded_equivocation_gossip() {
13831383
// XXX: this should be a 400 but is a 500 due to the mock-builder being janky
13841384
assert_eq!(
13851385
error_response.status(),
1386-
Some(StatusCode::INTERNAL_SERVER_ERROR)
1386+
Some(StatusCode::INTERNAL_SERVER_ERROR),
1387+
"{error_response:?}"
13871388
);
13881389
} else {
13891390
assert_eq!(error_response.status(), Some(StatusCode::BAD_REQUEST));

0 commit comments

Comments
 (0)