Skip to content

Commit 2c3fadf

Browse files
committed
greatfet: don't print misleading "unknown" libusb error text
Only lookup libusb error messages for negative return values which communicate error codes. Positive return values are transmission counts and are not an error. The "UNKNOWN" messages only were seen at higher log levels. Users were not affected by the issue.
1 parent 0dc36c9 commit 2c3fadf

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/hardware/greatfet/protocol.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,7 @@ static int greatfet_ctrl_out_in(const struct sr_dev_inst *sdi,
169169
flags, (void *)tx_data, tx_size, timeout_ms);
170170
if (sr_log_loglevel_get() >= SR_LOG_SPEW) {
171171
const char *msg;
172-
msg = ret ? libusb_error_name(ret) : "-";
172+
msg = ret < 0 ? libusb_error_name(ret) : "-";
173173
sr_spew("USB out, rc %d, %s", ret, msg);
174174
}
175175
if (ret < 0) {
@@ -197,7 +197,7 @@ static int greatfet_ctrl_out_in(const struct sr_dev_inst *sdi,
197197
0, rx_data, rx_size, timeout_ms);
198198
if (sr_log_loglevel_get() >= SR_LOG_SPEW) {
199199
const char *msg;
200-
msg = ret ? libusb_error_name(ret) : "-";
200+
msg = ret < 0 ? libusb_error_name(ret) : "-";
201201
sr_spew("USB in, rc %d, %s", ret, msg);
202202
}
203203
if (ret < 0) {

0 commit comments

Comments
 (0)