Skip to content

Commit 04c5131

Browse files
authored
Use "release published" as our release event for asset uploading (#16)
* action: use the "published" event on releases instead of "created" This more accurately reflects the release lifecycle. Signed-off-by: William Woodruff <[email protected]> * README: qualify `release-signing-artifacts` event Signed-off-by: William Woodruff <[email protected]>
1 parent 3888adc commit 04c5131

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -344,7 +344,7 @@ Example:
344344
**Default**: `false`
345345

346346
The `release-signing-artifacts` setting controls whether or not `sigstore-python`
347-
uploads signing artifacts to the release that triggered this run.
347+
uploads signing artifacts to the release publishing event that triggered this run.
348348

349349
By default, no release assets are uploaded.
350350

action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,6 +113,6 @@ runs:
113113
path: "${{ env.GHA_SIGSTORE_PYTHON_SIGNING_ARTIFACTS }}"
114114

115115
- uses: softprops/action-gh-release@v1
116-
if: inputs.release-signing-artifacts == 'true' && github.event_name == 'release' && github.event.action == 'created'
116+
if: inputs.release-signing-artifacts == 'true' && github.event_name == 'release' && github.event.action == 'published'
117117
with:
118118
files: "${{ env.GHA_SIGSTORE_PYTHON_SIGNING_ARTIFACTS }}"

0 commit comments

Comments
 (0)