Skip to content

Commit 2e77c5f

Browse files
fix: remove unintended conditional grouping causing overtriggering (#553)
Previously testing if an issue comment was a PR and if the comment started with `/bench` were grouped in the same expression and evaluated to true for every PR comment. The ${{ }} expression syntax is optional in `if` conditionals, so I removed it. This wasn't caught initially as I always tested with comments that started with `/bench`, and never with a comment that shouldn't have triggered the benchmark. Signed-off-by: Spencer Schrock <[email protected]>
1 parent 29ad412 commit 2e77c5f

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

.github/workflows/bench.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ permissions: {}
88

99
jobs:
1010
publish-benchmark-container:
11-
if: ${{ github.event_name == 'workflow_dispatch' }} || ${{ (github.event.issue.pull_request) && (startsWith(github.event.comment.body, '/bench')) }}
11+
if: github.event_name == 'workflow_dispatch' || (github.event.issue.pull_request && startsWith(github.event.comment.body, '/bench'))
1212
runs-on: [ubuntu-latest]
1313
permissions:
1414
packages: write

0 commit comments

Comments
 (0)