Skip to content

Commit 4fedd98

Browse files
committed
Fix merge issues
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
2 parents cf06d34 + eec57a5 commit 4fedd98

File tree

4 files changed

+7
-19
lines changed

4 files changed

+7
-19
lines changed

sigstore-java/src/main/java/dev/sigstore/TrustedRootProvider.java

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,15 +15,12 @@
1515
*/
1616
package dev.sigstore;
1717

18-
import com.google.common.base.Preconditions;
19-
import dev.sigstore.trustroot.SigstoreConfigurationException;
20-
import dev.sigstore.trustroot.SigstoreTrustedRoot;
21-
import dev.sigstore.tuf.SigstoreTufClient;
2218
import java.io.IOException;
2319
import java.nio.file.Files;
2420
import java.nio.file.Path;
2521
import java.security.InvalidKeyException;
2622
import java.security.NoSuchAlgorithmException;
23+
import java.security.cert.CertificateException;
2724
import java.security.spec.InvalidKeySpecException;
2825

2926
import com.google.common.base.Preconditions;
@@ -36,7 +33,7 @@
3633
public interface TrustedRootProvider {
3734

3835
SigstoreTrustedRoot get() throws SigstoreConfigurationException;
39-
36+
4037
static TrustedRootProvider from(SigstoreTufClient.Builder tufClientBuilder) {
4138
Preconditions.checkNotNull(tufClientBuilder);
4239
return () -> {

sigstore-java/src/main/java/dev/sigstore/trustroot/SigstoreTrustedRoot.java

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,6 @@
1515
*/
1616
package dev.sigstore.trustroot;
1717

18-
import java.io.IOException;
19-
import java.io.InputStream;
20-
import com.google.protobuf.util.JsonFormat;
21-
import java.io.InputStreamReader;
22-
import java.nio.charset.StandardCharsets;
23-
import dev.sigstore.proto.trustroot.v1.TrustedRootOrBuilder;
2418
import java.io.IOException;
2519
import java.io.InputStream;
2620
import java.io.InputStreamReader;
@@ -53,8 +47,8 @@ public interface SigstoreTrustedRoot {
5347
List<CertificateAuthority> getTSAs();
5448

5549
/** Create an instance from an input stream of a json representation of a trustedroot. */
56-
static SigstoreTrustedRoot from(InputStream json)
57-
throws SigstoreConfigurationException, CertificateException {
50+
static SigstoreTrustedRoot from(InputStream json)
51+
throws SigstoreConfigurationException, CertificateException {
5852
var trustedRootBuilder = TrustedRoot.newBuilder();
5953
try (var reader = new InputStreamReader(json, StandardCharsets.UTF_8)) {
6054
JsonFormat.parser().merge(reader, trustedRootBuilder);
@@ -65,8 +59,8 @@ static SigstoreTrustedRoot from(InputStream json)
6559
}
6660

6761
/** Create an instance from a parsed proto definition of a trustedroot. */
68-
static SigstoreTrustedRoot from(TrustedRootOrBuilder proto)
69-
throws SigstoreConfigurationException, CertificateException {
62+
static SigstoreTrustedRoot from(TrustedRootOrBuilder proto)
63+
throws SigstoreConfigurationException, CertificateException {
7064
List<CertificateAuthority> cas = Lists.newArrayList();
7165
for (var certAuthority : proto.getCertificateAuthoritiesList()) {
7266
try {

sigstore-java/src/main/java/dev/sigstore/tuf/SigstoreTufClient.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
import java.nio.file.Path;
2424
import java.security.InvalidKeyException;
2525
import java.security.NoSuchAlgorithmException;
26+
import java.security.cert.CertificateException;
2627
import java.security.spec.InvalidKeySpecException;
2728
import java.time.Duration;
2829
import java.time.Instant;

sigstore-java/src/test/java/dev/sigstore/trustroot/SigstoreTrustedRootTest.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,10 +32,6 @@ class SigstoreTrustedRootTest {
3232
private static SigstoreTrustedRoot trustRoot;
3333

3434
@BeforeAll
35-
public static void initTrustRoot() throws Exception {
36-
trustRoot =
37-
SigstoreTrustedRoot.from(
38-
Resources.getResource("dev/sigstore/trustroot/trusted_root.json").openStream());
3935
public static void initTrustRoot() throws Exception {
4036
trustRoot =
4137
SigstoreTrustedRoot.from(

0 commit comments

Comments
 (0)