Skip to content

Commit 6333a46

Browse files
committed
Use Sigstore staging TSA in timestamp client
Signed-off-by: Aaron Lew <[email protected]>
1 parent c58a351 commit 6333a46

File tree

1 file changed

+6
-18
lines changed

1 file changed

+6
-18
lines changed

sigstore-java/src/test/java/dev/sigstore/timestamp/client/TimestampClientHttpTest.java

Lines changed: 6 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -21,11 +21,6 @@
2121
import static org.junit.jupiter.api.Assertions.assertThrows;
2222
import static org.junit.jupiter.api.Assertions.assertTrue;
2323

24-
import com.google.api.client.http.HttpRequestFactory;
25-
import dev.sigstore.http.HttpClients;
26-
import dev.sigstore.http.HttpParams;
27-
import dev.sigstore.http.ImmutableHttpParams;
28-
import java.net.URI;
2924
import java.nio.charset.StandardCharsets;
3025
import java.security.MessageDigest;
3126
import okhttp3.mockwebserver.MockResponse;
@@ -36,19 +31,12 @@
3631
import org.junit.jupiter.api.Test;
3732

3833
public class TimestampClientHttpTest {
39-
private static HttpRequestFactory requestFactory;
40-
private static HttpParams httpParams;
4134
private static TimestampRequest tsReq;
4235

4336
private static final byte[] INVALID_TS_RESP_BYTES = new byte[14];
44-
private static final URI SIGSTORE_TSA_URI =
45-
URI.create("https://timestamp.sigstage.dev/api/v1/timestamp");
4637

4738
@BeforeAll
4839
public static void setup() throws Exception {
49-
httpParams = ImmutableHttpParams.builder().build();
50-
requestFactory = HttpClients.newRequestFactory(httpParams);
51-
5240
var digest = MessageDigest.getInstance("SHA-256");
5341
var artifactHashBytes = digest.digest("test".getBytes(StandardCharsets.UTF_8));
5442
tsReq =
@@ -60,7 +48,7 @@ public static void setup() throws Exception {
6048

6149
@Test
6250
public void timestamp_success() throws Exception {
63-
var client = new TimestampClientHttp(requestFactory, SIGSTORE_TSA_URI);
51+
var client = TimestampClientHttp.builder().build();
6452

6553
var tsResp = client.timestamp(tsReq);
6654

@@ -92,7 +80,7 @@ public void timestamp_failure_badResponse_incorrectDigestLength() throws Excepti
9280
.nonce(tsReq.getNonce())
9381
.build();
9482

95-
var client = new TimestampClientHttp(requestFactory, SIGSTORE_TSA_URI);
83+
var client = TimestampClientHttp.builder().build();
9684

9785
var tse =
9886
assertThrows(
@@ -112,7 +100,7 @@ public void timestamp_failure_badResponse_nonRetryableError() throws Exception {
112100
server.start();
113101

114102
var tsaUri = server.url("/v1/timestamp/").uri();
115-
var client = new TimestampClientHttp(requestFactory, tsaUri);
103+
var client = TimestampClientHttp.builder().setUri(tsaUri).build();
116104

117105
var tse =
118106
assertThrows(
@@ -134,7 +122,7 @@ public void timestamp_failure_badResponse_RetryableError() throws Exception {
134122
server.start();
135123

136124
var tsaUri = server.url("/v1/timestamp/").uri();
137-
var client = new TimestampClientHttp(requestFactory, tsaUri);
125+
var client = TimestampClientHttp.builder().setUri(tsaUri).build();
138126

139127
var tse =
140128
assertThrows(
@@ -156,7 +144,7 @@ public void timestamp_failure_invalidResponseFormat() throws Exception {
156144
server.start();
157145

158146
var tsaUri = server.url("/v1/timestamp/").uri();
159-
var client = new TimestampClientHttp(requestFactory, tsaUri);
147+
var client = TimestampClientHttp.builder().setUri(tsaUri).build();
160148

161149
var tse =
162150
assertThrows(
@@ -180,7 +168,7 @@ public void timestamp_failure_responseBodyReadError() throws Exception {
180168
server.start();
181169

182170
var tsaUri = server.url("/v1/timestamp/").uri();
183-
var client = new TimestampClientHttp(requestFactory, tsaUri);
171+
var client = TimestampClientHttp.builder().setUri(tsaUri).build();
184172

185173
var tse =
186174
assertThrows(

0 commit comments

Comments
 (0)