Merge pull request #260 from sigstore/fix-naming

Change rootHash() to getRootHash() for consistency

Author: loosebazooka

sigstore-java/src/main/java/dev/sigstore/rekor/client/RekorEntry.java

@@ -59,7 +59,7 @@ interface InclusionProof {
      *
      * @return SHA256 hash value expressed in hexadecimal format
      */
-    String rootHash();
+    String getRootHash();
 
     /** The size of the merkle tree at the time the inclusion proof was generated. */
     Long getTreeSize();

sigstore-java/src/main/java/dev/sigstore/rekor/client/RekorVerifier.java

@@ -131,12 +131,12 @@ public void verifyInclusionProof(RekorEntry entry) throws RekorVerificationExcep
     }
 
     var calcuatedRootHash = Hex.toHexString(currentHash);
-    if (!calcuatedRootHash.equals(inclusionProof.rootHash())) {
+    if (!calcuatedRootHash.equals(inclusionProof.getRootHash())) {
       throw new RekorVerificationException(
           "Calculated inclusion proof root hash does not match provided root hash\n"
               + calcuatedRootHash
               + "\n"
-              + inclusionProof.rootHash());
+              + inclusionProof.getRootHash());
     }
   }
 

sigstore-java/src/test/java/dev/sigstore/rekor/client/RekorClientTest.java

@@ -159,7 +159,7 @@ private void assertEntry(RekorResponse resp, Optional<RekorEntry> entry) {
     assertEquals(resp.getEntry().getLogID(), entry.get().getLogID());
     assertTrue(entry.get().getVerification().getInclusionProof().isPresent());
     assertNotNull(entry.get().getVerification().getInclusionProof().get().getTreeSize());
-    assertNotNull(entry.get().getVerification().getInclusionProof().get().rootHash());
+    assertNotNull(entry.get().getVerification().getInclusionProof().get().getRootHash());
     assertNotNull(entry.get().getVerification().getInclusionProof().get().getLogIndex());
     assertTrue(entry.get().getVerification().getInclusionProof().get().getHashes().size() > 0);
   }