Merge pull request #627 from sigstore/update-oidc-client-bom

loosebazooka · web-flow · commit a9f883e9ff15 · 2024-02-06T14:06:01.000-05:00
Update google-oauth-client-bom
diff --git a/sigstore-java/build.gradle.kts b/sigstore-java/build.gradle.kts
@@ -40,7 +40,7 @@ dependencies {
     implementation("org.bouncycastle:bcutil-jdk18on:1.77")
     implementation("org.bouncycastle:bcpkix-jdk18on:1.77")
 
-    implementation(platform("com.google.oauth-client:google-oauth-client-bom:1.34.1"))
+    implementation(platform("com.google.oauth-client:google-oauth-client-bom:1.35.0"))
     implementation("com.google.oauth-client:google-oauth-client")
     implementation("com.google.oauth-client:google-oauth-client-jetty")
     implementation("com.google.oauth-client:google-oauth-client-java6")
diff --git a/sigstore-java/src/main/java/dev/sigstore/oidc/client/WebOidcClient.java b/sigstore-java/src/main/java/dev/sigstore/oidc/client/WebOidcClient.java
@@ -171,7 +171,7 @@ public OidcToken getIDToken() throws OidcException {
               .setIssuer(issuer)
               .setCertificatesLocation(endpoints.getJwksUri())
               .build();
-      if (!idTokenVerifier.verify(parsedIdToken)) {
+      if (!idTokenVerifier.verifyOrThrow(parsedIdToken)) {
         throw new OidcException("id token could not be verified");
       }
     } catch (IOException e) {

Original file line number	Diff line number	Diff line change
`@@ -171,7 +171,7 @@ public OidcToken getIDToken() throws OidcException {`
`171`	`171`	`.setIssuer(issuer)`
`172`	`172`	`.setCertificatesLocation(endpoints.getJwksUri())`
`173`	`173`	`.build();`
`174`		`- if (!idTokenVerifier.verify(parsedIdToken)) {`
	`174`	`+ if (!idTokenVerifier.verifyOrThrow(parsedIdToken)) {`
`175`	`175`	`throw new OidcException("id token could not be verified");`
`176`	`176`	`}`
`177`	`177`	`} catch (IOException e) {`