Skip to content

Commit c4c06c8

Browse files
authored
Merge pull request #873 from sigstore/change_payload_type
Change payload type to byte[]
2 parents 0efb434 + a6fa3a2 commit c4c06c8

File tree

3 files changed

+11
-5
lines changed

3 files changed

+11
-5
lines changed

sigstore-java/src/main/java/dev/sigstore/bundle/Bundle.java

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@ public interface MessageDigest {
138138
public interface DsseEnvelope {
139139

140140
/** An arbitrary payload that does not need to be parsed to be validated */
141-
String getPayload();
141+
byte[] getPayload();
142142

143143
/** Information on how to interpret the payload */
144144
String getPayloadType();
@@ -158,12 +158,18 @@ default byte[] getPAE() {
158158
+ " "
159159
+ getPayloadType()
160160
+ " "
161-
+ getPayload().length()
161+
+ getPayloadAsString().length()
162162
+ " "
163-
+ getPayload())
163+
+ getPayloadAsString())
164164
.getBytes(StandardCharsets.UTF_8);
165165
}
166166

167+
@Lazy
168+
@Gson.Ignore
169+
default String getPayloadAsString() {
170+
return new String(getPayload(), StandardCharsets.UTF_8);
171+
}
172+
167173
@Lazy
168174
@Gson.Ignore
169175
default byte[] getSignature() {

sigstore-java/src/main/java/dev/sigstore/bundle/BundleReader.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ static Bundle readBundle(Reader jsonReader) throws BundleParseException {
103103
var dsseEnvelopeProto = protoBundle.getDsseEnvelope();
104104
var dsseEnvelopeBuilder =
105105
ImmutableDsseEnvelope.builder()
106-
.payload(dsseEnvelopeProto.getPayload().toStringUtf8())
106+
.payload(dsseEnvelopeProto.getPayload().toByteArray())
107107
.payloadType(dsseEnvelopeProto.getPayloadType());
108108
for (int sigIndex = 0; sigIndex < dsseEnvelopeProto.getSignaturesCount(); sigIndex++) {
109109
dsseEnvelopeBuilder.addSignatures(

sigstore-java/src/main/java/dev/sigstore/dsse/InTotoPayload.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,6 @@ interface Subject {
5252
}
5353

5454
static InTotoPayload from(DsseEnvelope dsseEnvelope) {
55-
return GSON.get().fromJson(dsseEnvelope.getPayload(), InTotoPayload.class);
55+
return GSON.get().fromJson(dsseEnvelope.getPayloadAsString(), InTotoPayload.class);
5656
}
5757
}

0 commit comments

Comments
 (0)