Skip to content

Commit e91d7fe

Browse files
authored
Merge pull request #645 from sigstore/cleanup-release
Cleanup CI
2 parents cfefd91 + 18343a0 commit e91d7fe

File tree

4 files changed

+28
-118
lines changed

4 files changed

+28
-118
lines changed

.github/workflows/ci.yaml

Lines changed: 9 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -49,21 +49,18 @@ jobs:
4949

5050
# at some point this should just be replaced with something that can bring up a sigstore test env
5151
- name: Install Fulcio
52-
run: |
53-
go install github.com/sigstore/fulcio@main
52+
run: go install github.com/sigstore/fulcio@main
53+
54+
- name: Setup Gradle
55+
uses: gradle/actions/setup-gradle@417ae3ccd767c252f5661f1ace9f835f9654f2b5 # v3.1.0
5456

5557
- name: Test sigstore-java
56-
uses: gradle/gradle-build-action@a8f75513eafdebd8141bd1cd4e30fcd194af8dfa # v2.12.0
57-
with:
58-
arguments: build
58+
run: ./gradlew build
5959

6060
- name: Ensure sigstore-java self signing still works
61-
uses: gradle/gradle-build-action@a8f75513eafdebd8141bd1cd4e30fcd194af8dfa # v2.12.0
62-
with:
63-
arguments: sigstore-java:publishToMavenLocal -Prelease -PskipPgpSigning
61+
run: ./gradlew sigstore-java:publishToMavenLocal -Prelease -PskipPgpSigning
6462

6563
- name: Test sigstore-java/sandbox
66-
uses: gradle/gradle-build-action@a8f75513eafdebd8141bd1cd4e30fcd194af8dfa # v2.12.0
67-
with:
68-
arguments: build
69-
build-root-directory: sandbox
64+
run: |
65+
cd sandbox
66+
./gradlew build

.github/workflows/conformance.yml

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,11 @@ jobs:
2323
java-version: ${{ matrix.java-version }}
2424
distribution: 'temurin'
2525

26-
- name: Build sigstore-java
27-
uses: gradle/gradle-build-action@a8f75513eafdebd8141bd1cd4e30fcd194af8dfa # v2.12.0
28-
with:
29-
arguments: :sigstore-cli:build
26+
- name: Setup Gradle
27+
uses: gradle/actions/setup-gradle@v3
28+
29+
- name: Build sigstore-java cli
30+
run: ./gradlew :sigstore-cli:build
3031

3132
- name: Unpack sigstore-java distribution
3233
run: tar -xvf ${{ github.workspace }}/sigstore-cli/build/distributions/sigstore-cli-*.tar --strip-components 1

.github/workflows/release-sigstore-gradle-plugin-from-tag.yaml

Lines changed: 8 additions & 55 deletions
Original file line numberDiff line numberDiff line change
@@ -34,11 +34,9 @@ jobs:
3434
permissions:
3535
id-token: write # To sign the artifacts
3636
runs-on: ubuntu-latest
37-
needs: [ci, process-tag]
38-
outputs:
39-
hashes: ${{ steps.hash.outputs.hashes }}
37+
needs: [ci]
4038
steps:
41-
- name: checkout tag
39+
- name: Checkout tag
4240
uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
4341

4442
- name: Set up JDK 11
@@ -47,6 +45,9 @@ jobs:
4745
java-version: 11
4846
distribution: 'temurin'
4947

48+
- name: Setup Gradle
49+
uses: gradle/actions/setup-gradle@417ae3ccd767c252f5661f1ace9f835f9654f2b5 # v3.1.0
50+
5051
- name: Build, Sign and Release to Gradle Plugin Portal
5152
run: |
5253
./gradlew publishPlugins -Prelease -Pgradle.publish.key=$GRADLE_PUBLISH_KEY -Pgradle.publish.secret=$GRADLE_PUBLISH_SECRET
@@ -56,63 +57,15 @@ jobs:
5657
GRADLE_PUBLISH_KEY: ${{ secrets.GRADLE_PUBLISH_KEY }}
5758
GRADLE_PUBLISH_SECRET: ${{ secrets.GRADLE_PUBLISH_SECRET }}
5859

59-
- name: SLSA -- Hash Artifacts
60-
id: hash
61-
run: |
62-
mkdir slsa-files
63-
cp sigstore-gradle/sigstore-gradle-sign-plugin/build/libs/*.jar slsa-files
64-
cp sigstore-gradle/sigstore-gradle-sign-plugin/build/publications/pluginMaven/pom-default.xml slsa-files/sigstore-gradle-sign-plugin-${{ needs.process-tag.outputs.version }}.pom
65-
cp sigstore-gradle/sigstore-gradle-sign-plugin/build/publications/pluginMaven/module.json slsa-files/sigstore-gradle-sign-plugin-${{ needs.process-tag.outputs.version }}.module
66-
cp sigstore-gradle/sigstore-gradle-sign-base-plugin/build/libs/*.jar slsa-files
67-
cp sigstore-gradle/sigstore-gradle-sign-base-plugin/build/publications/pluginMaven/pom-default.xml slsa-files/sigstore-gradle-sign-base-plugin-${{ needs.process-tag.outputs.version }}.pom
68-
cp sigstore-gradle/sigstore-gradle-sign-base-plugin/build/publications/pluginMaven/module.json slsa-files/sigstore-gradle-sign-base-plugin-${{ needs.process-tag.outputs.version }}.module
69-
cd slsa-files
70-
echo "hashes=$(sha256sum ./* | base64 -w0)" >> $GITHUB_OUTPUT
71-
72-
- name: Upload build artifacts
73-
uses: actions/upload-artifact@5d5d22a31266ced268874388b861e4b58bb5c2f3 # v4.3.1
74-
with:
75-
name: project-release-artifacts
76-
path: ./slsa-files
77-
if-no-files-found: error
78-
79-
provenance:
80-
needs: [build, process-tag]
81-
permissions:
82-
actions: read # To read the workflow path.
83-
id-token: write # To sign the provenance.
84-
contents: write # To add assets to a release.
85-
# use tags here: https://github.com/slsa-framework/slsa-github-generator#referencing-slsa-builders-and-generators
86-
# remember to update "Download Attestations" when SLSA updates to actions/download-artifact@v4
87-
uses: slsa-framework/slsa-github-generator/.github/workflows/[email protected]
88-
with:
89-
provenance-name: "sigstore-gradle-sign-plugin-${{ needs.process-tag.outputs.version }}.attestation.intoto.jsonl"
90-
base64-subjects: "${{ needs.build.outputs.hashes }}"
91-
9260
create-release-on-github:
9361
runs-on: ubuntu-latest
94-
needs: [provenance, build, process-tag]
62+
needs: [build]
9563
permissions:
9664
contents: write
9765
steps:
98-
- name: Download attestation
99-
# keep at v3.x since slsa generator uses 3.x (update this when slsa-framework updates)
100-
uses: actions/download-artifact@9bc31d5ccc31df68ecc42ccf4149144866c47d8a # v3.0.2
101-
with:
102-
name: "${{ needs.provenance.outputs.attestation-name }}"
103-
path: ./release/
104-
- name: Copy attestation for base plugin
105-
run: |
106-
cp "./release/${{ needs.provenance.outputs.attestation-name }}" "./release/sigstore-gradle-sign-base-plugin-${{ needs.process-tag.outputs.version }}.attestation.intoto.jsonl"
107-
- name: Download gradle release artifacts
108-
uses: actions/download-artifact@6b208ae046db98c579e8a3aa621ab581ff575935 # v4.1.1
109-
with:
110-
name: project-release-artifacts
111-
path: ./release/
11266
- name: Create release
11367
uses: softprops/action-gh-release@de2c0eb89ae2a093876385947365aca7b0e5f844 # tag=v0.1.15
11468
with:
115-
tag_name: v${{ needs.process-tag.outputs.version }}
116-
name: v${{ needs.process-tag.outputs.version }}-gradle
69+
tag_name: ${{ github.ref_name }}
70+
name: ${{ github.ref_name }}-gradle
11771
body: "See [CHANGELOG.md](https://github.com/${{ vars.GITHUB_REPOSITORY }}/blob/main/CHANGELOG.md) for more details."
118-
files: ./release/*

.github/workflows/release-sigstore-java-from-tag.yaml

Lines changed: 6 additions & 47 deletions
Original file line numberDiff line numberDiff line change
@@ -35,9 +35,7 @@ jobs:
3535
permissions:
3636
id-token: write # To sign the artifacts
3737
runs-on: ubuntu-latest
38-
needs: [ci, process-tag]
39-
outputs:
40-
hashes: ${{ steps.hash.outputs.hashes }}
38+
needs: [ci]
4139
steps:
4240
- name: checkout tag
4341
uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
@@ -48,6 +46,9 @@ jobs:
4846
java-version: 11
4947
distribution: 'temurin'
5048

49+
- name: Setup Gradle
50+
uses: gradle/actions/setup-gradle@417ae3ccd767c252f5661f1ace9f835f9654f2b5 # v3.1.0
51+
5152
- name: Build, Sign and Release to Maven Central
5253
run: |
5354
./gradlew clean :sigstore-java:publishMavenJavaPublicationToSonatypeRepository -Prelease
@@ -57,56 +58,14 @@ jobs:
5758
ORG_GRADLE_PROJECT_sonatypeUsername: ${{ secrets.SONATYPE_USERNAME }}
5859
ORG_GRADLE_PROJECT_sonatypePassword: ${{ secrets.SONATYPE_PASSWORD }}
5960

60-
- name: SLSA -- Hash Artifacts
61-
id: hash
62-
run: |
63-
mkdir slsa-files
64-
cp sigstore-java/build/libs/*.jar slsa-files
65-
cp sigstore-java/build/publications/mavenJava/pom-default.xml slsa-files/sigstore-java-${{ needs.process-tag.outputs.version }}.pom
66-
cp sigstore-java/build/publications/mavenJava/module.json slsa-files/sigstore-java-${{ needs.process-tag.outputs.version }}.module
67-
cd slsa-files
68-
echo "hashes=$(sha256sum ./* | base64 -w0)" >> $GITHUB_OUTPUT
69-
70-
- name: Upload build artifacts
71-
uses: actions/upload-artifact@5d5d22a31266ced268874388b861e4b58bb5c2f3 # v4.3.1
72-
with:
73-
name: project-release-artifacts
74-
path: ./slsa-files
75-
if-no-files-found: error
76-
77-
provenance:
78-
needs: [build, process-tag]
79-
permissions:
80-
actions: read # To read the workflow path.
81-
id-token: write # To sign the provenance.
82-
contents: write # To add assets to a release.
83-
# use tags here: https://github.com/slsa-framework/slsa-github-generator#referencing-slsa-builders-and-generators
84-
# remember to update "Download Attestations" when SLSA updates to actions/download-artifact@v4
85-
uses: slsa-framework/slsa-github-generator/.github/workflows/[email protected]
86-
with:
87-
provenance-name: "sigstore-java-${{ needs.process-tag.outputs.version }}.attestation.intoto.jsonl"
88-
base64-subjects: "${{ needs.build.outputs.hashes }}"
89-
9061
create-release-on-github:
9162
runs-on: ubuntu-latest
92-
needs: [provenance, build, process-tag]
63+
needs: [build]
9364
permissions:
9465
contents: write
9566
steps:
96-
- name: Download attestation
97-
# keep at v3.x since slsa generator uses 3.x (update this when slsa-framework updates)
98-
uses: actions/download-artifact@9bc31d5ccc31df68ecc42ccf4149144866c47d8a # v3.0.2
99-
with:
100-
name: "${{ needs.provenance.outputs.attestation-name }}"
101-
path: ./release/
102-
- name: Download gradle release artifacts
103-
uses: actions/download-artifact@6b208ae046db98c579e8a3aa621ab581ff575935 # v4.1.1
104-
with:
105-
name: project-release-artifacts
106-
path: ./release/
10767
- name: Create release
10868
uses: softprops/action-gh-release@de2c0eb89ae2a093876385947365aca7b0e5f844 # tag=v0.1.15
10969
with:
110-
tag_name: v${{ needs.process-tag.outputs.version }}
70+
tag_name: ${{ github.ref_name }}
11171
body: "See [CHANGELOG.md](https://github.com/${{ vars.GITHUB_REPOSITORY }}/blob/main/CHANGELOG.md) for more details."
112-
files: ./release/*

0 commit comments

Comments
 (0)