-
Notifications
You must be signed in to change notification settings - Fork 24
Use HTTP server for TUF conformance testing #1045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
52c7a19
to
e109a4e
Compare
30ed39b
to
981e60a
Compare
btw, is it possible to increase the verbosity of the client code somehow? Doesn't have to be a CLI flag or anything if that's complicated, a code change is fine, but would be useful to be able to see a little more of the client decisions... |
We don't really have much logging. But what are you looking for? |
was just interested to see what sort of decisions the client is making in general -- e.g. was interested in but if there's no logging like that then I know I'll have have to add some if I really want to know. |
there is some issue with the stream redirection:
What I imagine might happen (caveat: I barely read java):
This might not be important enough to fix considering what Appu said -- there's not much logging in the code. |
yeah I think we could run the server in a mode which tees the output to stdout/err as well as returning it to the conformance suite. So if someone happened to be testing locally running the server in a different terminal than the tests, then we'd be okay. |
Signed-off-by: Aaron Lew <[email protected]>
7a6046b
to
93f902f
Compare
|
||
import java.time.Clock; | ||
|
||
public class TestClock { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not super fond of the idea of a global test clock. I think this should be instantiable . And we can modify the cli to accept a "time" with a --time flag.
@@ -1,4 +1,6 @@ | |||
name: TUF Conformance Tests | |||
permissions: | |||
contents: read |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was this not working before?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not having this set triggered a GitHub security warning for #1038.
Summary
This change speeds up TUF conformance testing by using an HTTP server.