Skip to content

Commit 29ba622

Browse files
ramonpetgrave64jku
authored andcommitted
ranem to EntryRequestBody
Signed-off-by: Ramon Petgrave <[email protected]>
1 parent 1f71c8b commit 29ba622

File tree

4 files changed

+23
-19
lines changed

4 files changed

+23
-19
lines changed

sigstore/_internal/rekor/__init__.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
"_hashedrekord_from_parts",
3636
]
3737

38-
EntryRequest = NewType("EntryRequest", dict[str, Any])
38+
EntryRequestBody = NewType("EntryRequestBody", dict[str, Any])
3939

4040

4141
class RekorClientError(Exception):
@@ -68,7 +68,7 @@ class RekorLogSubmitter(ABC):
6868
@abstractmethod
6969
def create_entry(
7070
self,
71-
request: EntryRequest,
71+
request: EntryRequestBody,
7272
) -> LogEntry:
7373
"""
7474
Submit the request to Rekor.
@@ -79,7 +79,7 @@ def create_entry(
7979
@abstractmethod
8080
def _build_hashed_rekord_request(
8181
self, hashed_input: Hashed, signature: bytes, certificate: Certificate
82-
) -> EntryRequest:
82+
) -> EntryRequestBody:
8383
"""
8484
Construct a hashed rekord request to submit to Rekor.
8585
"""
@@ -89,7 +89,7 @@ def _build_hashed_rekord_request(
8989
@abstractmethod
9090
def _build_dsse_request(
9191
self, envelope: Envelope, certificate: Certificate
92-
) -> EntryRequest:
92+
) -> EntryRequestBody:
9393
"""
9494
Construct a dsse request to submit to Rekor.
9595
"""

sigstore/_internal/rekor/client.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232

3333
from sigstore._internal import USER_AGENT
3434
from sigstore._internal.rekor import (
35-
EntryRequest,
35+
EntryRequestBody,
3636
RekorClientError,
3737
RekorLogSubmitter,
3838
)
@@ -134,7 +134,7 @@ def get(
134134

135135
def post(
136136
self,
137-
payload: EntryRequest,
137+
payload: EntryRequestBody,
138138
) -> LogEntry:
139139
"""
140140
Submit a new entry for inclusion in the Rekor log.
@@ -250,15 +250,15 @@ def log(self) -> RekorLog:
250250
"""
251251
return RekorLog(f"{self.url}/log", session=self.session)
252252

253-
def create_entry(self, request: EntryRequest) -> LogEntry:
253+
def create_entry(self, request: EntryRequestBody) -> LogEntry:
254254
"""
255255
Submit the request to Rekor.
256256
"""
257257
return self.log.entries.post(request)
258258

259259
def _build_hashed_rekord_request( # type: ignore[override]
260260
self, hashed_input: Hashed, signature: bytes, certificate: Certificate
261-
) -> EntryRequest:
261+
) -> EntryRequestBody:
262262
"""
263263
Construct a hashed rekord payload to submit to Rekor.
264264
"""
@@ -282,11 +282,11 @@ def _build_hashed_rekord_request( # type: ignore[override]
282282
),
283283
),
284284
)
285-
return EntryRequest(rekord.model_dump(mode="json", by_alias=True))
285+
return EntryRequestBody(rekord.model_dump(mode="json", by_alias=True))
286286

287287
def _build_dsse_request( # type: ignore[override]
288288
self, envelope: Envelope, certificate: Certificate
289-
) -> EntryRequest:
289+
) -> EntryRequestBody:
290290
"""
291291
Construct a dsse request to submit to Rekor.
292292
"""
@@ -308,4 +308,4 @@ def _build_dsse_request( # type: ignore[override]
308308
),
309309
),
310310
)
311-
return EntryRequest(dsse.model_dump(mode="json", by_alias=True))
311+
return EntryRequestBody(dsse.model_dump(mode="json", by_alias=True))

sigstore/_internal/rekor/client_v2.py

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,11 @@
3131
from sigstore_protobuf_specs.io import intoto
3232

3333
from sigstore._internal import USER_AGENT
34-
from sigstore._internal.rekor import EntryRequest, RekorClientError, RekorLogSubmitter
34+
from sigstore._internal.rekor import (
35+
EntryRequestBody,
36+
RekorClientError,
37+
RekorLogSubmitter,
38+
)
3539
from sigstore.dsse import Envelope
3640
from sigstore.hashes import Hashed
3741
from sigstore.models import LogEntry
@@ -65,7 +69,7 @@ def __del__(self) -> None:
6569
"""
6670
self.session.close()
6771

68-
def create_entry(self, payload: EntryRequest) -> LogEntry:
72+
def create_entry(self, payload: EntryRequestBody) -> LogEntry:
6973
"""
7074
Submit a new entry for inclusion in the Rekor log.
7175
@@ -109,7 +113,7 @@ def _build_hashed_rekord_request(
109113
hashed_input: Hashed,
110114
signature: bytes,
111115
certificate: Certificate,
112-
) -> EntryRequest:
116+
) -> EntryRequestBody:
113117
"""
114118
Construct a hashed rekord request to submit to Rekor.
115119
"""
@@ -129,12 +133,12 @@ def _build_hashed_rekord_request(
129133
),
130134
)
131135
)
132-
return EntryRequest(req.to_dict())
136+
return EntryRequestBody(req.to_dict())
133137

134138
@classmethod
135139
def _build_dsse_request(
136140
cls, envelope: Envelope, certificate: Certificate
137-
) -> EntryRequest:
141+
) -> EntryRequestBody:
138142
"""
139143
Construct a dsse request to submit to Rekor.
140144
"""
@@ -163,4 +167,4 @@ def _build_dsse_request(
163167
],
164168
)
165169
)
166-
return EntryRequest(req.to_dict())
170+
return EntryRequestBody(req.to_dict())

sigstore/sign.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@
5959
ExpiredCertificate,
6060
FulcioClient,
6161
)
62-
from sigstore._internal.rekor import EntryRequest, RekorLogSubmitter
62+
from sigstore._internal.rekor import EntryRequestBody, RekorLogSubmitter
6363
from sigstore._internal.sct import verify_sct
6464
from sigstore._internal.timestamp import TimestampAuthorityClient, TimestampError
6565
from sigstore._internal.trust import ClientTrustConfig, KeyringPurpose, TrustedRoot
@@ -174,7 +174,7 @@ def _finalize_sign(
174174
self,
175175
cert: x509.Certificate,
176176
content: MessageSignature | dsse.Envelope,
177-
proposed_entry: EntryRequest,
177+
proposed_entry: EntryRequestBody,
178178
) -> Bundle:
179179
"""
180180
Perform the common "finalizing" steps in a Sigstore signing flow.

0 commit comments

Comments
 (0)