rekor: remove timeout for now

* The timeout was a little misleading (since requests timeout is not the
  total maximum time of the request) and we don't have specific timeouts
  elsewhere either.
* Also remove some unused variables

Signed-off-by: Jussi Kukkonen <[email protected]>

Author: jku

sigstore/_internal/rekor/client_v2.py

@@ -37,20 +37,14 @@
 
 _logger = logging.getLogger(__name__)
 
-DEFAULT_REKOR_URL = "https://rekor.sigstore.dev"
-STAGING_REKOR_URL = "https://rekor.sigstage.dev"
-
-# TODO: Link to merged documenation.
-# See https://github.com/sigstore/rekor-tiles/pull/255/files#diff-eb568acf84d583e4d3734b07773e96912277776bad39c560392aa33ea2cf2210R196
-CREATE_ENTRIES_TIMEOUT_SECONDS = 20
-
 DEFAULT_KEY_DETAILS = common_v1.PublicKeyDetails.PKIX_ECDSA_P384_SHA_256
 
 
 class RekorV2Client(RekorLogSubmitter):
-    """The internal Rekor client for the v2 API"""
+    """The internal Rekor client for the v2 API
 
-    # TODO: implement get_tile, get_entry_bundle, get_checkpoint.
+    See https://github.com/sigstore/rekor-tiles/blob/main/CLIENTS.md
+    """
 
     def __init__(self, base_url: str) -> None:
         """
@@ -75,12 +69,15 @@ def __del__(self) -> None:
     def create_entry(self, payload: EntryRequest) -> LogEntry:
         """
         Submit a new entry for inclusion in the Rekor log.
+
+        Note that this call can take a fairly long time as the log
+        only responds after the entry has been included in the log.
+        https://github.com/sigstore/rekor-tiles/blob/main/CLIENTS.md#handling-longer-requests
         """
         _logger.debug(f"proposed: {json.dumps(payload)}")
         resp = self.session.post(
             f"{self.url}/log/entries",
             json=payload,
-            timeout=CREATE_ENTRIES_TIMEOUT_SECONDS,
         )
 
         try:

test/unit/internal/rekor/test_client_v2.py

@@ -11,10 +11,11 @@
 
 ALPHA_REKOR_V2_URL = "https://log2025-alpha1.rekor.sigstage.dev"
 
+
 @pytest.mark.staging
 @pytest.mark.ambient_oidc
 def test_rekor_v2_create_entry_dsse(staging):
-    # This is not a real unit test: it requires not only staging rekor but also TUF 
+    # This is not a real unit test: it requires not only staging rekor but also TUF
     # fulcio and oidc -- maybe useful only until we have real integration tests in place
     sign_ctx_cls, _, identity = staging
 
@@ -50,18 +51,16 @@ def test_rekor_v2_create_entry_dsse(staging):
 @pytest.mark.staging
 @pytest.mark.ambient_oidc
 def test_rekor_v2_create_entry_hashed_rekord(staging):
-    # This is not a real unit test: it requires not only staging rekor but also TUF 
+    # This is not a real unit test: it requires not only staging rekor but also TUF
     # fulcio and oidc -- maybe useful only until we have real integration tests in place
     sign_ctx_cls, _, identity = staging
 
     # Hack to run Signer.sign() with staging rekor v2
     sign_ctx = sign_ctx_cls()
     sign_ctx._rekor = RekorV2Client(ALPHA_REKOR_V2_URL)
 
-
     with sign_ctx.signer(identity) as signer:
         bundle = signer.sign_artifact(b"")
 
     assert isinstance(bundle.log_entry, LogEntry)
     assert isinstance(bundle.log_entry._to_rekor(), rekor_v1.TransparencyLogEntry)
-