rekor: Refactor Session handling in RekorClient

Make every RekorLog have a Session of their own by default.
This means RekorClient no longer needs to manage that.

Signed-off-by: Jussi Kukkonen <[email protected]>

Author: jku

sigstore/_internal/rekor/client.py

@@ -73,10 +73,20 @@ def from_response(cls, dict_: dict[str, Any]) -> RekorLogInfo:
 
 
 class _Endpoint(ABC):
-    def __init__(self, url: str, session: requests.Session) -> None:
+    def __init__(self, url: str, session: requests.Session | None = None) -> None:
         # Note that _Endpoint may not be thread be safe if the same Session is provided
         # to an _Endpoint in multiple threads
         self.url = url
+        if session is None:
+            session = requests.Session()
+            session.headers.update(
+                {
+                    "Content-Type": "application/json",
+                    "Accept": "application/json",
+                    "User-Agent": USER_AGENT,
+                }
+            )
+
         self.session = session
 
 
@@ -213,19 +223,6 @@ def __init__(self, url: str) -> None:
         """
         self.url = f"{url}/api/v1"
 
-    def _session(self) -> requests.Session:
-        # We do not use a long living session to avoid potential thread safety issues:
-        # submitting entries via create_entry() should be thread safe.
-        session = requests.Session()
-        session.headers.update(
-            {
-                "Content-Type": "application/json",
-                "Accept": "application/json",
-                "User-Agent": USER_AGENT,
-            }
-        )
-        return session
-
     @classmethod
     def production(cls) -> RekorClient:
         """
@@ -248,9 +245,7 @@ def log(self) -> RekorLog:
         Returns a `RekorLog` adapter for making requests to a Rekor log.
         """
 
-        # Each RekorLog gets their own session
-        with self._session() as s:
-            return RekorLog(f"{self.url}/log", session=s)
+        return RekorLog(f"{self.url}/log")
 
     def create_entry(self, request: EntryRequestBody) -> LogEntry:
         """