Skip to content

Commit cb12614

Browse files
authored
chore(deps): bump rfc3161-client to >= 1.0.3 (#1450)
1 parent 153e9c4 commit cb12614

File tree

3 files changed

+4
-5
lines changed

3 files changed

+4
-5
lines changed

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ dependencies = [
3636
"requests",
3737
"rich >= 13,< 15",
3838
"rfc8785 ~= 0.1.2",
39-
"rfc3161-client >= 1.0.2,< 1.1.0",
39+
"rfc3161-client >= 1.0.3,< 1.1.0",
4040
# NOTE(ww): Both under active development, so strictly pinned.
4141
"sigstore-protobuf-specs == 0.4.3",
4242
"sigstore-rekor-types == 0.0.18",

sigstore/verify/verifier.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -131,8 +131,7 @@ def _verify_signed_timestamp(
131131

132132
verifier = builder.build()
133133
try:
134-
# TODO: remove ignore after rfc3161-client upgrade
135-
verifier.verify_message(timestamp_response, message) # type: ignore[attr-defined]
134+
verifier.verify_message(timestamp_response, message)
136135
except Rfc3161VerificationError as e:
137136
_logger.debug("Unable to verify Timestamp with CA.")
138137
_logger.exception(e)

test/unit/verify/test_verifier.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -350,8 +350,8 @@ def test_late_timestamp(self, caplog, verifier, asset, null_policy):
350350
)
351351

352352
assert (
353-
caplog.records[0].message
354-
== "Error while verifying certificates: Unable to verify certificate"
353+
"Error while verifying certificates: Unable to verify pkcs7 signature"
354+
in caplog.records[0].message
355355
)
356356

357357
def test_verifier_not_enough_timestamp(

0 commit comments

Comments
 (0)