Rename try_ methods to partial_ instead where appropriate

Author: sigurd4

Cargo.toml

@@ -18,7 +18,7 @@ alloc = ["slice_ops/alloc", "array_trait/alloc"]
 [dependencies]
 moddef = "0.2.6"
 array_trait = "1.0.7"
-slice_ops = "1.0.7"
+slice_ops = {path = "../slice_ops"} #"1.0.7"
 
 [dev-dependencies]
 tokio-test = "0.4.4"

src/lib.rs

@@ -201,7 +201,7 @@ pub mod asm
     #[inline(never)]
     pub fn magnitude(a: [i32; N]) -> Option<i32>
     {
-        a.try_magnitude_squared()
+        a.partial_magnitude_squared()
     }
 
     #[inline(never)]

src/ops/_1d/magnitude.rs

@@ -1,21 +1,27 @@
 use core::ops::{AddAssign, Mul};
 
-use super::ArrayPartialMulDot;
+use slice_ops::ops::SliceVisit;
+
+use super::{ArrayPartialMulDot, ArrayVisit};
 
 #[const_trait]
 pub trait ArrayPartialMagnitude<T, const N: usize>: ArrayPartialMulDot<T, N>
 {
-    fn try_magnitude_squared(&self) -> Option<<T as Mul<T>>::Output>
+    fn partial_magnitude_squared(&self) -> Option<<T as Mul<T>>::Output>
     where
         T: Mul<T, Output: AddAssign> + Copy;
-    async fn try_magnitude_squared_async(&self) -> Option<<T as Mul<T>>::Output>
+    fn magnitude_squared_from<O>(&self, from: O) -> O
+    where
+        T: Mul<T> + Copy,
+        O: AddAssign<<T as Mul<T>>::Output>;
+    async fn partial_magnitude_squared_async(&self) -> Option<<T as Mul<T>>::Output>
     where
         T: Mul<T, Output: AddAssign> + Copy;
 }
 
 impl<T, const N: usize> ArrayPartialMagnitude<T, N> for [T; N]
 {
-    fn try_magnitude_squared(&self) -> Option<<T as Mul<T>>::Output>
+    fn partial_magnitude_squared(&self) -> Option<<T as Mul<T>>::Output>
     where
         T: Mul<T, Output: AddAssign> + Copy
     {
@@ -33,10 +39,18 @@ impl<T, const N: usize> ArrayPartialMagnitude<T, N> for [T; N]
         }
         Some(y)
     }
-    async fn try_magnitude_squared_async(&self) -> Option<<T as Mul<T>>::Output>
+    fn magnitude_squared_from<O>(&self, mut from: O) -> O
+    where
+        T: Mul<T> + Copy,
+        O: AddAssign<<T as Mul<T>>::Output>
+    {
+        self.visit(|x| from += *x**x);
+        from
+    }
+    async fn partial_magnitude_squared_async(&self) -> Option<<T as Mul<T>>::Output>
     where
         T: Mul<T, Output: AddAssign> + Copy
     {
-        self.try_mul_dot_async(*self).await
+        self.partial_mul_dot_async(*self).await
     }
 }

src/ops/_1d/mul_dot.rs

@@ -10,12 +10,12 @@ use super::{sum::ArrayPartialSum, ArrayZipWith};
 #[const_trait]
 pub trait ArrayPartialMulDot<T, const N: usize>: Array + AsSlice<Item = T>
 {
-    fn try_mul_dot<Rhs>(self, rhs: Rhs) -> Option<<T as Mul<Rhs::Elem>>::Output>
+    fn partial_mul_dot<Rhs>(self, rhs: Rhs) -> Option<<T as Mul<Rhs::Elem>>::Output>
     where
         Rhs: ArrayForm<N>,
         T: Mul<Rhs::Elem, Output: AddAssign>;
 
-    async fn try_mul_dot_async<Rhs>(self, rhs: Rhs) -> Option<<T as Mul<Rhs::Elem>>::Output>
+    async fn partial_mul_dot_async<Rhs>(self, rhs: Rhs) -> Option<<T as Mul<Rhs::Elem>>::Output>
     where
         Rhs: ArrayForm<N>,
         T: Mul<Rhs::Elem, Output: AddAssign>;
@@ -35,7 +35,7 @@ pub trait ArrayPartialMulDot<T, const N: usize>: Array + AsSlice<Item = T>
 
 impl<T, const N: usize> ArrayPartialMulDot<T, N> for [T; N]
 {
-    fn try_mul_dot<Rhs>(self, rhs: Rhs) -> Option<<T as Mul<Rhs::Elem>>::Output>
+    fn partial_mul_dot<Rhs>(self, rhs: Rhs) -> Option<<T as Mul<Rhs::Elem>>::Output>
     where
         Rhs: ArrayForm<N>,
         T: Mul<Rhs::Elem, Output: AddAssign>
@@ -63,7 +63,7 @@ impl<T, const N: usize> ArrayPartialMulDot<T, N> for [T; N]
         value
     }
 
-    async fn try_mul_dot_async<Rhs>(self, rhs: Rhs) -> Option<<T as Mul<Rhs::Elem>>::Output>
+    async fn partial_mul_dot_async<Rhs>(self, rhs: Rhs) -> Option<<T as Mul<Rhs::Elem>>::Output>
     where
         Rhs: ArrayForm<N>,
         T: Mul<Rhs::Elem, Output: AddAssign>
@@ -103,7 +103,7 @@ impl<T, const N: usize> ArrayPartialMulDot<T, N> for [T; N]
         T: Mul<Rhs::Elem, Output = U>,
         U: AddAssign
     {
-        if let Some(x) = self.try_mul_dot_async(rhs).await
+        if let Some(x) = self.partial_mul_dot_async(rhs).await
         {
             bias += x
         }

src/ops/_1d/product.rs

@@ -8,20 +8,20 @@ use super::{ArrayDivideAndConquer, ArrayFold, ArrayReduce};
 #[const_trait]
 pub trait ArrayPartialProduct<T, const N: usize>: Array + AsSlice<Item = T>
 {
-    fn try_product(self) -> Option<T>
+    fn partial_product(self) -> Option<T>
     where
         T: MulAssign;
     fn product_from<P>(self, from: P) -> P
     where
         P: MulAssign<T>;
-    async fn try_product_async(self) -> Option<T>
+    async fn partial_product_async(self) -> Option<T>
     where
         T: MulAssign;
 }
 
 impl<T, const N: usize> ArrayPartialProduct<T, N> for [T; N]
 {
-    fn try_product(self) -> Option<T>
+    fn partial_product(self) -> Option<T>
     where
         T: MulAssign
     {
@@ -39,7 +39,7 @@ impl<T, const N: usize> ArrayPartialProduct<T, N> for [T; N]
             x
         })
     }
-    async fn try_product_async(self) -> Option<T>
+    async fn partial_product_async(self) -> Option<T>
     where
         T: MulAssign
     {

src/ops/_1d/proj.rs

@@ -25,8 +25,8 @@ impl<T, const N: usize> ArrayProj<T, N> for [T; N]
         {
             return private::empty()
         }
-        let uv = self.try_mul_dot(rhs);
-        let uu = self.try_magnitude_squared();
+        let uv = self.partial_mul_dot(rhs);
+        let uu = self.partial_magnitude_squared();
         let a = unsafe {
             uv.unwrap_unchecked()/uu.unwrap_unchecked()
         };
@@ -41,8 +41,8 @@ impl<T, const N: usize> ArrayProj<T, N> for [T; N]
             return private::empty()
         }
         let (uv, uu) = core::future::join!(
-            self.try_mul_dot_async(rhs),
-            self.try_magnitude_squared_async()
+            self.partial_mul_dot_async(rhs),
+            self.partial_magnitude_squared_async()
         ).await;
         let a = unsafe {
             uv.unwrap_unchecked()/uu.unwrap_unchecked()