feat: acid test Asset Manager (#121) (#157)

* test #121: enhance asset manager coverage with edge cases and boundary tests

Add 19 new tests covering:
- Token expiry validation (30-min TTL across all 10 prepare methods)
- Optional fields pass-through to preview
- Edit snippet partial updates (name-only, language-only, content-only)
- Clone/archive non-cloneable type completeness (file, snippet)
- Clone without newName
- Boundary tests through prepare methods (200/201 chars, 100k content)
- Constructor URL encoding for special characters

Total: 83 → 102 tests

* feat #121: improve asset manager CLI help text and file list output

- Enhanced descriptions for parent command and all 6 sub-type groups
  with Bloomreach-specific context (what each asset type is used for)
- Added fileSize display to files list human-readable output

Author: sigvardt

packages/cli/src/bin/bloomreach.ts

@@ -3256,9 +3256,9 @@ vouchers
 
 const assets = program
   .command('assets')
-  .description('Manage Asset Manager templates, snippets, and files');
+  .description('Manage Bloomreach Asset Manager — email/weblayer templates, blocks, custom rows, snippets, and files used in campaigns');
 
-const assetEmailTemplates = assets.command('email-templates').description('Manage email templates');
+const assetEmailTemplates = assets.command('email-templates').description('Manage email templates — reusable HTML layouts for marketing and transactional emails');
 
 assetEmailTemplates
   .command('list')
@@ -3340,7 +3340,7 @@ assetEmailTemplates
 
 const assetWeblayerTemplates = assets
   .command('weblayer-templates')
-  .description('Manage weblayer templates');
+  .description('Manage weblayer templates — pop-ups, banners, and in-page content personalization layers');
 
 assetWeblayerTemplates
   .command('list')
@@ -3416,7 +3416,7 @@ assetWeblayerTemplates
     },
   );
 
-const assetBlocks = assets.command('blocks').description('Manage content blocks');
+const assetBlocks = assets.command('blocks').description('Manage content blocks — reusable drag-and-drop sections for the visual email editor');
 
 assetBlocks
   .command('list')
@@ -3492,7 +3492,7 @@ assetBlocks
     },
   );
 
-const assetCustomRows = assets.command('custom-rows').description('Manage custom rows');
+const assetCustomRows = assets.command('custom-rows').description('Manage custom rows — custom HTML rows that extend the visual editor row library');
 
 assetCustomRows
   .command('list')
@@ -3568,7 +3568,7 @@ assetCustomRows
     },
   );
 
-const assetSnippets = assets.command('snippets').description('Manage snippets');
+const assetSnippets = assets.command('snippets').description('Manage snippets — reusable Jinja or HTML fragments embedded in templates');
 
 assetSnippets
   .command('list')
@@ -3696,7 +3696,7 @@ assetSnippets
     },
   );
 
-const assetFiles = assets.command('files').description('Manage files');
+const assetFiles = assets.command('files').description('Manage files — images, documents, and fonts uploaded for use in campaigns');
 
 assetFiles
   .command('list')
@@ -3724,6 +3724,7 @@ assetFiles
           console.log(`  ${file.name}`);
           console.log(`    Category: ${file.category}`);
           console.log(`    MIME:     ${file.mimeType}`);
+          console.log(`    Size:     ${file.fileSize !== undefined ? `${file.fileSize} bytes` : 'n/a'}`);
           console.log(`    ID:       ${file.id}`);
           console.log(`    URL:      ${file.url}`);
         }

packages/core/src/__tests__/bloomreachAssetManager.test.ts

@@ -382,6 +382,14 @@ describe('BloomreachAssetManagerService', () => {
     it('throws for empty project', () => {
       expect(() => new BloomreachAssetManagerService('')).toThrow('must not be empty');
     });
+
+    it('encodes special characters in project name', () => {
+      const service = new BloomreachAssetManagerService('my project');
+      expect(service.emailTemplatesUrl).toContain('my%20project');
+
+      const service2 = new BloomreachAssetManagerService('org/proj');
+      expect(service2.emailTemplatesUrl).toContain('org%2Fproj');
+    });
   });
 
   describe('list methods', () => {
@@ -691,6 +699,38 @@ describe('BloomreachAssetManagerService', () => {
         }),
       ).toThrow('cloneable types');
     });
+
+    it('throws for file asset type', () => {
+      const service = new BloomreachAssetManagerService('test');
+      expect(() =>
+        service.prepareCloneTemplate({
+          project: 'test',
+          templateId: 'tmpl-1',
+          assetType: 'file',
+        }),
+      ).toThrow('cloneable types');
+    });
+
+    it('succeeds without newName', () => {
+      const service = new BloomreachAssetManagerService('test');
+      const result = service.prepareCloneTemplate({
+        project: 'test',
+        templateId: 'tmpl-1',
+        assetType: 'weblayer_template',
+      });
+
+      expect(result.preparedActionId).toMatch(/^pa_/);
+      expect(result.confirmToken).toMatch(/^ct_stub_/);
+      expect(result.preview).toEqual(
+        expect.objectContaining({
+          action: 'asset_manager.clone_template',
+          project: 'test',
+          templateId: 'tmpl-1',
+          assetType: 'weblayer_template',
+        }),
+      );
+      expect(result.preview.newName).toBeUndefined();
+    });
   });
 
   describe('prepareArchiveTemplate', () => {
@@ -724,6 +764,17 @@ describe('BloomreachAssetManagerService', () => {
         }),
       ).toThrow('cloneable types');
     });
+
+    it('throws for snippet asset type', () => {
+      const service = new BloomreachAssetManagerService('test');
+      expect(() =>
+        service.prepareArchiveTemplate({
+          project: 'test',
+          templateId: 'tmpl-2',
+          assetType: 'snippet',
+        }),
+      ).toThrow('cloneable types');
+    });
   });
 
   describe('prepare methods shared validation', () => {
@@ -806,4 +857,232 @@ describe('BloomreachAssetManagerService', () => {
       ).toThrow('must not be empty');
     });
   });
+
+  describe('token expiry', () => {
+    it('sets expiresAtMs to approximately 30 minutes from now', () => {
+      const service = new BloomreachAssetManagerService('test');
+      const before = Date.now();
+      const result = service.prepareCreateEmailTemplate({
+        project: 'test',
+        name: 'Expiry Test',
+      });
+      const after = Date.now();
+
+      const expectedTtl = 30 * 60 * 1000;
+      expect(result.expiresAtMs).toBeGreaterThanOrEqual(before + expectedTtl);
+      expect(result.expiresAtMs).toBeLessThanOrEqual(after + expectedTtl);
+    });
+
+    it('all prepare methods set consistent expiry', () => {
+      const service = new BloomreachAssetManagerService('test');
+      const tolerance = 1000;
+      const expectedTtl = 30 * 60 * 1000;
+
+      const results = [
+        service.prepareCreateEmailTemplate({ project: 'test', name: 'Email' }),
+        service.prepareCreateWeblayerTemplate({ project: 'test', name: 'Weblayer' }),
+        service.prepareCreateBlock({ project: 'test', name: 'Block' }),
+        service.prepareCreateCustomRow({ project: 'test', name: 'Row' }),
+        service.prepareCreateSnippet({
+          project: 'test',
+          name: 'Snippet',
+          language: 'jinja',
+          content: 'x',
+        }),
+        service.prepareEditSnippet({ project: 'test', snippetId: 'snippet-1' }),
+        service.prepareUploadFile({ project: 'test', name: 'file.png', mimeType: 'image/png' }),
+        service.prepareDeleteFile({ project: 'test', fileId: 'file-1' }),
+        service.prepareCloneTemplate({
+          project: 'test',
+          templateId: 'tmpl-1',
+          assetType: 'email_template',
+        }),
+        service.prepareArchiveTemplate({
+          project: 'test',
+          templateId: 'tmpl-2',
+          assetType: 'weblayer_template',
+        }),
+      ];
+
+      for (const result of results) {
+        const now = Date.now();
+        expect(result.expiresAtMs).toBeGreaterThanOrEqual(now + expectedTtl - tolerance);
+        expect(result.expiresAtMs).toBeLessThanOrEqual(now + expectedTtl + tolerance);
+      }
+    });
+  });
+
+  describe('optional fields in preview', () => {
+    it('prepareCreateEmailTemplate includes all optional fields when provided', () => {
+      const service = new BloomreachAssetManagerService('test');
+      const result = service.prepareCreateEmailTemplate({
+        project: 'test',
+        name: 'Email With Optional Fields',
+        builderType: 'html',
+        htmlContent: '<html><body>Hello</body></html>',
+        operatorNote: 'optional-fields-test',
+      });
+
+      expect(result.preview.builderType).toBe('html');
+      expect(result.preview.htmlContent).toBe('<html><body>Hello</body></html>');
+      expect(result.preview.operatorNote).toBe('optional-fields-test');
+    });
+
+    it('prepareCreateEmailTemplate excludes optional fields when omitted', () => {
+      const service = new BloomreachAssetManagerService('test');
+      const result = service.prepareCreateEmailTemplate({
+        project: 'test',
+        name: 'Email Without Optional Fields',
+      });
+
+      expect(result.preview.builderType).toBeUndefined();
+      expect(result.preview.htmlContent).toBeUndefined();
+      expect(result.preview.operatorNote).toBeUndefined();
+    });
+
+    it('prepareCreateWeblayerTemplate includes htmlContent when provided', () => {
+      const service = new BloomreachAssetManagerService('test');
+      const result = service.prepareCreateWeblayerTemplate({
+        project: 'test',
+        name: 'Weblayer',
+        htmlContent: '<div>banner</div>',
+      });
+
+      expect(result.preview.htmlContent).toBe('<div>banner</div>');
+    });
+
+    it('prepareUploadFile includes all optional fields when provided', () => {
+      const service = new BloomreachAssetManagerService('test');
+      const result = service.prepareUploadFile({
+        project: 'test',
+        name: 'asset.pdf',
+        mimeType: 'application/pdf',
+        fileSize: 12345,
+        category: 'document',
+        operatorNote: 'upload-optional-fields-test',
+      });
+
+      expect(result.preview.fileSize).toBe(12345);
+      expect(result.preview.category).toBe('document');
+      expect(result.preview.operatorNote).toBe('upload-optional-fields-test');
+    });
+
+    it('prepareUploadFile omits optional fields when not provided', () => {
+      const service = new BloomreachAssetManagerService('test');
+      const result = service.prepareUploadFile({
+        project: 'test',
+        name: 'logo.png',
+        mimeType: 'image/png',
+      });
+
+      expect(result.preview.fileSize).toBeUndefined();
+      expect(result.preview.category).toBeUndefined();
+      expect(result.preview.operatorNote).toBeUndefined();
+    });
+  });
+
+  describe('edit snippet partial updates', () => {
+    it('accepts update with only name', () => {
+      const service = new BloomreachAssetManagerService('test');
+      const result = service.prepareEditSnippet({
+        project: 'test',
+        snippetId: 'snippet-1',
+        name: 'New Name',
+      });
+
+      expect(result.preview.name).toBe('New Name');
+      expect(result.preview.language).toBeUndefined();
+      expect(result.preview.content).toBeUndefined();
+    });
+
+    it('accepts update with only language', () => {
+      const service = new BloomreachAssetManagerService('test');
+      const result = service.prepareEditSnippet({
+        project: 'test',
+        snippetId: 'snippet-1',
+        language: 'html',
+      });
+
+      expect(result.preparedActionId).toMatch(/^pa_/);
+      expect(result.preview.language).toBe('html');
+    });
+
+    it('accepts update with only content', () => {
+      const service = new BloomreachAssetManagerService('test');
+      const result = service.prepareEditSnippet({
+        project: 'test',
+        snippetId: 'snippet-1',
+        content: '<p>new</p>',
+      });
+
+      expect(result.preparedActionId).toMatch(/^pa_/);
+      expect(result.preview.content).toBe('<p>new</p>');
+    });
+
+    it('accepts update with no optional fields', () => {
+      const service = new BloomreachAssetManagerService('test');
+      const result = service.prepareEditSnippet({
+        project: 'test',
+        snippetId: 'snippet-1',
+      });
+
+      expect(result.preview).toEqual(
+        expect.objectContaining({
+          action: 'asset_manager.edit_snippet',
+          project: 'test',
+          snippetId: 'snippet-1',
+        }),
+      );
+      expect(result.preview.name).toBeUndefined();
+      expect(result.preview.language).toBeUndefined();
+      expect(result.preview.content).toBeUndefined();
+    });
+  });
+
+  describe('prepare method boundary validation', () => {
+    it('accepts asset name at exactly 200 characters', () => {
+      const service = new BloomreachAssetManagerService('test');
+      const result = service.prepareCreateEmailTemplate({
+        project: 'test',
+        name: 'x'.repeat(200),
+      });
+
+      expect(result.preview.name).toBe('x'.repeat(200));
+    });
+
+    it('rejects asset name at 201 characters', () => {
+      const service = new BloomreachAssetManagerService('test');
+      expect(() =>
+        service.prepareCreateEmailTemplate({
+          project: 'test',
+          name: 'x'.repeat(201),
+        }),
+      ).toThrow('must not exceed 200 characters');
+    });
+
+    it('accepts snippet content at exactly 100000 characters', () => {
+      const service = new BloomreachAssetManagerService('test');
+      const content = 'x'.repeat(100_000);
+      const result = service.prepareCreateSnippet({
+        project: 'test',
+        name: 'Boundary Snippet',
+        language: 'jinja',
+        content,
+      });
+
+      expect(result.preview.content).toBe(content);
+    });
+
+    it('rejects snippet content at 100001 characters', () => {
+      const service = new BloomreachAssetManagerService('test');
+      expect(() =>
+        service.prepareCreateSnippet({
+          project: 'test',
+          name: 'Too Long Snippet',
+          language: 'jinja',
+          content: 'x'.repeat(100_001),
+        }),
+      ).toThrow('must not exceed 100000 characters');
+    });
+  });
 });