bug symfony#61690 [Console] Don’t automatically append EOT to multiline test inputs (MatTheCat)

This PR was squashed before being merged into the 6.4 branch.

Discussion
----------

[Console] Don’t automatically append EOT to multiline test inputs

| Q             | A
| ------------- | ---
| Branch?       | 6.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Issues        | N/A
| License       | MIT

symfony#61501 assumed multiline inputs were answers to multiline questions and suffixed them with an EOT character to mark their end.

But if you’re directly reading stdin, you can have line breaks without the need for an EOT: symfony#61501 (comment)

Since the `TesterTrait` doesn’t know the inputs’ context, this PR reverts this behavior. Multiline questions will still be able to be tested by manually suffixing the answer with an EOT (`x04`) like in the added test.

If it is accepted it’ll be followed by a doc PR.

Commits
-------

938fabb [Console] Don’t automatically append EOT to multiline test inputs

Author: nicolas-grekas

src/Symfony/Component/Console/Tester/TesterTrait.php

@@ -169,10 +169,6 @@ private static function createStream(array $inputs)
 
         foreach ($inputs as $input) {
             fwrite($stream, $input.\PHP_EOL);
-
-            if (str_contains($input, \PHP_EOL)) {
-                fwrite($stream, "\x4");
-            }
         }
 
         rewind($stream);

src/Symfony/Component/Console/Tests/Tester/CommandTesterTest.php

@@ -16,7 +16,9 @@
 use Symfony\Component\Console\Command\Command;
 use Symfony\Component\Console\Helper\HelperSet;
 use Symfony\Component\Console\Helper\QuestionHelper;
+use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Output\Output;
+use Symfony\Component\Console\Output\OutputInterface;
 use Symfony\Component\Console\Question\ChoiceQuestion;
 use Symfony\Component\Console\Question\Question;
 use Symfony\Component\Console\Style\SymfonyStyle;
@@ -127,6 +129,32 @@ public function testCommandWithInputs()
         $this->assertEquals(implode('', $questions), $tester->getDisplay(true));
     }
 
+    public function testCommandWithMultilineInputs()
+    {
+        $question = 'What is your address?';
+
+        $command = new Command('foo');
+        $command->setHelperSet(new HelperSet([new QuestionHelper()]));
+        $command->setCode(function (InputInterface $input, OutputInterface $output) use ($question, $command): int {
+            $output->write($command->getHelper('question')->ask($input, $output, (new Question($question."\n"))->setMultiline(true)));
+            $output->write(stream_get_contents($input->getStream()));
+
+            return 0;
+        });
+
+        $tester = new CommandTester($command);
+
+        $address = <<<ADDRESS
+            31 Spooner Street
+            Quahog
+            ADDRESS;
+        $tester->setInputs([$address."\x04", $address]);
+        $tester->execute([]);
+
+        $tester->assertCommandIsSuccessful();
+        $this->assertSame($question."\n".$address."\n".$address."\n", $tester->getDisplay());
+    }
+
     public function testCommandWithDefaultInputs()
     {
         $questions = [