minor symfony#60061 [Validator] Don't skip WhenTest case after fix merge in php-src (alexandre-daubois)

nicolas-grekas · nicolas-grekas · commit 091ae5bd491f · 2025-03-30T11:16:43.000+02:00
This PR was merged into the 7.3 branch. Discussion ---------- [Validator] Don't skip `WhenTest` case after fix merge in `php-src` | Q | A | ------------- | --- | Branch? | 7.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | - | License | MIT Revert skip being introduced in symfony#59895 after the fix of php/php-src#17851. Commits ------- 8f4bb30 [Validator] Don't skip `WhenTest` case after fix merge in `php-src`
diff --git a/src/Symfony/Component/Validator/Tests/Constraints/WhenTest.php b/src/Symfony/Component/Validator/Tests/Constraints/WhenTest.php
@@ -118,8 +118,6 @@ public function testAttributes()
      */
     public function testAttributesWithClosure()
     {
-        $this->markTestSkipped('Requires https://github.com/php/php-src/issues/17851 to be fixed');
-
         $loader = new AttributeLoader();
         $metadata = new ClassMetadata(WhenTestWithClosure::class);
 

Original file line number	Diff line number	Diff line change
`@@ -118,8 +118,6 @@ public function testAttributes()`
`118`	`118`	`*/`
`119`	`119`	`public function testAttributesWithClosure()`
`120`	`120`	`{`
`121`		`- $this->markTestSkipped('Requires https://github.com/php/php-src/issues/17851 to be fixed');`
`122`		`-`
`123`	`121`	`$loader = new AttributeLoader();`
`124`	`122`	`$metadata = new ClassMetadata(WhenTestWithClosure::class);`
`125`	`123`