bug symfony#61615 [DependencyInjection] Fix optimizing ClassExistenceResource (nicolas-grekas)

This PR was merged into the 7.3 branch.

Discussion
----------

[DependencyInjection] Fix optimizing ClassExistenceResource

| Q             | A
| ------------- | ---
| Branch?       | 7.3
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Issues        | -
| License       | MIT

Per `@stof` review at symfony#57948 (review)

Best reviewed [ignoring whitespaces](https://github.com/symfony/symfony/pull/61615/files?w=1).

Commits
-------

b7ca948 [DependencyInjection] Fix optimizing ClassExistenceResource

Author: nicolas-grekas

src/Symfony/Component/DependencyInjection/ContainerBuilder.php

@@ -273,46 +273,58 @@ public function addResource(ResourceInterface $resource): static
         if ($resource instanceof DirectoryResource && $this->inVendors($resource->getResource())) {
             return $this;
         }
-        if ($resource instanceof ClassExistenceResource) {
-            $class = $resource->getResource();
+        if (!$resource instanceof ClassExistenceResource) {
+            $this->resources[(string) $resource] = $resource;
 
-            $inVendor = false;
-            foreach (spl_autoload_functions() as $autoloader) {
-                if (!\is_array($autoloader)) {
-                    continue;
-                }
+            return $this;
+        }
 
-                if ($autoloader[0] instanceof DebugClassLoader) {
-                    $autoloader = $autoloader[0]->getClassLoader();
-                }
+        $class = $resource->getResource();
+
+        if (!(new ClassExistenceResource($class, false))->isFresh(1)) {
+            if (!$this->inVendors((new \ReflectionClass($class))->getFileName())) {
+                $this->resources[$class] = $resource;
+            }
+
+            return $this;
+        }
+
+        $inVendor = true;
+        foreach (spl_autoload_functions() as $autoloader) {
+            if (!\is_array($autoloader)) {
+                $inVendor = false;
+                break;
+            }
+
+            if ($autoloader[0] instanceof DebugClassLoader) {
+                $autoloader = $autoloader[0]->getClassLoader();
+            }
 
-                if (!\is_array($autoloader) || !$autoloader[0] instanceof ClassLoader || !$autoloader[0]->findFile(__CLASS__)) {
+            if (!\is_array($autoloader) || !$autoloader[0] instanceof ClassLoader) {
+                $inVendor = false;
+                break;
+            }
+
+            foreach ($autoloader[0]->getPrefixesPsr4() as $prefix => $dirs) {
+                if (!str_starts_with($class, $prefix)) {
                     continue;
                 }
 
-                foreach ($autoloader[0]->getPrefixesPsr4() as $prefix => $dirs) {
-                    if ('' === $prefix || !str_starts_with($class, $prefix)) {
+                foreach ($dirs as $dir) {
+                    if (!$dir = realpath($dir)) {
                         continue;
                     }
 
-                    foreach ($dirs as $dir) {
-                        if (!$dir = realpath($dir)) {
-                            continue;
-                        }
-
-                        if (!$inVendor = $this->inVendors($dir)) {
-                            break 3;
-                        }
+                    if (!$inVendor = $this->inVendors($dir)) {
+                        break 3;
                     }
                 }
             }
-
-            if ($inVendor) {
-                return $this;
-            }
         }
 
-        $this->resources[(string) $resource] = $resource;
+        if (!$inVendor) {
+            $this->resources[$class] = $resource;
+        }
 
         return $this;
     }

src/Symfony/Component/DependencyInjection/Tests/ContainerBuilderTest.php

@@ -1230,7 +1230,10 @@ public function testGetReflectionClass()
         $r2 = $container->getReflectionClass('BarClass');
         $r3 = $container->getReflectionClass('BarClass');
 
-        $this->assertNull($container->getReflectionClass('BarMissingClass'));
+        $this->assertNull($container->getReflectionClass(BarMissingClass::class));
+
+        // No resource should be added for this class because no autoloader would be able to load it
+        $this->assertNull($container->getReflectionClass(\BarMissingClass::class));
 
         $this->assertEquals($r1, $r2);
         $this->assertSame($r2, $r3);
@@ -1240,7 +1243,7 @@ public function testGetReflectionClass()
         $this->assertCount(2, $resources);
 
         $this->assertSame('reflection.BarClass', (string) $resources[0]);
-        $this->assertSame('BarMissingClass', (string) end($resources));
+        $this->assertSame(BarMissingClass::class, (string) end($resources));
     }
 
     public function testGetReflectionClassOnInternalTypes()