Commit 1a8b82e
committed
This PR was merged into the 7.3 branch.
Discussion
----------
[Console] Mark `AsCommand` attribute as ``@final``
| Q | A
| ------------- | ---
| Branch? | 7.3
| Bug fix? | yes
| New feature? | no
| Deprecations? | yes
| License | MIT
`AsCommand` attribute doesn't work as expected when extended and probably should be declared as final.
In order to not break BC and trigger a deprecation warning, I marked the attribute as ``@final`` as per suggestions in previous PR.
Superseeds symfony#60066 as I closed it accidentally, sorry for confusion 😕
Commits
-------
1db80a5 [Console] Mark `AsCommand` attribute as ``@final``
File tree
3 files changed
+4
-0
lines changed- src/Symfony/Component/Console
- Attribute
3 files changed
+4
-0
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
| 43 | + | |
43 | 44 | | |
44 | 45 | | |
45 | 46 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
| 16 | + | |
| 17 | + | |
16 | 18 | | |
17 | 19 | | |
18 | 20 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
| 16 | + | |
16 | 17 | | |
17 | 18 | | |
18 | 19 | | |
| |||
0 commit comments